Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
45,338 Commits 28 Branches 142 Tags 769 MiB
Commit Graph

15 Commits

Author SHA1 Message Date
Riken Shah f95c539122 custom_check: Avoid use of assert to avoid confusion with assert.equal. 
This commit bans the use of `assert` and replaces it
with `assert.ok` to avoid confusion with `assert.equal`.

Fixes #18687.
 2021-06-10 09:15:57 -07:00
Anders Kaseorg 3ef6f6e2e2 js: Convert static/js/blueslip.js to ES6 module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-03-17 08:47:15 -04:00
Anders Kaseorg 6cd694b8e3 eslint: Fix unicorn/no-array-callback-reference. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-01-25 14:53:19 -08:00
Anders Kaseorg 21d432e12c zjsunit: Deglobalize run_test. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 425f1789e2 zjsunit: Deglobalize namespace. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 7b03d48798 zjsunit: Deglobalize assert. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 9238813135 js: Use destructuring for require statements. 
This allows import/order to auto-fix blocks including these
statements.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-09-23 09:06:07 -04:00
Anders Kaseorg 6ec808b8df js: Add "use strict" directive to CommonJS files. 
ES and TypeScript modules are strict by default and don’t need this
directive.  ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-31 22:09:46 -07:00
Anders Kaseorg f3726db89a js: Normalize strings to double quotes. 
Prettier would do this anyway, but it’s separated out for a more
reviewable diff.  Generated by ESLint.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:24 -07:00
Rohitt Vashishtha c8b0627ffe zblueslip: Run blueslip.reset after each test. 
This simplifies the blueslip interface to just declaring expected
errors and calling the code to test.
 2020-04-20 08:17:20 -04:00
Rohitt Vashishtha 0def4a97ae zblueslip: Implement tracking extra/lesser blueslip calls. 
We change the user facing interface to allow specifying expected
number of error messages (default=1). Now an average test can look
like:

```
    // We expect 3 error messages;
    blueslip.expect('error', 'an error message', 3);
    throwError();
    throwError();
    throwError();
    blueslip.reset();
```
 2020-04-20 08:17:20 -04:00
Steve Howell f7b432afec node tests: Auto-include zblueslip for node tests. 
We already use blueslip stubs in ~45 tests, so we
may as well just auto-include it.
 2020-04-03 12:56:49 -04:00
Steve Howell df84c52a7f zblueslip: Change API to expect/reset. 
The `set_test_data` never made complete sense to
me, since it wasn't really data that we were
setting.
 2020-04-03 12:56:49 -04:00
Anders Kaseorg da633e953e lazy_set: Convert LazySet to a real class. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Steve Howell 29e63c0417 Fix type errors in LazySet. 
I think the only place that was broken is where
we copy users from streams.
 2020-01-14 15:40:40 -08:00