Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
40,820 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

13 Commits

Author SHA1 Message Date
Anders Kaseorg 54c97c4457 node_tests: Consistently move set_global mocks before zrequire calls. 
This way, as we convert them to rewiremock, they will become available
before they are imported.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-02-26 07:55:53 -08:00
Anders Kaseorg ce42d1194d node_tests: Skip unnecessary explicit uses of global. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 21d432e12c zjsunit: Deglobalize run_test. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 425f1789e2 zjsunit: Deglobalize namespace. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 7b03d48798 zjsunit: Deglobalize assert. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-12-01 07:14:00 -05:00
Anders Kaseorg 6ec808b8df js: Add "use strict" directive to CommonJS files. 
ES and TypeScript modules are strict by default and don’t need this
directive.  ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-31 22:09:46 -07:00
Steve Howell fb06aa9419 node tests: Swap actual/expected in various assert calls. 2020-07-28 11:48:55 -04:00
Anders Kaseorg b65d2e063d js: Reformat with Prettier. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:25 -07:00
Anders Kaseorg f3726db89a js: Normalize strings to double quotes. 
Prettier would do this anyway, but it’s separated out for a more
reviewable diff.  Generated by ESLint.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2020-07-17 14:31:24 -07:00
Steve Howell b994889315 node tests: Just set i18n every time. 
Explicitly stubbing i18n in 48 different files
is mostly busy work at this point, and it doesn't
provide much signal, since often it's invoked
only to satisfy transitive dependencies.
 2020-02-28 17:11:24 -08:00
Anders Kaseorg 28f3dfa284 js: Automatically convert var to let and const in most files. 
This commit was originally automatically generated using `tools/lint
--only=eslint --fix`.  It was then modified by tabbott to contain only
changes to a set of files that are unlikely to result in significant
merge conflicts with any open pull request, excluding about 20 files.
His plan is to merge the remaining changes with more precise care,
potentially involving merging parts of conflicting pull requests
before running the `eslint --fix` operation.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-11-03 12:42:39 -08:00
Akash Nimare 0a7b487617 hotkey: Update test for hotkey deprecation. 
This commit adds a test for hotkey deprecation since
we need to test the 'CMD' hotkey on macOS.
 2018-09-21 10:59:55 -07:00
Marco Burstein bb09bea0b6 ui: Simplify hotkey deprecation notices. 
To reduce code duplication when creating hotkey deprecation notices,
create the `get_hotkey_deprecation_notice` function. Also, create a
`ui` testing file with a test for the new function.

Fix #10004.
 2018-07-23 22:41:59 -07:00