Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
45,566 Commits 28 Branches 143 Tags 614 MiB
Commit Graph

45566 Commits

Author SHA1 Message Date
BIKI DAS 42dd58cffe
docs: Fix a few typos in documentation. 2021-12-28 09:36:59 -08:00
Steve Howell d62b39450e performance: Optimize send_subscription_add_events. 
We avoid repeating the same calculations over and
over again for the same stream.

This helps, but the real bottleneck in this function
is that send_event usually takes at least a millisecond,
and that adds up quickly if you're doing something
like subscribing 5k users to a new stream.
 2021-12-28 09:33:16 -08:00
Anders Kaseorg bc69f213a0 requirements: Upgrade Python requirements. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg 60eed65832 scim: Placate mypy 0.930. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg c8dd90f32b bot_config: Placate mypy 0.930. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg 575932f4e0 actions: Placate mypy 0.930. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg 95cddff39b test_scim: Placate mypy 0.930. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg b73a6b7b06 test_stripe: What even is how to code I don’t know help. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg f45b245f74 test_urls: Fix get_callback_string logic. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg 48190cf744 test_timezone: Fix ambiguous_abbrevs type. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg c4c28e06d9 test_openapi: Replace convert_regex_to_url_pattern. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg e3a8f992d5 test_openapi: Fix __wrapped__ accesses. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg d40f3d54f1 test_console_output: Implement the entire TextIO contract. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Anders Kaseorg 702ce071f4 python: Accept Optional[FrameType] in signal handlers. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-28 09:31:55 -08:00
Alex Vandiver 7a9074ecfd puppet: Use shorter local variable for supervisor conf.d dir. 2021-12-28 09:24:01 -08:00
Alex Vandiver 670fad0cc4 puppet: Drop now-unnecessary supervisor file removals. 2021-12-28 09:24:01 -08:00
BIKI DAS d7f5d041b9
typo: Rename default_hander to default_handler. 2021-12-28 09:19:57 -08:00
BIKI DAS c1134a8bda
docs: Fix "should should" typo. 2021-12-28 09:19:04 -08:00
Anders Kaseorg 2ff3b51e03 test-documentation: Suppress Unicode Private Use Area validator warning. 
sphinx_rtd_theme references the Font Awesome fa-link icon directly
with U+F0C1.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 16:55:31 -08:00
Anders Kaseorg 591bd3f4a1 webhooks: Rename Yo App to Yo. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg 1d3520db12 webhooks: Remove space from UptimeRobot. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg 68c99511a2 webhooks: Fix TeamCity capitalization. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg 65868b09eb webhooks: Add missing space in Review Board. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg c02c053ec3 webhooks: Fix Mailchimp capitalization. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg dc72f79a83 webhooks: Fix Canarytokens pluralization. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg cd8a01587b webhooks: Fix Jotform capitalization. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Anders Kaseorg 3ca2f8ca1e webhooks: Fix Clubhouse capitalization. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-22 14:05:17 -08:00
Shlok Patel b1436aed9c production: Create stream in an atomic transaction. 
To avoid the window between stream creation and creation of the
Recipient object, we create the stream in an atomic transaction.

Fixes #20127
 2021-12-21 15:45:45 -08:00
Anders Kaseorg dc18aadeb2 test_classes: Type kwargs for client_get and friends. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-17 08:03:52 -08:00
Anders Kaseorg 27977eddeb export: Use tar -C to switch directories. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-17 08:01:53 -08:00
Anders Kaseorg 6855df0abb export_single_user: Fix usage with relative --output directory. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-17 08:01:53 -08:00
Anders Kaseorg 0daf32310e export_single_user: Refuse to overwrite a nonempty directory. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-17 08:01:53 -08:00
Anders Kaseorg 0b454dda12 install: Try apt-get update if the Ubuntu universe check fails. 
On a system where ‘apt-get update’ has never been run, ‘apt-cache
policy’ may show no repositories at all.  Try to correct this with
‘apt-get update’ before giving up.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-16 17:56:23 -08:00
Steve Howell 3138f7a73c mypy: Fix content types. 
This got by mypy due to Message being an Any type.
 2021-12-16 20:35:56 -05:00
Anders Kaseorg 517ddbc9e6 setup-advanced: Remove misleading python3 symlink suggestion. 
One should never have to manually symlink things in /usr/bin,
especially with -f.  That should be managed by the system package
manager.  Indeed, on CentOS 7 and 8, one can simply install the
python3 package and get a working /usr/bin/python3.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-12-16 17:30:04 -08:00
Steve Howell 0b0faa46b4 mypy: Use object type for checker return values. 2021-12-16 19:52:35 -05:00
Tim Abbott e152f255f5 test_upload: Remove GIF file extension test. 
This change should have been in the previous commit.
 2021-12-16 16:16:34 -08:00
Tim Abbott 22b5e105e6 upload: Remove incorrect animated GIF asserts. 
GIF files can be `.GIF`, and also we determine the file format by
inspecting the image data, so there's no reason to have this
assertion.

(The code for serving still images does not rely on the file being a
GIF.)
 2021-12-16 16:13:00 -08:00
Steve Howell 7f8ea5b9f2 stream edit: Find stuff within parent_container. 
This will facilitate code reuse.
 2021-12-16 15:28:11 -08:00
Steve Howell 2194a51b97 refactor: Extract people.get_users_from_ids. 2021-12-16 15:28:11 -08:00
Steve Howell 6c9427340a refactor: Move user-sorting code to people.js. 
We also remove the blueslip check, since it is
pretty easy to audit the callers here.
 2021-12-16 15:28:11 -08:00
Steve Howell ab8b550cda stream settings: Extract enable_subscriber_management. 
The name here is accounting for future plans where
we will share code for both of these use cases:

    * editing subscribers on current stream (now)
    * editing subscribers on new stream (upcoming)
 2021-12-16 15:28:11 -08:00
Steve Howell 931a8f28a0 stream settings: Simpify code to find input pill. 
We also future-proof against having multiple input
tags in the stream-edit container.
 2021-12-16 15:28:11 -08:00
Steve Howell 585ca1bc26 stream settings: Extract stream_settings_containers.js. 
This has two long-term goals:

    - avoid circular dependencies between
      stream_ui_updates and stream_edit

    - facilitate code reuse for adding subscribers
      to a new stream (i.e. using same widget for
      when you edit subscribers)
 2021-12-16 15:28:11 -08:00
Sahil Batra 1b23cbdf3e do_change_user_role: Use transaction.atomic. 2021-12-16 14:24:30 -08:00
Sahil Batra 168f241ff0 do_create_user: Use transaction.atomic. 
Have kept process_new_human_user out of
the atomic block because it involves many
different operations and also sends events.
Tried enclosing event in on_commit but that
would need many changes in the tests, so have
skipped it for now.
 2021-12-16 14:24:30 -08:00
Lauryn Menard 9321095406 tests: Update event tests for `do_update_message` action. 
Updates testing helpers in `event_schema.py` for `do_update_message` so
that all stream message fields are present in any edits / updates to
stream messages. Adds verfication tests of events returned from private
message edits and from stream message content-only and topic-only edits.
 2021-12-16 11:01:31 -08:00
Lauryn Menard 3b72da8a7c api: Include `stream_id` field for all edits to stream messages. 
Updates the `update_message` event type to always include a `stream_id`
field when the message being edited is a stream message. This change
aligns with the current definition of the `\get-events` endpoint
in the OpenAPI documentation.
 2021-12-16 11:01:31 -08:00
Tim Abbott 1dc36c3f16 policies: Fix typo in Data Processing Addendum. 
The previous copy referenced "Terms of Use" rather than "Terms of
Service".
 2021-12-14 23:20:19 -08:00
Tim Abbott ed01e16f60 send_custom_email: Fix dry run with --remote-servers. 2021-12-14 23:19:00 -08:00