40f550038d
subs: Replace all `in_home_view` uses with `is_muted` property.
...
Replace all uses of `in_home_view` subscription property
with `is_muted` property in frontend.
Fixes #12322
2019-05-30 21:39:06 -07:00
f73600c82c
rate_limiter: Create a general rate_limit_request_by_entity function.
2019-05-30 16:50:11 -07:00
22d0cd9696
url preview: Don't cache embed data when fetch has network errors.
2019-05-30 16:45:22 -07:00
69ec96b63e
search suggestion: Hide email under hidden email-address-visibility cases.
...
This commit hides the email address from the search bar for the email
hidden cases.
2019-05-30 16:22:54 -07:00
03d188b5bd
settings_org: Fix show_email function when email visibility is admin only.
...
`show_email` function should return false when email visibility is set
anything other than `everyone` (, for now, irrespective of privileges).
2019-05-30 16:22:54 -07:00
c691ed433b
settings_org: Fix the typo in `settings_org.show_email()` function.
2019-05-30 16:22:54 -07:00
5ff27c130a
info-overlay: Fix "message formating" styling.
...
This reverts the temporary solution from 04d9d1d
2019-05-30 16:18:54 -07:00
43bc1d4d5a
info-overlay: Increase size of arrow icons.
2019-05-30 16:18:54 -07:00
5f1a32a9ee
arrow-icons: Replace ⇽ , ⇾ with ← , → everywhere.
...
We were using these hollowed out arrows characters (⇽ , ⇾) in a few
places, these were inconsistent with the solid up and down arrow
characters (↑ , ↓) we use otherwise. This commit replaces them
everywhere in the codebase.
2019-05-30 16:18:54 -07:00
19ad090c99
info-overlay: Switch arrow key names to icons.
...
This commit switches "Up" with "↑", "Down" with "↓" and etc.
2019-05-30 16:18:54 -07:00
eeeaf01eef
Vagrantfile: Update Docker fallback patch for installed but broken case.
...
The corresponding upstream PR has been updated as well.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 16:01:45 -07:00
f366c50913
user_info: Add bot owner to the user info popover.
...
This includes all the changes on the frontend side to include the
bot owner in the popover. Includes the bot owner name as a link which
opens the full profile of the bot owner.
For bots without any owner (such as Notification Bot or Welcome Bot)
in place of bot owner name, 'System Bot' appears for cross realm bots
and 'Bot' for in-realm bots.
Fixes #10844 .
2019-05-30 15:45:56 -07:00
20d4aa96a9
user_info: Add `is_cross_realm_bot` to user info dataset.
2019-05-30 15:43:18 -07:00
3462db3ecc
node: Add test for updating bot_owner_id and enable user_events test suite.
...
Reverts the commit 4442509ec3
2019-05-30 15:43:18 -07:00
55bf44152a
import: Handle hidden_by_limit case for files in slack import.
...
Fixes #12011
2019-05-30 12:01:09 -07:00
4facc93670
retention: Add archiving of SubMessages.
2019-05-30 11:40:20 -07:00
37c42a09e5
retention: Archiving of models tied to a Message, applied to Reactions.
...
We add general code that will archive models that are tied to a specific
Message (such as Reactions and SubMessages). Certain details of the
model are grabbed from a list models_with_message_key, and then used to
create queries that will archive these database tables.
We put Reaction in that list in this commit, and add appropriate tests.
To have archiving of other analogical models (for example SubMessage),
one only needs to make an appropriate entry in the
models_with_message_key list.
2019-05-30 11:40:20 -07:00
dfee559333
test_retention: Check that Reactions get correctly deleted.
2019-05-30 11:33:41 -07:00
29729b7748
test_retention: Check that SubMessages get correctly deleted.
2019-05-30 11:27:38 -07:00
6d69405f54
test_retention: Keep helper functions in a base class.
2019-05-30 11:27:38 -07:00
2370e6717c
test_retention: Factor out _make_expired_zulip_messages helper function.
2019-05-30 11:27:38 -07:00
b52a7aed07
docs: Move tutorials/documenting-api-endpoints to documentation/api.
...
Move docs/tutorials/documenting-api-endpoint.md to
docs/documentation/api.md.
This makes it easier to find when browsing the complete set of
materials on writing Zulip documentation.
2019-05-30 11:12:25 -07:00
b67d263b1a
api docs: Avoid using \" in curl examples.
...
It's much cleaner to encode the JSON without quote-escaping.
closes #12196 .
2019-05-30 11:05:41 -07:00
d9f12cfb49
documentation_crawler: They’re called fragments, not permalinks.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
4f28b88746
documentation_crawler: Set a 15 second download timeout.
...
By default it just hangs for as long as the server keeps the
connection open.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
c59747360a
documentation_crawler: Set the default log level to warning.
...
This doesn’t seem to add any noise in the normal case, but if anything
shows up here we might want to see it.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
2f547eaee4
documentation_crawler: Improve error handling.
...
* Remove the custom has_error logic in favor of checking whether any
errors were logged, which gives us a much better chance at catching
unanticipated exceptions.
* Use our error_callback for the initial requests of start_urls too.
* Clean up mypy types.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
4c60e994c8
test-documentation: Fail on any nonzero exit code.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
0ca9c260ae
test-documentation: Use getopt; don’t silently ignore multiple arguments.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-05-30 10:39:47 -07:00
8c249644b1
billing: Seperate out tests for invoice and autopay form fields.
2019-05-30 10:34:56 -07:00
a46b2386b6
billing: Add node tests for helpers.js.
2019-05-30 10:34:56 -07:00
b7d210a932
billing: Use javascript onhashchange handler instead of jQuery one.
...
Makes it easier to obtain the onhashchange handler
in node tests.
2019-05-30 10:34:56 -07:00
5fc538cac0
billing: Use on(click) instead of click handler.
...
Makes it easy to get the click handler in node tests.
2019-05-30 10:34:56 -07:00
50989a3380
billing: Use location.hash instead of window.location.
2019-05-30 10:34:56 -07:00
75635844db
lightbox: Set URL in payload instead of computing from video IDs.
...
Lightbox previews for youtube playlists use the "current" video in the playlist
for the preview. The open link for such previews is incorrectly set to the first
video alone, and not the playlist. This commit fixes the bug by linking to the
original URL for lightbox preview is being shown, instead of computing the URL.
2019-05-29 23:01:54 -07:00
85b8be0ace
zjquery: Add length attribute to wrapped elements.
2019-05-29 23:01:54 -07:00
be527905ca
zjquery: Add closest() method.
2019-05-29 23:01:54 -07:00
b13add3eaf
docs: Add missing index.rst for documentation/.
...
Apparently I failed to commit this part of our documentation
migration.
2019-05-29 17:54:02 -07:00
a1fadc28ba
lint: Make `custom_rules.py` pass all lint checks.
...
The functions here weren't checked by all linters when they were in
`custom_check.py`. Hence, modified to pass all lint checks.
2019-05-29 16:53:59 -07:00
90c3578a88
lint: Move `custom_check_file` from `custom_check.py` to `custom_rules.py`.
2019-05-29 16:53:59 -07:00
cf038f0880
lint: Allow shebang_rules to use `include_only/exclude`.
...
Make shebang rules generic to be later extracted out of the
`custom_check_file` function.
2019-05-29 16:53:59 -07:00
42efb60665
lint: Extract general funcs from custom_check.py to zulint/custom_rules.py.
2019-05-29 16:53:59 -07:00
337060de01
lint: Move runnable code form `pyflakes.py` to `zulint/linters`.
...
Extract runnable code from `linter_lib/pyflakes.py` and move it to
`zulint/linters`. This keeps zulip specific pyflakes config separate
form zulint.
2019-05-29 16:53:59 -07:00
352b864124
requirements: Add pyinotify dependency.
2019-05-29 16:49:33 -07:00
6d92d628a6
scrollbar: Add data-simplebar-auto-hide=False to several modals.
...
We're changing our style to always show the scrollbar on the right
pane of modals, because that makes it consistently clear when there
are more items below.
2019-05-29 16:45:42 -07:00
ac73dc81f7
settings: Remove rendered_markdown from settings overlay.
...
It's not clear why we added this (I didn't notice it in review), and
it seems to have been in error, since none of the previous CSS in
5c36918c17#12435 for the original investigation.
2019-05-29 16:43:24 -07:00
29529cf2e7
retention: Add ArchivedSubMessage model.
2019-05-29 16:26:11 -07:00
292b4bb0d7
retention: Add ArchivedReaction model.
2019-05-29 16:26:11 -07:00
2bc6d52c72
retention: Fix name of move_attachment_message_to_archive_by_message.
...
The first instance of the word "message" should be in plural. We rename
to move_attachment_message_to_archive_by_message.
2019-05-29 16:26:11 -07:00
2ca650be4d
retention: Clean up move_messages_to_archive() for more clarity.
2019-05-29 16:26:11 -07:00
Yashashvi Dave
Mateusz Mandera
Puneeth Chaganti
Pragati Agrawal
Shubham Dhama
YashRE42
Anders Kaseorg
Vaibhav
Vishnu Ks
Rafid Aslam
Hemanth V. Alluri
Tim Abbott
Aman Agrawal
Priyank Patel
Rishi Gupta