73b19672c3
message_fetch: Use user IDs for supported operators.
...
The approach taken here is basically use user IDs in operator that
support it when sending the request for fetching the messages
(see comments in code for more details).
2019-07-13 11:35:37 -07:00
e830853aee
desktop-presence: Use system presence data from electron-bridge.
...
Combined with work in the desktop app, this makes it possible for the
desktop app to clearly indicate to other users whether the current
user is active on the system and thus would see a desktop
notification, not just whether they are active in the current Zulip
window.
Essentially rewritten by tabbott to add unit tests and consider the
desktop app data authoritative.
2019-07-13 11:21:22 -07:00
adcfa68da8
templates: Remove partial helper.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-12 21:11:14 -07:00
0c565f50be
templates: Use upstream Handlebars partials syntax.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-12 21:11:14 -07:00
db0b33842c
templates: Replace templates.render with require calls.
...
This removes an unnecessary layer of indirection and allows webpack to
catch filename mistakes.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-12 21:11:14 -07:00
3c3471b720
templates: Rename *.handlebars ↦ *.hbs and - ↦ _.
...
Tweaked by tabbott to avoid accidentally disabling the linter for
handlebars templates.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-12 21:11:03 -07:00
e5d0448505
user settings: Improve accessibility for new delete profile picture button.
2019-07-12 16:53:25 -07:00
ffaa0ee120
styles: Refactor #user-settings-avatar elements to use SCSS nesting feature.
2019-07-12 16:53:25 -07:00
886deaf48d
styles: Remove superflous .white-color class.
...
Class was only used in one location, rendering it unnecessary.
2019-07-12 16:53:25 -07:00
faa556ab5e
user settings: Change delete profile picture button into a x icon.
...
Fixes part of #10255 .
2019-07-12 16:53:25 -07:00
c4f510b724
styles: Refactor #user_presences li selectors to use SCSS nesting.
2019-07-12 16:34:06 -07:00
2694dd7e24
styles: Reorder #user_presences li selectors for SCSS nesting.
2019-07-12 16:25:40 -07:00
ff2db8cf93
styles: Eliminiate duplicate selector for user/group PM circles.
2019-07-12 16:25:40 -07:00
e8e420bbd9
markdown: Fix marked generation of unnecessarily absolute URLs.
...
The new versions should exactly match the HTML we generate in the
backend unit test suite.
2019-07-11 15:09:38 -07:00
e68f90db9c
topic-mention: Support updating old renders on stream rename.
2019-07-11 14:53:10 -07:00
3698cdcc58
topic-mention: Add Marked implementation as HandleStreamTopic.
2019-07-11 14:53:10 -07:00
ff75c77f7a
account settings: Replace logic with existing functions.
...
Replace settings api calls with existing function
`settings_ui.do_settings_change()`. This commit also
adds a ui element for save alert notificaiton.
2019-07-11 13:29:08 -07:00
e2e7d288a5
user settings: Fix garbage full name in change-full-name modal.
...
We should set full name evertime we open the modal. Otherwise
it will show garbage value which user has entered before but
did not save.
2019-07-11 13:17:59 -07:00
ecddc10272
user setting: Fix error message style in change user info modals.
...
This commit fixes style of error message in update-user-info
modals. Commit adds error message element in modal body and
fixes margin.
2019-07-11 13:17:42 -07:00
da2b80c173
custom field: Make external-custom-field URL input wider.
2019-07-11 12:52:21 -07:00
27ead227c0
custom fields: Add separate alert-save widget for create field.
...
Add separate alert-notification widget for create-custom-field
in admin view.
Fixes part of #12748
2019-07-11 12:52:21 -07:00
81a7467441
css: Nest `.subscriber-list` inside `.subscriber_list_container`.
2019-07-11 12:23:42 -07:00
52027af52a
css: Nest `.subscriber_list_container` inside `.subscriber-list-box`.
2019-07-11 12:23:42 -07:00
57aedf0a46
css: Use SCSS nesting for `.subscriber_list_container`.
2019-07-11 12:23:42 -07:00
f27031925a
css: Use SCSS nesting for `.subscriber-list`.
2019-07-11 12:23:42 -07:00
39f6d0a71b
css: Reorder subscriptions.scss so `.subscriber-list` are in same place.
2019-07-11 12:23:42 -07:00
4aeb399315
apps: Fix buggy toggling with version_info.show_instructions.
...
We were doing the seemingly innocent
.toggle(version_info.show_instructions) to show the instructions if
and only if show_instructions was true. However, our data structures
that should have been false didn't set a value, and `.toggle` with no
arguments just flips the state, rather than unconditionally hiding.
2019-07-11 11:48:24 -07:00
8b729cc5fb
portico: Add links from /features to /help.
...
I left out the top section ("Beautiful messaging") because the styling would
have to be different.
2019-07-10 17:39:27 -07:00
a8bdbcab04
settings: Fix bug setting-save-alert-notification don't fade out.
...
Fix but by fixing parameters passed to function.
2019-07-10 14:41:26 -07:00
f507a1a1d9
portico: Remove scroll-to attribute support.
...
This feature was added in 3b55519b11
2019-07-10 13:12:07 -07:00
d649dce468
portico: Remove event handler on anchor tags.
...
We added custom event handlers on anchor tags to show transitions
when switching between pages, a behaviour we have since removes in
commit a0dacea811
2019-07-10 13:12:00 -07:00
90ff757f78
settings: Add some clarification around user groups.
2019-07-10 12:26:38 -07:00
5ecfcb0651
settings: Add a few (?) links to /help articles.
2019-07-10 12:26:38 -07:00
c8d6cfa9b0
settings: Note that alert words are not case sensitive.
...
Hopefully people translating to languages that don't have case will know to
ignore this second sentence.
2019-07-10 12:26:38 -07:00
239278ed90
css: Use SCSS nesting for `.stream-row`.
2019-07-10 11:30:56 -07:00
95dbe28aeb
css: Use SCSS nesting for `.stream-row .sub-info-box`.
2019-07-10 11:30:42 -07:00
b5bd0fd4f4
css: Reorder subscriptions.scss to group `sub-info-box *`.
2019-07-10 11:30:36 -07:00
218c60ae86
third: Upgrade spectrum-colorpicker to 1.8.0 from NPM.
...
We had several patches to spectrum, but the only essential one
(0ea770fc18#12749 for details.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-10 10:07:34 -07:00
5c32e2ff49
popovers: Fix migration to popovers.hide_all_except_sidebars().
...
I'm not really sure how I missed this in the original commit.
2019-07-09 23:03:41 -07:00
9c35b864fd
input pills: Update style for non editable pills.
...
For non editable input pills, add background color
to be transparent and padding to 0px.
2019-07-09 17:21:54 -07:00
5be2207bf8
user settings: Fix custom URL field style in profile form.
...
Type of input element in profile form was not defined for
URL type custom fields. Because type was not passed to
template.
2019-07-09 17:21:54 -07:00
d7ee2aced1
models: Add `external_account` in custom profile field types.
...
Add new custom profile field type, External account.
External account field links user's social media
profile with account. e.g. GitHub, Twitter, etc.
Fixes part of #12302
2019-07-09 17:21:54 -07:00
3368589df2
settings_profile_fields: Refactor function `read_field_data_from_form`.
2019-07-09 17:21:54 -07:00
bbf45593cb
blueslip: Ignore error events with null error.
...
Chrome generates these to report things like “ResizeObserver loop
limit exceeded” (which is harmless).
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 17:18:32 -07:00
f5b1081c93
popovers: Fix name for stream_popover.hide_streamlist_sidebar().
...
The previous name was super confusing; this function is analogous to
hide_userlist_sidebar() and should be named appropriately for that role.
2019-07-09 16:57:10 -07:00
01bc4674e3
popovers: Fix closing of the left sidebar with "more topics".
...
This was another case of incorrect logic due to treating the sidebars
as popovers for the purposes of .hide_all().
Fixes #12274 .
2019-07-09 16:54:39 -07:00
f86a41da4b
left_sidebar: Fix click target of links in the top left sidebar.
...
Fixes the click targets for the four links in the top left side bar
(All messages, Private messages, Mentions and Starred messages).
The click target now cover the whole row for these links.
Fixes #12449
2019-07-09 13:12:10 -07:00
ecad54e9f1
org settings: Add `wrapped-table` class in deactivated user table.
...
Fix style of deactivated user table list in org setting,
by adding `wrapped-table` class style to table.
2019-07-09 13:07:35 -07:00
fa5d6bb2d6
org settings: Display deactivated-user section to all.
...
Fixes #12290
2019-07-09 13:07:35 -07:00
6fddc86cf2
org settings: Remove strikethrough from deactivated-user setting.
...
Remove strickethrough and append text to user role.
2019-07-09 13:07:35 -07:00
1880075f81
static/js/settings_users: Remove unnecessary function from page load.
2019-07-09 13:07:35 -07:00
5a3f1e20ec
static/js/settings_users: Replace logic with existing function.
2019-07-09 13:07:35 -07:00
f9d9eca295
css: Nest `.colorpicker-container` inside `.streams_popover`.
2019-07-09 11:43:04 -07:00
d68fcfdb88
css: Nest `sp-container` in `.colorpicker-container` for `.streams_popover`.
2019-07-09 11:43:04 -07:00
84489a8d80
css: Nest `.sp-palette-container` in `.sp-container` for `.streams_popover`.
2019-07-09 11:43:04 -07:00
a7b143bda7
css: Use SCSS nesting in popovers.scss for `.group-info`.
2019-07-09 11:43:04 -07:00
d371d7438e
css: Separate `.group-info` rule from `.message-group a`.
2019-07-09 11:43:04 -07:00
1bf2b23d36
css: Use SCSS nesting in popovers.scss for `.group-info-popover`.
2019-07-09 11:43:04 -07:00
d9142dd03c
css: Move `.popover_user_presence` rules inside one block.
2019-07-09 11:43:04 -07:00
a1951c087a
css: Cleanup margin using only one rule instead of 4 different margins.
2019-07-09 11:43:04 -07:00
596420d80b
css: Remove redundant `.group-info-popover .member-list .user_circle` rule.
...
User circle inside `.group-info-popover` already has the class-name
`.popover_user_presence` which has the same properties.
2019-07-09 11:43:04 -07:00
e0a18d3394
blueslip: Replace jQuery wrappers with error event listener.
...
Not all our errors actually happen in the contexts we were
wrapping (e.g. `setTimeout` and `_.throttle`). Also this fixes the
neat Firefox inspector feature that shows you where your event
handlers for a given DOM element actually live.
Using this "semi-modern" browser event means that Safari 9 and older
and IE10 and older may not have our browser error reporting active;
that seems fine giving the vanishing market share of those browsers.
https://blog.sentry.io/2016/01/04/client-javascript-reporting-window-onerror
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:38:20 -07:00
0c80fc6aba
hashchange: Use hashchange event listener.
...
The comment that jQuery “doesn’t have” this was nonsense: jQuery
supports every event the browser does.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:35 -07:00
6a50460749
templates: Fix path to settings/dev_env_email_access.
...
This was broken in our migration to a nicer path system for our
handlebars templates.
2019-07-09 11:31:18 -07:00
ebb9a9ea9e
templates: Fix wrong path to edit-outgoing-webhook-service template.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:16 -07:00
723504f3b6
blueslip: Remove console polyfill.
...
This appears to have been a workaround for an old version of IE on an
unusual platform.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 21:47:04 -07:00
363956428a
lightbox.js: Remove computed access of exports.
...
This wouldn’t work after migration to an ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
9368c33098
unread.js: Add setter for suppress_unread_counts.
...
After migration to an ES6 module, `suppress_unread_counts` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
e24ec31823
unread.js: Add setter for messages_read_in_narrow.
...
After migration to an ES6 module, `messages_read_in_narrow` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
8472292906
pointer.js: Add setter for suppress_scroll_pointer_update.
...
After migration to an ES6 module, `suppress_scroll_pointer_update`
would no longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
f9bf414b58
pointer.js: Add setter for server_furthest_read.
...
After migration to an ES6 module, `server_furthest_read` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
e559662c8c
pointer.js: Add setter for recenter_pointer_on_display.
...
After migration to an ES6 module, `recenter_pointer_on_display` would
no longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
055ebe76aa
pointer.js: Add setter for furthest_read.
...
After migration to an ES6 module, `furthest_read` would no longer be
mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
6e4ae95994
message_viewport.js: Add setter for last_movement_direction.
...
After migration to an ES6 module, `last_movement_direction` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
15192d4417
message_list.js: Add setter for narrowed.
...
After migration to an ES6 module, `narrowed` would no longer be
mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
190524b6a0
alert_words.js: Add setter for words.
...
After migration to an ES6 module, `words` would no longer be mutable
from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
dfdbc378b0
css: Move `.user_popover .popover-title` rules inside one block.
2019-07-08 20:13:08 -07:00
b205410e27
css: Use SCSS nesting in popovers.scss for `.user_popover`.
2019-07-08 20:13:08 -07:00
58c0434474
css: Use SCSS nesting in popovers.scss for `.popover-avatar`.
2019-07-08 20:13:08 -07:00
6ed3792d21
css: Reorder popovers.scss so `.popover-avatar` are in same place.
2019-07-08 20:13:08 -07:00
abadc1fd98
css: Move `.message-info-popover .popover-title` rules inside one block.
2019-07-08 20:13:08 -07:00
6cedd4ccf5
css: Use SCSS nesting in popovers.scss for `.message-info-popovers`.
2019-07-08 20:13:08 -07:00
e25371310d
css: Reorder popovers.scss so `.message-info-popover` are in same place.
2019-07-08 20:13:08 -07:00
eab0c70d1d
css: Use SCSS nesting in popovers.scss for styles in media queries.
2019-07-08 20:13:08 -07:00
ac2074afa0
css: Use SCSS nesting in popovers.scss for `ul`.
2019-07-08 20:13:08 -07:00
9ad6874b93
css: Use SCSS nesting in popovers.scss for `.streams_popover`.
2019-07-08 20:13:08 -07:00
6e4ea91461
css: Reorder popovers.scss so `.streams_popover`s are in same place.
2019-07-08 20:13:08 -07:00
845b85847b
css: Use SCSS nesting in popovers.scss for `.popover` and title.
2019-07-08 20:13:08 -07:00
b764bd786f
css: Reorder popovers.scss so `.popover` are in same place.
2019-07-08 20:13:08 -07:00
d3e83483c8
static/js/common: Add `Ctrl` key mapping to `Cmd` for MacOS.
2019-07-08 20:07:49 -07:00
167f30aa57
css: Make paragraph-to-list spacing consistent with normal line spacing.
...
The -2px list margin was almost but not exactly cancelling the 3px
paragraph margin, resulting in a line spacing exactly 1px taller than
the normal line spacing.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 19:58:21 -07:00
b7e3f710b6
css: Specify message_content line-height in relative units.
...
This fixes (or at least reduces) a problem with inline `code blocks`
causing extra uneven vertical space below their line. The absolute
line-height was being measured relative to the lower midline of the
smaller font-size in the code blocks.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 19:58:21 -07:00
8af03b92a0
css: Use SCSS nesting in subscriptions.scss for `.stream-row .icon`.
2019-07-08 16:23:17 -07:00
d8efa258e5
css: Use SCSS nesting in subscriptions.scss for `.stream-row .check`.
2019-07-08 16:23:17 -07:00
25cb9ff240
css: Reorder subscriptions.scss so `.stream-row .check` are in same place.
2019-07-08 16:23:17 -07:00
f9dd7a8b4e
typing_status.js: Remove var state.
...
It would conflict with `exports.state` after migration to an ES6
module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:50:23 -07:00
84bc2186eb
settings_org.js: Remove var parse_time_limit.
...
It would conflict with `exports.parse_time_limit` after migration to
an ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:50:23 -07:00
653907e26a
presence.js: Remove var presence_info.
...
It would conflict with `exports.presence_info` after migration to an
ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:50:23 -07:00
ba90834a7a
info_overlay.js: Remove var toggler.
...
It would conflict with `exports.toggler` after migration to an ES6
module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:48:33 -07:00
24831e5e85
buddy_list.js: Rename var height_to_fill to height.
...
It would conflict with `exports.height_to_fill` after migration to an
ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-04 16:48:33 -07:00
Priyank Patel
vsvipul
Anders Kaseorg
Cynthia Lin
Tim Abbott
Rohitt Vashishtha
Yashashvi Dave
Vaibhav
Rishi Gupta
vinitS101
Anders Kaseorg