da9d586254
openapi: Add parameter examples for fetch api key endpoints.
2020-11-02 16:45:42 -08:00
190af58d18
subscription_settings: Fix subscriber search box width.
...
These properties were causing the search box to have a very small
width. Removing it returns search box to normal width.
2020-11-02 16:30:57 -08:00
26f630dfa1
fenced_code: Escape code_language on output in wrapped_code.
...
Strings should be escaped at the point of interpolation into a
template, not before. In this case, the early escape was hiding the
bug that code_language was only escaped if it was not found in
pygments_data.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-02 16:23:48 -08:00
ac5cbf7693
Revert "markdown: Escape lang when echoing back custom non-pygments languages."
...
This reverts commit 564b199fe6#16308 .
Escaping is either required or incorrect; it is never “defensive”.
This escaping is incorrect. lxml already escapes attributes during
serialization (any other behavior would be a serious bug), and
additional escaping just results in double escaping.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-02 16:23:48 -08:00
28aaf24a61
invite: Add Copy-to-Clipboard button for multiuse links.
...
A convenient copy-to-clipboard button was added in the Invite users to
Zulip modal, to make it slightly more convenient to share the
generated links.
The formatting is extracted to a template to make i18n and variable
substitution simpler.
Tweaked by tabbott significantly to simplify JS, HTML, and CSS.
Fixes #16442 .
2020-11-02 15:34:50 -08:00
7d21f574b7
subscriptions_overlay: Increase line height of stream name.
...
This stop some part of stream name from being hidden.
2020-11-02 12:15:33 -08:00
aa5a032087
subscriptions_overlay: Stop button from overflowing out of view.
...
This media query makes the buttons overflow out of view and are
not visible for large stream names.
2020-11-02 12:13:12 -08:00
22e598715e
create_stream: Remove no longer required condition.
...
The issue raised in the comment here seems to have been
fixed on its own. Tested on chrome and safari on macOS.
This was introduced in 2dd36aa422
2020-11-02 12:12:01 -08:00
a144f56a00
compose: Remove breaking css property.
...
When compose box is open we already set
```
$(".new_message_textarea").css("min-height", "3em");
```
in compose_actions.js.
So, this property actually reduces the min-height slightly which
hides the topic when it is long enough to span in two lines.
2020-11-02 12:10:36 -08:00
a26c0b6584
compose: Remove unused css property.
...
This property never gets used and is not necessary since it
is overridden by
```
.button.small {
font-size: 1em;
padding: 3px 10px;
}
```
in compose.css
which looks good enough.
2020-11-02 12:10:36 -08:00
e7a5588cb3
drafts: Remove unused css property.
...
Since width of drafts-container is set to 58% above, this
property never gets used.
2020-11-02 12:09:34 -08:00
93e99d0ebd
settings: Remove unused css property.
...
There is no sidebar-bottom-anchor in our codebase, because it was
removed in 96caebf38f
2020-11-02 12:07:30 -08:00
620e9cbf72
markdown: Fix merging of separate quotations.
...
Initally, when writing two or more quotes, having
a blank line in between them, merges those quotes.
This created confusion especially in "quote and reply".
This commit fixes such issues. Now two or more quotes
having a blank line in between them, will not get merged.
This change is correct both for usability and for improving our
compatibility with CommonMark.
Fixes #14379 .
2020-10-30 15:21:15 -07:00
cba7425cdc
docs: Clean up email testing docs a bit more.
2020-10-30 12:15:27 -07:00
f2b9109be5
docs: Tweak email testing notes a bit more.
2020-10-30 12:08:36 -07:00
ebe92fe70a
docs: Simplify email testing notes section.
...
No good reason for one note to be bold compared to
other notes.
2020-10-30 11:50:30 -07:00
7a6285ede7
email testing: Store the SMTP settings in dev-secrets.
...
It's super annoying to set this up each time I have to test
email templates in gmail.
2020-10-30 11:50:30 -07:00
95cd031274
version: Bump provision version for updating email templates.
2020-10-30 11:50:30 -07:00
ff754ee528
emails: Pass help link as variable in password reset email.
2020-10-30 11:50:30 -07:00
0eec12ad8b
emails: Pass reset link as variable in notify new login email.
2020-10-30 11:50:30 -07:00
0853c866a9
emails: Use link tag macro for realm uri in password reset email.
2020-10-30 11:50:30 -07:00
e53008410a
emails: Use email tag macro for email in password reset email.
2020-10-30 11:50:30 -07:00
1c08ea8134
emails: Use trans tag for ladap username in followup day 1 email.
2020-10-30 11:50:30 -07:00
abc5fb6cea
emails: Use email tag macro for email in followup day1 email.
2020-10-30 11:50:30 -07:00
df882d1563
emails: Use link tag macro for realm_uri in followup day1 email.
2020-10-30 11:50:30 -07:00
cb6ab43ba2
emails: Use link tag macro for realm_uri in realm reactivation email.
2020-10-30 11:50:30 -07:00
36b00b6b96
emails: Use email tag macro for old and new emails in confirm new email.
2020-10-30 11:50:30 -07:00
c06d8f9e45
emails: Use link tag macro for realm_uri in confirm new email.
2020-10-30 11:50:30 -07:00
4b784f8869
emails: Use macros for link tags in new login email.
2020-10-30 11:50:30 -07:00
8abf6897cb
emails: Use macros for email tags in realm reactivation email.
2020-10-30 11:50:30 -07:00
01a92abf12
emails: Use macros for email tags in notify new login email.
2020-10-30 11:50:30 -07:00
3bac784590
emails: Use macros for email tags in notify change in email.
2020-10-30 11:50:30 -07:00
689c636e29
emails: Use macros for email tags in confirm registration email.
2020-10-30 11:50:30 -07:00
0d56f3d73e
emails: Use macros for email tags in verify new email.
2020-10-30 11:50:30 -07:00
2caee3d68c
emails: Use macros for email tags in invitation reminder email.
2020-10-30 11:50:30 -07:00
eb008fc864
emails: Use macros for email tags in invitation email.
2020-10-30 11:50:30 -07:00
b98434682e
styles: Convert [readonly] selector to :read-only pseudo-class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:46:57 -07:00
192f1eb0fc
styles: Convert [disabled] selectors to :disabled pseudo-class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:46:57 -07:00
cbeeadab16
delete_realm: Register a post_delete Realm handler.
...
By registering a post_delete handler to clear appropriate caches in a
nicer way, we can get rid of the ugly flush-memcached call in the
delete_realm command.
2020-10-30 11:43:03 -07:00
bff503feb4
delete_realm: Add command to completely remove realms.
...
This will need some tweaking in upcoming commits.
2020-10-30 11:42:40 -07:00
3c663e48db
url_encoding: Skip unnecessary encode before quote.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
df10b306a6
python: Remove force_bytes.
...
We are generally good enough at types to know whether a value is str
or bytes.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
cc55393671
python: Open text files as text to skip decode operations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
18d0e4664c
python: Replace binascii with bytes.hex to skip some decode operations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
aaa7b766d8
python: Use universal_newlines to get str from subprocess.
...
We can replace ‘universal_newlines’ with ‘text’ when we bump our
minimum Python version to 3.7.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
9281dccae4
python: Serialize lxml elements directly to str.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
7c4f68d9cf
python: Skip unnecessary decode before BeautifulSoup parsing.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
86e8d81c7f
python: Skip unnecessary decode before JSON parsing.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
1802a50cc9
python: Use requests.Response.text instead of decoding content.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-30 11:36:38 -07:00
5fb667cf9e
templates: Make sure users know deletion is for everyone.
...
Implements a proposal I suggested in #16426 .
2020-10-29 17:25:40 -07:00
shanukun
Aman Agrawal
Anders Kaseorg
aniketsonu
akshatdalton
Tim Abbott
Vishnu KS
Mateusz Mandera
Alex Vandiver