Commit Graph

8251 Commits

Author SHA1 Message Date
Yashashvi Dave 3368589df2 settings_profile_fields: Refactor function `read_field_data_from_form`. 2019-07-09 17:21:54 -07:00
Anders Kaseorg bbf45593cb blueslip: Ignore error events with null error.
Chrome generates these to report things like “ResizeObserver loop
limit exceeded” (which is harmless).

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 17:18:32 -07:00
Tim Abbott f5b1081c93 popovers: Fix name for stream_popover.hide_streamlist_sidebar().
The previous name was super confusing; this function is analogous to
hide_userlist_sidebar() and should be named appropriately for that role.
2019-07-09 16:57:10 -07:00
Tim Abbott 01bc4674e3 popovers: Fix closing of the left sidebar with "more topics".
This was another case of incorrect logic due to treating the sidebars
as popovers for the purposes of .hide_all().

Fixes #12274.
2019-07-09 16:54:39 -07:00
vinitS101 f86a41da4b left_sidebar: Fix click target of links in the top left sidebar.
Fixes the click targets for the four links in the top left side bar
(All messages, Private messages, Mentions and Starred messages).
The click target now cover the whole row for these links.

Fixes #12449
2019-07-09 13:12:10 -07:00
Yashashvi Dave ecad54e9f1 org settings: Add `wrapped-table` class in deactivated user table.
Fix style of deactivated user table list in org setting,
by adding `wrapped-table` class style to table.
2019-07-09 13:07:35 -07:00
Yashashvi Dave fa5d6bb2d6 org settings: Display deactivated-user section to all.
Fixes #12290
2019-07-09 13:07:35 -07:00
Yashashvi Dave 6fddc86cf2 org settings: Remove strikethrough from deactivated-user setting.
Remove strickethrough and append text to user role.
2019-07-09 13:07:35 -07:00
Yashashvi Dave 1880075f81 static/js/settings_users: Remove unnecessary function from page load. 2019-07-09 13:07:35 -07:00
Yashashvi Dave 5a3f1e20ec static/js/settings_users: Replace logic with existing function. 2019-07-09 13:07:35 -07:00
Vaibhav f9d9eca295 css: Nest `.colorpicker-container` inside `.streams_popover`. 2019-07-09 11:43:04 -07:00
Vaibhav d68fcfdb88 css: Nest `sp-container` in `.colorpicker-container` for `.streams_popover`. 2019-07-09 11:43:04 -07:00
Vaibhav 84489a8d80 css: Nest `.sp-palette-container` in `.sp-container` for `.streams_popover`. 2019-07-09 11:43:04 -07:00
Vaibhav a7b143bda7 css: Use SCSS nesting in popovers.scss for `.group-info`. 2019-07-09 11:43:04 -07:00
Vaibhav d371d7438e css: Separate `.group-info` rule from `.message-group a`. 2019-07-09 11:43:04 -07:00
Vaibhav 1bf2b23d36 css: Use SCSS nesting in popovers.scss for `.group-info-popover`. 2019-07-09 11:43:04 -07:00
Vaibhav d9142dd03c css: Move `.popover_user_presence` rules inside one block. 2019-07-09 11:43:04 -07:00
Vaibhav a1951c087a css: Cleanup margin using only one rule instead of 4 different margins. 2019-07-09 11:43:04 -07:00
Vaibhav 596420d80b css: Remove redundant `.group-info-popover .member-list .user_circle` rule.
User circle inside `.group-info-popover` already has the class-name
`.popover_user_presence` which has the same properties.
2019-07-09 11:43:04 -07:00
Anders Kaseorg e0a18d3394 blueslip: Replace jQuery wrappers with error event listener.
Not all our errors actually happen in the contexts we were
wrapping (e.g. `setTimeout` and `_.throttle`).  Also this fixes the
neat Firefox inspector feature that shows you where your event
handlers for a given DOM element actually live.

Using this "semi-modern" browser event means that Safari 9 and older
and IE10 and older may not have our browser error reporting active;
that seems fine giving the vanishing market share of those browsers.

https://blog.sentry.io/2016/01/04/client-javascript-reporting-window-onerror

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:38:20 -07:00
Anders Kaseorg 0c80fc6aba hashchange: Use hashchange event listener.
The comment that jQuery “doesn’t have” this was nonsense: jQuery
supports every event the browser does.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:35 -07:00
Tim Abbott 6a50460749 templates: Fix path to settings/dev_env_email_access.
This was broken in our migration to a nicer path system for our
handlebars templates.
2019-07-09 11:31:18 -07:00
Anders Kaseorg ebb9a9ea9e templates: Fix wrong path to edit-outgoing-webhook-service template.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:16 -07:00
Anders Kaseorg 723504f3b6 blueslip: Remove console polyfill.
This appears to have been a workaround for an old version of IE on an
unusual platform.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 21:47:04 -07:00
Anders Kaseorg 363956428a lightbox.js: Remove computed access of exports.
This wouldn’t work after migration to an ES6 module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 9368c33098 unread.js: Add setter for suppress_unread_counts.
After migration to an ES6 module, `suppress_unread_counts` would no
longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg e24ec31823 unread.js: Add setter for messages_read_in_narrow.
After migration to an ES6 module, `messages_read_in_narrow` would no
longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 8472292906 pointer.js: Add setter for suppress_scroll_pointer_update.
After migration to an ES6 module, `suppress_scroll_pointer_update`
would no longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg f9bf414b58 pointer.js: Add setter for server_furthest_read.
After migration to an ES6 module, `server_furthest_read` would no
longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg e559662c8c pointer.js: Add setter for recenter_pointer_on_display.
After migration to an ES6 module, `recenter_pointer_on_display` would
no longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 055ebe76aa pointer.js: Add setter for furthest_read.
After migration to an ES6 module, `furthest_read` would no longer be
mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 6e4ae95994 message_viewport.js: Add setter for last_movement_direction.
After migration to an ES6 module, `last_movement_direction` would no
longer be mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 15192d4417 message_list.js: Add setter for narrowed.
After migration to an ES6 module, `narrowed` would no longer be
mutable from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Anders Kaseorg 190524b6a0 alert_words.js: Add setter for words.
After migration to an ES6 module, `words` would no longer be mutable
from outside the module.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
Vaibhav dfdbc378b0 css: Move `.user_popover .popover-title` rules inside one block. 2019-07-08 20:13:08 -07:00
Vaibhav b205410e27 css: Use SCSS nesting in popovers.scss for `.user_popover`. 2019-07-08 20:13:08 -07:00
Vaibhav 58c0434474 css: Use SCSS nesting in popovers.scss for `.popover-avatar`. 2019-07-08 20:13:08 -07:00
Vaibhav 6ed3792d21 css: Reorder popovers.scss so `.popover-avatar` are in same place. 2019-07-08 20:13:08 -07:00
Vaibhav abadc1fd98 css: Move `.message-info-popover .popover-title` rules inside one block. 2019-07-08 20:13:08 -07:00
Vaibhav 6cedd4ccf5 css: Use SCSS nesting in popovers.scss for `.message-info-popovers`. 2019-07-08 20:13:08 -07:00
Vaibhav e25371310d css: Reorder popovers.scss so `.message-info-popover` are in same place. 2019-07-08 20:13:08 -07:00
Vaibhav eab0c70d1d css: Use SCSS nesting in popovers.scss for styles in media queries. 2019-07-08 20:13:08 -07:00
Vaibhav ac2074afa0 css: Use SCSS nesting in popovers.scss for `ul`. 2019-07-08 20:13:08 -07:00
Vaibhav 9ad6874b93 css: Use SCSS nesting in popovers.scss for `.streams_popover`. 2019-07-08 20:13:08 -07:00
Vaibhav 6e4ea91461 css: Reorder popovers.scss so `.streams_popover`s are in same place. 2019-07-08 20:13:08 -07:00
Vaibhav 845b85847b css: Use SCSS nesting in popovers.scss for `.popover` and title. 2019-07-08 20:13:08 -07:00
Vaibhav b764bd786f css: Reorder popovers.scss so `.popover` are in same place. 2019-07-08 20:13:08 -07:00
Yashashvi Dave d3e83483c8 static/js/common: Add `Ctrl` key mapping to `Cmd` for MacOS. 2019-07-08 20:07:49 -07:00
Anders Kaseorg 167f30aa57 css: Make paragraph-to-list spacing consistent with normal line spacing.
The -2px list margin was almost but not exactly cancelling the 3px
paragraph margin, resulting in a line spacing exactly 1px taller than
the normal line spacing.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 19:58:21 -07:00
Anders Kaseorg b7e3f710b6 css: Specify message_content line-height in relative units.
This fixes (or at least reduces) a problem with inline `code blocks`
causing extra uneven vertical space below their line.  The absolute
line-height was being measured relative to the lower midline of the
smaller font-size in the code blocks.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 19:58:21 -07:00