3368589df2
settings_profile_fields: Refactor function `read_field_data_from_form`.
2019-07-09 17:21:54 -07:00
f813fdcd5e
populate_db: Rename URL type custom profile field.
...
Rename URL type custom profile field in populate db to avoid confusion
with the "GitHub profile" custom external account profile field we'll
be adding shortly.
2019-07-09 17:21:39 -07:00
a3fca01922
activity: Add links to /stats and /activity in /activity/support.
2019-07-09 17:20:17 -07:00
bbf45593cb
blueslip: Ignore error events with null error.
...
Chrome generates these to report things like “ResizeObserver loop
limit exceeded” (which is harmless).
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 17:18:32 -07:00
9e6ab7f190
webhooks: Migrate reviewboard tests to the headers fixtures system.
2019-07-09 17:13:02 -07:00
b609d25cda
webhooks: Migrate netlify tests to the headers fixtures system.
2019-07-09 17:13:02 -07:00
e42baff9e9
webhooks: Migrate groove tests to the headers fixtures system.
2019-07-09 17:13:02 -07:00
62bcbb433d
webhooks: Migrate bitbucket3 tests to the headers fixtures system.
2019-07-09 17:10:28 -07:00
f5b1081c93
popovers: Fix name for stream_popover.hide_streamlist_sidebar().
...
The previous name was super confusing; this function is analogous to
hide_userlist_sidebar() and should be named appropriately for that role.
2019-07-09 16:57:10 -07:00
01bc4674e3
popovers: Fix closing of the left sidebar with "more topics".
...
This was another case of incorrect logic due to treating the sidebars
as popovers for the purposes of .hide_all().
Fixes #12274 .
2019-07-09 16:54:39 -07:00
5e6d86c8c4
slack_import: Support importing multiparty IMs.
2019-07-09 15:03:28 -07:00
01d8371a2b
slack_import: Move channels test data to fixture file.
2019-07-09 15:03:28 -07:00
6758b016ac
auth: Fix social auth URL pattern for AzureAD.
...
Apparently, only the login URL was correctly updated to allow dashes
in the name of the social backend.
2019-07-09 14:18:21 -07:00
f86a41da4b
left_sidebar: Fix click target of links in the top left sidebar.
...
Fixes the click targets for the four links in the top left side bar
(All messages, Private messages, Mentions and Starred messages).
The click target now cover the whole row for these links.
Fixes #12449
2019-07-09 13:12:10 -07:00
ecad54e9f1
org settings: Add `wrapped-table` class in deactivated user table.
...
Fix style of deactivated user table list in org setting,
by adding `wrapped-table` class style to table.
2019-07-09 13:07:35 -07:00
fa5d6bb2d6
org settings: Display deactivated-user section to all.
...
Fixes #12290
2019-07-09 13:07:35 -07:00
6fddc86cf2
org settings: Remove strikethrough from deactivated-user setting.
...
Remove strickethrough and append text to user role.
2019-07-09 13:07:35 -07:00
1880075f81
static/js/settings_users: Remove unnecessary function from page load.
2019-07-09 13:07:35 -07:00
5a3f1e20ec
static/js/settings_users: Replace logic with existing function.
2019-07-09 13:07:35 -07:00
205657b3cf
api: Remove spammy json_success content for edit_user_group.
...
These values were unnecessary translated strings not displayed
anywhere, and were not consistent with Zulip's API standards.
2019-07-09 13:04:47 -07:00
3c464d9d63
emails: Show realm_str inside bracket in subject.
2019-07-09 11:59:39 -07:00
d23bcfa948
emails: Mention why user is getting stream message notification.
2019-07-09 11:59:38 -07:00
c4d28777ec
emails: Include stream topic details in missed message subject.
2019-07-09 11:51:20 -07:00
f9d9eca295
css: Nest `.colorpicker-container` inside `.streams_popover`.
2019-07-09 11:43:04 -07:00
d68fcfdb88
css: Nest `sp-container` in `.colorpicker-container` for `.streams_popover`.
2019-07-09 11:43:04 -07:00
84489a8d80
css: Nest `.sp-palette-container` in `.sp-container` for `.streams_popover`.
2019-07-09 11:43:04 -07:00
a7b143bda7
css: Use SCSS nesting in popovers.scss for `.group-info`.
2019-07-09 11:43:04 -07:00
d371d7438e
css: Separate `.group-info` rule from `.message-group a`.
2019-07-09 11:43:04 -07:00
1bf2b23d36
css: Use SCSS nesting in popovers.scss for `.group-info-popover`.
2019-07-09 11:43:04 -07:00
d9142dd03c
css: Move `.popover_user_presence` rules inside one block.
2019-07-09 11:43:04 -07:00
a1951c087a
css: Cleanup margin using only one rule instead of 4 different margins.
2019-07-09 11:43:04 -07:00
596420d80b
css: Remove redundant `.group-info-popover .member-list .user_circle` rule.
...
User circle inside `.group-info-popover` already has the class-name
`.popover_user_presence` which has the same properties.
2019-07-09 11:43:04 -07:00
e0a18d3394
blueslip: Replace jQuery wrappers with error event listener.
...
Not all our errors actually happen in the contexts we were
wrapping (e.g. `setTimeout` and `_.throttle`). Also this fixes the
neat Firefox inspector feature that shows you where your event
handlers for a given DOM element actually live.
Using this "semi-modern" browser event means that Safari 9 and older
and IE10 and older may not have our browser error reporting active;
that seems fine giving the vanishing market share of those browsers.
https://blog.sentry.io/2016/01/04/client-javascript-reporting-window-onerror
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:38:20 -07:00
0c80fc6aba
hashchange: Use hashchange event listener.
...
The comment that jQuery “doesn’t have” this was nonsense: jQuery
supports every event the browser does.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:35 -07:00
6a50460749
templates: Fix path to settings/dev_env_email_access.
...
This was broken in our migration to a nicer path system for our
handlebars templates.
2019-07-09 11:31:18 -07:00
ebb9a9ea9e
templates: Fix wrong path to edit-outgoing-webhook-service template.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 11:31:16 -07:00
723504f3b6
blueslip: Remove console polyfill.
...
This appears to have been a workaround for an old version of IE on an
unusual platform.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-08 21:47:04 -07:00
363956428a
lightbox.js: Remove computed access of exports.
...
This wouldn’t work after migration to an ES6 module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
9368c33098
unread.js: Add setter for suppress_unread_counts.
...
After migration to an ES6 module, `suppress_unread_counts` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
e24ec31823
unread.js: Add setter for messages_read_in_narrow.
...
After migration to an ES6 module, `messages_read_in_narrow` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
8472292906
pointer.js: Add setter for suppress_scroll_pointer_update.
...
After migration to an ES6 module, `suppress_scroll_pointer_update`
would no longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
f9bf414b58
pointer.js: Add setter for server_furthest_read.
...
After migration to an ES6 module, `server_furthest_read` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
e559662c8c
pointer.js: Add setter for recenter_pointer_on_display.
...
After migration to an ES6 module, `recenter_pointer_on_display` would
no longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
055ebe76aa
pointer.js: Add setter for furthest_read.
...
After migration to an ES6 module, `furthest_read` would no longer be
mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
6e4ae95994
message_viewport.js: Add setter for last_movement_direction.
...
After migration to an ES6 module, `last_movement_direction` would no
longer be mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
15192d4417
message_list.js: Add setter for narrowed.
...
After migration to an ES6 module, `narrowed` would no longer be
mutable from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
190524b6a0
alert_words.js: Add setter for words.
...
After migration to an ES6 module, `words` would no longer be mutable
from outside the module.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-07-08 21:22:54 -07:00
dfdbc378b0
css: Move `.user_popover .popover-title` rules inside one block.
2019-07-08 20:13:08 -07:00
b205410e27
css: Use SCSS nesting in popovers.scss for `.user_popover`.
2019-07-08 20:13:08 -07:00
58c0434474
css: Use SCSS nesting in popovers.scss for `.popover-avatar`.
2019-07-08 20:13:08 -07:00
Yashashvi Dave
Rishi Gupta
Anders Kaseorg
Hemanth V. Alluri
Tim Abbott
Vishnu Ks
vinitS101
sameerchoubey
Vaibhav
Anders Kaseorg