When hover over a typeahead menu item, the semantics have always been
to make it active, and now we also respect the naturalSearch option
there, which will set the text of the search box to the suggestion
immediately upon hover.
(imported from commit 02318d3d830e7e28d638efee0ef27023a73f52f7)
See https://github.com/twitter/bootstrap/issues/7392. I seem to
have fixed it with just the CSS part of their suggested patch.
To repro the bug prior to this fix, enter search, hover over a
typeahead, and then hit the up arrow key. You'll see two items
appear to be selected.
(imported from commit 383d60a606d7c19344a326208312a1555d060877)
This commit broke unread dots, since they're in the .messagebox
but absolutely positioned outside of it (so they got clipped.)
This reverts commit e0071851d2dc7d99c9acd93a1fc6fa1ce0c3b70e.
(imported from commit b3181b3a02cef905cc8f400f8c1cc3c92b5f0e15)
The total duration of this animation is the exact same, but
it starts immediately - let's see if this feels any better.
(imported from commit de86c259a25adb64514613579476480bdac29cb2)
There was some misguided code that eliminated the suggestion when
the user typed out the full topic, and since then there is more
generalized protection against duplicate suggestions.
(imported from commit 857e74458d10995170d312b77d99d839706ae680)
I'd encourage you all to review this diff thoroughly, since I am not
very familiar with this code. However, it seems to me that, prior to
this commit, if respond_to_cursor is true and page_params.staging is
true, compose.start gets called twice! (once by `respond_to_message`
and once by the "if (page_params.staging)" under the else, after it
returns.)
I eliminate the second call by sticking it inside the first else; now,
as far as I can tell, we call compose.start once and only once.
(imported from commit 319f51392541def358a138c104dd21722b4f8ba8)
Just before this is pushed to prod, we need to rename the Humbug feedback
bot in the database using:
./manage.py change_user_email feedback@humbughq.comfeedback@zulip.com
/etc/init.d/memcached restart
and we also need to update and restart feedback-bot in its deployed
location.
No action is required on pushing this to staging, but in between when
this is pushed to staging and when it is pushed to prod (and that
transition performed), feedback will not work on staging.
(imported from commit 73fc36f680b978f3aebae5df1822918ae4d4e952)
Just before this is pushed to prod, we need to rename the Humbug
notification bot in the database using:
./manage.py change_user_email humbug+notifications@humbughq.comnotification-bot@zulip.com
/etc/init.d/memcached restart
No action is required on pushing this to staging, but in between when
this is pushed to staging and when it is pushed to prod (and that
transition performed), notifying users that they were subscribed to a
new stream will not work on staging.
(imported from commit a0555527dec7b210022b09d9b1d13a7c910a8f9f)
Just before this is pushed to prod, we need to rename the Humbug new
user bot in the database using:
./manage.py change_user_email humbug+signups@humbughq.comnew-user-bot@zulip.com
/etc/init.d/memcached restart
No action is required on pushing this to staging, but in between when
this is pushed to staging and when it is pushed to prod (and that
transition performed), signup reporting to humbug will not work on
staging.
(imported from commit af2cd007b41ea885491f383442f211e8609fe5f9)
Just before this is pushed to prod, we need to rename the Humbug error
bot in the database using:
./manage.py change_user_email humbug+errors@humbughq.comerror-bot@zulip.com
/etc/init.d/memcached restart
No action is required on pushing this to staging, but in between when
this is pushed to staging and when it is pushed to prod (and that
transition performed), error reporting to humbug will not work on
staging.
(imported from commit 93044bb01797c981067f359676826d4a5791e235)
When we push this to staging, we'll need to rename the bot in the
database and also pull on git.zulip.net.
(imported from commit 22b2397b197c8820f0e55daecd8f98d829e195bd)
The rename of humbughq.com to zulip.com had the side effect of making
users often not subscribed to stream Verona, which didn't work well
with our test suite.
(imported from commit 28ebd5b444a026e753935ae99b3baa203bb0f222)
Before we'd autocomplete d to [stream:design, stream:devel].
Now we also autocomplete stream:d to [stream:design, stream:devel].
(imported from commit d7ecbd032a3414828bf649698d741f0d6a6e3af2)
This helps mitigate the damage caused by hilarious vertical
names like "Puerco (((((())))))" with the vertical parentheses.
(imported from commit e0071851d2dc7d99c9acd93a1fc6fa1ce0c3b70e)
I often click "reply" and clear out the text to reply to these, and
it's sort of a pain to have to change the address.
(imported from commit ed8aae858bbd1821623cf640956ffccbacfaa1af)
Created up, down, page_up, page_down, to_home, and to_home pretty
mechanically from the old hotkey.code.
(imported from commit 5956b91c2e0122c6440f70db9b92f918c9b599aa)
Because there's no guarantee that Hamlet has message IDs 1 and 2, and
the update_unread_counts function didn't return an error in the event
that you passed it a message that the user never received (it instead
silently succeeded), this test was mostly useless.
I just dumped the test_initial_counts function, because it didn't seem
to be doing anything useful.
(imported from commit 4d76104eb9f3b947727a1a030afc0b57054d0daf)
That commit intended to fix a bug where it jumps to the wrong scroll position
(offset by the difference in height from uncollapsed to collapsed) if you load
collapsed messages at the top, either by scrolling up or when it automatically
fetches more 10s after page load, because before, it updated the scroll
position before processing collapsing, which changes the height of messages.
Updating collapsing needs to happen before the viewport is adjusted, but also
needs to happen after the new messages get appended/prepended to the document
because they need to be attached to the document for getClientBoundingRect to
work.
(imported from commit 44d6a6135524e658084ffcf7d880ba898b577e6d)
We already have one for faded messages (which this commit simplifies),
but we also need one on unfaded messages to facilitate styling
experiments.
(imported from commit 41a6e2ef136ce73ce8c24de1e35199244ce56d37)
Trac #1540
* Make edit content box the same width as normal content
* Scroll to compensate for the added padding and "Topic" field.
* Restore the scroll position when exiting edit
It's off by 1px on Firefox 22, but Firefox is simply wrong.
(imported from commit 49154f51b538c648934a41a4a7a217198186ede2)
The code now unminifies all calls in the stack, including those outside
of app.js.
This requires the Python package sourcemap, recently added as a
dependency.
(imported from commit 550c73ad5bfe78a2c7169c11da0c95cbaac238d7)
This will allow you to always get Home from the search box,
as well as easily backing out narrows.
(imported from commit 68bcfc83ce0428645f4e734ae46f9589cb562a86)
Until now, we would reset the search string when you aborted
a search, but only if you are in the home view. Now, we reset
it always. This makes the search box an accurate reflection of
your narrow.
(imported from commit bed6adce54a55648165c84118d430c44abb5949f)
The naturalSearch option immediately updates the search box with
the underlying value of a search suggestion when the user moves to
it.
(imported from commit ad5cb5c2591ef4f71a6d648c8839f288cc125cf7)
If you are narrowed to "Private messages", we show you suggestions
of people. If you are narrows to pm-with, we show you a suggestion
to get back to is:private.
(imported from commit 18405beb1e194514618365d9f913972121c64d12)
(They will show up for empty queries or queries that are prefixes
of either the operator syntax or the label used in the sidebar.)
(imported from commit 3765896e3bc1fc95caf987194e22d89d649ba5ae)
We cap the number of overall suggestions at 50, but we don't
limit within category, since any limit is arbitrary and can
confuse users.
(imported from commit 3b18e9ad4b89e5a5485a058a2c0cd5fcca61ed35)
It allows us to provide suggestions when the user types '' in
a searchbox (e.g. by hitting delete when text is selected).
(imported from commit dc27ef86db2b6ec40039e4e9668b8ccc288c6134)
This is a heavily adapted version of Allen's commit that did the
same.
Some gotchas:
* Because the unread count indicator is not in the message content,
we can't center it in the middle of the message content (we'd
need to put it inside the div to do so).
* Awesome Gecko bug surrounding tables makes this also somewhat
annoying, so watch out for this if you're making changes here.
> In Gecko, if you have a positioned <table> element inside a
> positioned block element, such as a <div>, a position: absolute;
> styled element inside the table would be positioned relative to the
> outer <div> rather than the table, which is the nearest positioned
> ancestor. This is a bug, and has not been fixed.
(imported from commit 45c00c37f3721c211331b228e84d46283e1cc9ba)
We already had provisions for the common case, but this code fixes
the situation where the user explicitly types topic:foo stream:yo.
(imported from commit 4dfa4cc8337acd4f0daed25a5b82a556804b3c18)
Before this fix, if you used the "Narrow to stream foo bar" suggestion,
it would search for "bar" within stream foo. Now it goes to the "foo bar"
stream.
(imported from commit 0be5f259842c119936d678a292a1a79af58defa2)
If you have smartSpaceBar turned on and hit space, the code
now calls lookup(), so that the app code can reload new
suggestions.
(imported from commit 6776babba0a2c9b8a954a4640aa7b81a970ed88e)
Steve Howell
Waseem Daher
Zev Benjamin
Waseem Daher
Tim Abbott
Kevin Mehall
Jessica McKellar
Scott Feeney
Jeff Arnold
Leo Franchi