Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
53,877 Commits 28 Branches 143 Tags 614 MiB
Commit Graph

53877 Commits

Author SHA1 Message Date
Anders Kaseorg 0fd4e309d5 eslint: Enable import/no-cycle rule. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-10 12:09:15 -07:00
Anders Kaseorg 881da05cd3 stream_settings_ui: Extract stream_settings_components module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-10 12:09:15 -07:00
Aman Agrawal 22f4ecdad6 message_fetch: Don't use MessageList to fetch data for recent view. 
Since load_messages now supports fetching data with only
MessageListData, we can just use it and avoid calling
MessageListView which also caused our polls and TODO widgets to
not render occasionally.
 2023-10-10 11:11:19 -07:00
Aman Agrawal 69e10b4dae message_fetch: Handle MessageListData directly passed to load_messages. 
This will allow us to use load_messages to fetch data using it
without initializing a MessageList.
 2023-10-10 11:11:19 -07:00
Karl Stolley 88f4ecc943 compose_banner: Restore CSS overzealously removed in #27097. 
This also includes a comment for future contributors, explaining
why these styles are necessary.
 2023-10-10 10:01:11 -07:00
Anders Kaseorg 521cb15a07 stream_ui_updates: Cut import of stream_settings_ui. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-10 09:08:53 -07:00
Anders Kaseorg b9bb0d5aa8 settings_org: Cut import of settings_realm_user_settings_defaults. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-10 09:06:28 -07:00
Anders Kaseorg 1d43a4cccb stream_edit: Extract toggler to new stream_edit_toggler module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 23:19:59 -07:00
Anders Kaseorg 3cac29a8e1 settings_org: Extract settings_components module. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 17:26:49 -07:00
Aman Agrawal 9ab1a726a0 inbox: Add page up/down support similar to recent topics. 
Leaving page up / down to browser doesn't work very well due to
our custom header, filters and compose.
 2023-10-09 16:36:24 -07:00
Aman Agrawal 9fc6af220e inbox: Handle latest message not fetched when replying. 
Since inbox is populated based on unread data which is part
of /register request, it is possible that we don't have the
actual message in our message_store. In that case, we return
a fake message object.
 2023-10-09 16:36:24 -07:00
Aman Agrawal 2c4156e239 compose_reply: Remove unnecessary pm_recipient being set. 
`pm_recipient` is already set in `else` case unconditionally,
so setting it early is not required.
 2023-10-09 16:36:24 -07:00
Aman Agrawal bb740ca65e inbox: Fill compose with dm/stream info for `reply` on inbox-header. 2023-10-09 16:36:24 -07:00
Aman Agrawal 2561e7f2d8 inbox: Set compose recipient according to focused row on `reply`. 
Fill compose recipient based on the latest message of the focused
row.
 2023-10-09 16:36:24 -07:00
Aman Agrawal 50a356389c inbox: Update closed compose text based on focused element. 
For header rows, search and filters we just show default text.
 2023-10-09 16:36:24 -07:00
Aman Agrawal 3ac6f447d9 inbox_ui: Change current_focus_id when clicking on inbox search. 2023-10-09 16:36:24 -07:00
Aman Agrawal 64cc24722f inbox_ui: Rename function to reflect it only works for focus in list. 2023-10-09 16:36:24 -07:00
Aman Agrawal 3cbd772b8d inbox: Make focus outline around unread count wider. 2023-10-09 16:36:24 -07:00
Aman Agrawal 80a7e995af inbox: Fix spelling mistakes. 
Found a good spell checker, hopefully no more of those.
 2023-10-09 16:36:24 -07:00
Aman Agrawal e9c86dc524 inbox: Add topic visibility indicator. 2023-10-09 16:36:24 -07:00
Aman Agrawal 8c619d6938 inbox: Rename variable for readability. 2023-10-09 16:36:24 -07:00
Aman Agrawal 49f553ebfc inbox: Add rectangle focus border around inbox header name. 2023-10-09 16:36:24 -07:00
Anders Kaseorg 50928314f2 settings_users: Remove get_status_field. 
It’s effectively unused since commit
2d5c678614 (#25061), as predicted by
commit d45f0171cb (#14919).

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 16:05:31 -07:00
Anders Kaseorg 95b9d6f7e2 settings: Move set_settings_header to settings_panel_menu. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 16:04:30 -07:00
Aman Agrawal 9abc2cb3fd signup: Add link to redirect user to login page in the form. 2023-10-09 14:36:54 -07:00
Anders Kaseorg cc07b8c79c install-node: Upgrade Node.js from 18.17.1 to 18.18.0. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 14:16:23 -07:00
Anders Kaseorg 8f564749bb dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 14:16:23 -07:00
Anders Kaseorg 835ee69c80 docs: Fix grammar errors found by mwic. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 13:24:09 -07:00
Anders Kaseorg 7807bff526 requirements: Upgrade Python requirements. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:55:16 -07:00
Anders Kaseorg f338c3af07 rate_limiter: Fix PIE790 Unnecessary `pass` statement. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:55:16 -07:00
Anders Kaseorg 4cb2eded68 typos: Fix typos caught by typos. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:55:16 -07:00
Anders Kaseorg 7b4a74cc4d codespell: Fix typos caught by codespell. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:55:15 -07:00
Karl Stolley eea59e2edc compose_banners: Hide upload progress banner on error. 2023-10-09 11:55:01 -07:00
Karl Stolley d887fb57e7 compose_banners: Better align action and cancel buttons. 
This uses the banner message's line-height to set a
max-height on the action and cancel buttons to maintain
a consistent vertical spacing.

Additional uses of flexbox here:

1. help the button to remain shorter when it's adjacent a
   single-line banner message, and
2. center the closing X icon relative to the current size
   of the action button, when one is present
 2023-10-09 11:55:01 -07:00
Karl Stolley fe8fc98912 compose_banners: Structure innner <p> elements with .banner_message class. 
This also styles those inner .banner_message elements to lose
margin inherited from Bootstrap. (This is now also applied to
the upload-message banner.)

It's better to achieve that with a class selector; using a `p`
element selector would mean that such a style would be evaluated
for all `<p>` elements in the DOM. Which is of course a whole lot,
thanks to Markdown alone.

Fixes: #26922
 2023-10-09 11:55:01 -07:00
Karl Stolley 1581c6f847 compose_banners: Add .banner_content to elements that need it. 2023-10-09 11:55:01 -07:00
Karl Stolley 3fdf85872e compose_banners: Remove unnecessary upload-message styles. 2023-10-09 11:55:01 -07:00
Tim Abbott 756b465b47 bootstrap: Remove last vestiges of bootstrap-tooltip library. 
Everything but this sliver of CSS has been deleted previously as part
of our migration off Bootstrap.
 2023-10-09 11:39:12 -07:00
Aman Agrawal c69fe4b6a0 popover: Remove `.popover` class. 
Since we are not using bootstrap popover, we don't have popovers
with that class.
 2023-10-09 11:39:12 -07:00
Aman Agrawal 8430674aee popovers: Remove unused popover-content class. 
Fixes #26821
 2023-10-09 11:39:12 -07:00
Aman Agrawal a04117b6d3 user_group_info_popover: Remove bootstrap popover classes. 
Added a `group-info-content` inplace of them and added the required
CSS.
 2023-10-09 11:39:12 -07:00
Aman Agrawal 04c4b6e8b8 giphy: Move `popover-content` styles to `giphy-scrolling-container`. 2023-10-09 11:39:12 -07:00
Aman Agrawal 094ac010fb user_card_popover: Remove popover content class. 
Added CSS styles that were removed due to this back. No visual
changes.
 2023-10-09 11:39:12 -07:00
Aman Agrawal ce656da8d7 emoji_popover: Remove popover-content div. 
`popover-content` class had no effect on emoji popover since
it was resetting `padding: 0` and background color was
already applied by tippy theme.

In short, removing `popover-content` had no visual changes.
 2023-10-09 11:39:12 -07:00
Aman Agrawal 5cd2b0ed86 giphy: Remove old comment. 
Destroying popover_instance is now part of how tippy popovers work.
 2023-10-09 11:39:12 -07:00
Aman Agrawal 0976b9006e popover-title: Remove class. 
Remove bootstrap-tooltip class `popover-title` from code.

It was only used in user_card_popover for showing user avatar,
so cleaned up properties that were duplicated or not required.
 2023-10-09 11:39:12 -07:00
Anders Kaseorg b9fe1947f8 navigate: Move scroll_to_selected to message_viewport. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:32:16 -07:00
Anders Kaseorg 18bdfde9e7 recent_view_ui: Cut import of unread_ops. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:32:16 -07:00
Anders Kaseorg 95785739ac navbar_alerts: Move resize_app to resize. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-09 11:32:16 -07:00
Sahil Batra 7ffdeecd86 styles: Remove CSS for ".modal-header". 
We do not use "modal-header" on any elements now, so
we can remove the redundant CSS rules defined for it.
 2023-10-09 11:25:26 -07:00