07dcf66c72
navbar: Remove stale focus-dropdown code.
...
We don't need this since we migrated the dropdown to tippy which
handles the navigation via popover_items_handle_keyboard.
2023-10-23 14:15:13 -07:00
75c874fef6
personal_menu: Fix focus outline of clear status icon.
2023-10-23 14:15:13 -07:00
87c87ed41f
personal_menu: Rename clear_status class.
2023-10-23 14:15:13 -07:00
79acefae4c
css: Remove unused hotkey-hint style.
...
The one we use in tooltips is defined in tooltips.css.
2023-10-23 14:15:13 -07:00
c5564668c5
help_menu: Use new style to show hotkey.
...
This is according to Vlad's design in figma which differs from the
style we have in `tooltip-hotkey-hint`.
I used font-weight: 500 instead of 400 as it looked nicer and since
Vlad used Source Sans Pro as font-family which we don't have.
2023-10-23 14:15:13 -07:00
3d870a1f7d
popovers: Use fixed height for navbar-dropdown items.
...
This helps us add elements like hotkey hint which can take more
space that available for text. There are no visual changes.
Removed some duplicate properties too.
2023-10-23 14:15:13 -07:00
8f716cd64a
help_menu: Extract help items from gear menu into a separate popover.
...
Fixes #27202
2023-10-23 14:15:13 -07:00
2b9dc1f398
hotkey: Avoid inconsistent hotkey handling.
...
Pressing `r` to open compose box, or search via hotkey didn't work
for gear menu while it worked for other popovers. So, this is an
attempt to unify that behavior so that if the hotkeys are not
handles the navbar_menus popovers, then can be handled elsewhere.
2023-10-23 14:15:13 -07:00
a210006ecd
popovers: Hide when starting certain actions.
...
These are actions which can be called when a popover is open and
it is better to close the popover when these actions are
initiated.
2023-10-23 14:15:13 -07:00
c9891b4121
hotkey: Make g + left / right arrow work to open navbar dropdowns.
...
While gear menu is open, press right arrow to go to personal menu
and left arrow to open gear menu again.
2023-10-23 14:15:13 -07:00
15c3abe03c
emails: Suggest resetting password if having trouble logging in.
...
Tweaked by tabbott to not include the URL in the translation tags.
2023-10-23 09:58:23 -07:00
23d34ca457
ts: Migrate `poll_widget.js` to TypeScript.
...
Added type annotations.
2023-10-23 09:33:47 -07:00
6840715222
poll_data: Define outbound data types for each message type.
...
This commit introduces specific outbound data types for each
message type for reusability. For example, `poll_widget.ts` reuses
these types.
2023-10-23 09:33:47 -07:00
721fbb1bed
keydown_util: Extend event type for `is_enter_event` function.
...
To accommodate both keydown and keyup events, this commit updates
the function signature to accept both `JQuery.KeyDownEvent` and
`JQuery.KeyUpEvent` types. An example of using keyup event is in
`poll_widget.ts`.
2023-10-23 09:33:47 -07:00
789d052116
poll_widget: Use `.prop()` but not `.attr()` for button disabled state.
...
This commit sets the "disabled" property of buttons using `.prop()`
method instead of `.attr()`. The `.prop()` method satisfies type
check requirements for boolean properties like "disabled", while
`.attr()` method requires string type property.
2023-10-23 09:33:47 -07:00
d2faae36c6
openapi: Remove fix_events.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-23 09:07:07 -07:00
ce0040b69f
openapi: Add missing user property to deprecated user settings events.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-23 09:07:07 -07:00
f256a5a536
openapi: Separate EmojiReactionEvent from EmojiReaction.
...
EmojiReactionEvent has user.user_id while EmojiReaction has user.id.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-23 09:07:07 -07:00
b1f6ff20ef
attachments: Correct attachment_id type from string to integer.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-22 17:06:34 -07:00
82f105aada
popovers: Fix bug where modals persisted on hashchange.
...
Modals like those for Read receipts, Schedule message, Message edit
history, User profile, etc would not close when the hash changed.
Now we close any active modal whenever the hash changes; we add a new
function in `modals.ts` to do this, and call it from `hashchange.js`.
2023-10-22 14:56:06 -07:00
3f2ab44f94
follow_topics: Remove the 'development' guard.
...
This commit removes the 'development' guard and makes
the UI changes related to the 'Follow Topics' project visible
outside the development environment.
Cleans up the older UI elements related to mute and unmute topics.
2023-10-22 14:24:22 -07:00
5dba15160d
css: Fix dark theme hover color for copy invite link.
...
Extracted colors into variables and used them inside the id to
solve the specificity issue.
2023-10-22 14:21:16 -07:00
18475a10d7
copy_invite_link: Append tooltip to body.
...
This helps us get the desired `placement: top` for the tooltip
which is also where to copied confirmation tooltip is displayed.
2023-10-22 14:21:16 -07:00
96e3ad9311
invite: Add copied confirmation tooltip on invite link.
...
Fixes #26872
2023-10-22 14:21:16 -07:00
09ab0f3c18
bootstrap: Remove bootstrap-dropdown library.
...
Gear menu was the last piece of dropdowns which used this. Since
we migrated it to tippy, we don't need this library.
2023-10-21 10:54:32 -07:00
e4ae826a47
inbox: Improve look of empty inbox view.
2023-10-20 17:13:33 -07:00
1839eb0239
help: Expand guide on trying out Zulip.
2023-10-20 16:40:13 -07:00
e957decd12
email: Drop support for SEND_MISSED_MESSAGE_EMAILS_AS_USER. ( #27223 )
...
Originally, this was how the notification emails worked, but that was changed
in 797a7ef97bFixes #26609 .
2023-10-20 16:38:43 -07:00
af271be1bd
navbar-dropdowns: Use specific classes for everything.
...
Replaced element selectors with specific selectors, those that
remain are intentionally left.
This is to avoid inner-most selectors as element selectors.
The reason being is that browsers evaluate selectors from right
to left, meaning that every time a selector ends in an element,
the browser has to work that much harder whenever and wherever
on a page it encounters the element.
2023-10-20 12:36:39 -07:00
2efc2a5eb5
gear_menu_dropdown: Use better class name for theme buttons.
2023-10-20 12:36:39 -07:00
51797809c4
header-button: Add background effects to different states.
2023-10-20 12:36:39 -07:00
f9e7b814d6
navbar-dropdown-menu: Use focus-visible instead of focus.
2023-10-20 12:36:39 -07:00
961693c354
gear_menu: Extract common hidden-for-spectators.
...
This avoids double borders in spectator view.
2023-10-20 12:36:39 -07:00
05a640300a
gear_menu_popover: Remove presentation role.
...
We want to remove their semantics from accessibility tree.
2023-10-20 12:36:39 -07:00
64ff483e27
gear_menu_popover: Use semantically correct HTML structure.
...
Using `ul > li > ul > li` here since that's the correct structure.
2023-10-20 12:36:39 -07:00
1e3e70576b
gear_menu: Extract the new gear and personal menu style as a theme.
...
This also fixes some misalignment happening at some widths for gear
menu. Like at XL widths for spectators.
2023-10-20 12:36:39 -07:00
67ba59f6e8
dropdown_list: Remove not useful role=menuitem.
...
Since the parent `ul` has doesn't have role=menu and `ul/li` elements
don't need a be specified a role anyway. We don't need it.
2023-10-20 12:36:39 -07:00
ffcf792cc9
gear_menu: Use navigate-link-on-enter class instead of role=menuitem.
...
The class name make more sense give what it does.
2023-10-20 12:36:39 -07:00
246c1d7b4e
hotkey: Call click() on elements with menuitem role in popovers.
2023-10-20 12:36:39 -07:00
7932d49956
gear_menu_popover: Allow user to focus on these items.
...
These don't have an href attribute to use tabindex to
enable focus.
2023-10-20 12:36:39 -07:00
bc3d48616e
gear_menu: Migrate to use tippy.
2023-10-20 12:36:39 -07:00
1e93540d3b
navbar: Use new icon for user list toggle.
...
This needs to be done along with gear menu for navbar to look nice.
2023-10-20 12:36:39 -07:00
a7f328d593
gear_menu_popover: Remove small-font-size class.
...
We can apply the required CSS to directly the org types.
2023-10-20 12:36:39 -07:00
5cbf8ad91a
gear_menu_popover: Format "About Zulip" item like other items.
2023-10-20 12:36:39 -07:00
d75df10729
gear_menu_popover: Move *-theme class to the li element.
...
It will help us hide the whole `li` element instead of just
`a` tag for spectators.
2023-10-20 12:36:39 -07:00
897c19d17d
css: Add box-shadow to navbar dropdown menu as per figma design.
2023-10-20 12:36:39 -07:00
41c06e2989
CSS: Extract common CSS for .navbar-dropdown-menu.
2023-10-20 12:36:39 -07:00
e95b105566
gear_menu_popver: Use link-item class for li elements.
2023-10-20 12:36:39 -07:00
cac411abc9
gear_menu_popover: Use better class and id name for gear-menu.
2023-10-20 12:36:39 -07:00
12ea256e47
gear_menu: Extract dropdown part of gear menu.
2023-10-20 12:36:39 -07:00
Aman Agrawal
Alya Abbott
Junyao Chen
Anders Kaseorg
N-Shar-ma
Prakhar Pratyush
tamara
Esther Anierobi