Steve Howell
02a011d627
Add people.report_late_add().
...
We want to know when users are added after page load, as it can
be a symptom of stray messages leaking in or live-update problems,
etc.
Fixes #7120
2017-11-07 09:51:10 -08:00
Steve Howell
aebfdaa8ed
refactor: Use early-return in extract_people_from_message().
2017-11-07 09:51:10 -08:00
Steve Howell
294a1fb8f8
refactor: Extract people.maybe_incr_recipient_count().
...
This logic used to be in extract_people_from_message(), but
we are deprecating extract_people_from_message(), whereas
the maybe_incr_recipient_count() function has logic that we
want to keep.
2017-11-07 09:51:10 -08:00
Steve Howell
c291c74e45
minor: Make comment more accurate in popover error condition.
2017-11-07 09:51:10 -08:00
Steve Howell
5271241b24
Read page_params.realm_non_active_users() at page load.
...
This change is the first step in making it so that we load
non-active users at page load time in the webapp.
Before this change, we would reactively handle deactivated
users when we saw them as senders in messages. Subsequent
changes will make it a warning if we see unknown senders
in messages.
2017-11-07 09:51:10 -08:00
Steve Howell
b492f3569a
tests: Extract node_tests/people_errors.js.
...
This is mostly a pure extraction, but we needed to duplicate
a bit of setup from people.js, and I added an assertion
for warning about "No user_id provided".
2017-11-07 09:51:10 -08:00
Steve Howell
48b18e4a38
Only show active realm users in compose typeahead.
...
There's no reason to include deactivated users in compose
typeahead, since we won't let the compose happen.
This also removes cross-realm bots from the typeahead, which
is mostly driven by not having a convenient function to include
them, but also it's rare that it makes sense to talk to a cross-realm
bot unless replying to it.
2017-11-07 09:51:10 -08:00
derAnfaenger
a61a127ca5
integrations: Update twitter bot commands.
...
This removes redundant arguments for specifying
the zulip server address (it's already contained
in the zuliprc).
2017-11-07 09:44:24 -08:00
derAnfaenger
c8e87a322d
queue processors: Exclude TestWorker from coverage.
2017-11-07 09:38:58 -08:00
derAnfaenger
0709033858
bugdown: Fetch complete data for tweet.
...
This makes an extended instead of a normal query,
resulting in the full text of a tweet being fetched
instead of just a truncated version.
2017-11-07 09:13:39 -08:00
Vishnu Ks
c5ff020246
droplets: Garbage collect A records before creating droplet.
2017-11-06 12:20:39 -08:00
Rishi Gupta
dec4b9ed93
remote dev: Add code and instructions for creating digital ocean droplets.
...
Mostly copied from the zulip/zulip-gci repository, but with some changes to
wordings and code cleanup for linters.
2017-11-06 12:20:39 -08:00
Rishi Gupta
b31af80c5f
requirements: Update comments output by update-locked-requirements.
...
I just ran tools/update-locked-requirements and commited the changes.
2017-11-06 12:20:39 -08:00
rht
e3eebf3be0
Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
8990b1046d
zerver: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
2ceb0b45b3
zerver/tornado: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
c7fa1d4146
zerver/tests: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
864e16f30d
zerver/migrations: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
e311842a1b
zerver/lib: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
0e71b243ce
zilencer: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
e33c8d91e0
zproject: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
rht
5cfffb0e51
analytics: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
Cynthia Lin
7a6e0dda41
static: Optimize SVG images.
2017-11-04 20:57:19 -07:00
Cynthia Lin
d94a84e77f
static: Remove unused images.
2017-11-04 20:57:19 -07:00
neiljp (Neil Pilgrim)
42f5eea61f
mypy: Improve typing of request.pyi (REQ).
...
This expands request.pyi to type-check the arguments passed into REQ.
Tweaked by tabbott to fix the report.py annotations.
2017-11-04 20:26:03 -07:00
rht
dd1920c811
confirmation: Use python 3 syntax for typing.
2017-11-04 19:59:41 -07:00
rht
ada9979f51
docs: Use python 3 syntax for typing.
2017-11-04 19:58:05 -07:00
rht
26b6b893e6
zproject: Use python 3 syntax for typing.
2017-11-04 19:58:03 -07:00
rht
77f32a1e0c
frontend_tests: Use python 3 syntax for typing.
2017-11-04 19:57:55 -07:00
neiljp (Neil Pilgrim)
0d31cb568c
mypy: Broaden some types from Dict to Any based on context.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
055dff9038
mypy: Clarify parameter types in test_decorators.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
6e6b1ce0d5
mypy: Explicitly inherit test_[sequence|mapping] test classes from generic types.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
3fd720d8f4
mypy: Broadly specify lambda type parameters in test_events.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
aae8a03415
mypy: Explicitly specify Dict[str, Any] as DummyForm base type.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
2a2870eec8
mypy: Fully specify type of Callable parameter to process_instrumented_calls.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
b0e9fd7fa0
mypy: Specify type of decorator correctly in test_logging_handlers.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
f3b5b9db78
mypy: Specify Callable parameters in FakeClient functions in WorkerTest.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
6f490394c3
mypy: Set explicit Any-like parameters for StatsMock functions.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
692e2150c6
mypy: Explicitly specify List[Any] in test_classes.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
792a580efb
mypy: Specify Callable type parameters in test_helpers.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
952f034136
mypy: Set explicit Any-like parameters for handle_callback_exception in runtornado.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
186181c2a0
mypy: Specify type parameters in convert_term in narrow_parameter.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
da97de3370
mypy: Use Dict[Any,Any] for update_realm parameter.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
720df640e7
mypy: Set freshdesk TicketDict to inherit from typed Dict.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
6c995db231
mypy: Use Iterator[Any] as return type of queryset_iterator.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
1197ff9655
mypy: Explicitly return Set[Any] for empty set in backends.py.
2017-11-04 19:47:45 -07:00
neiljp (Neil Pilgrim)
54cbb808e6
mypy: Add explicit Any parameters to get_user_events return type.
2017-11-04 19:47:44 -07:00
neiljp (Neil Pilgrim)
fed757452c
mypy: Clarify type of lookup_dict in aggregate_message_dict.
2017-11-04 19:47:44 -07:00
neiljp (Neil Pilgrim)
b693f32c0b
mypy: Add Dict parameters for dropbox_image return type.
...
Also a note re using TypedDict in future, as the Dict looks constrained.
2017-11-04 19:47:44 -07:00
neiljp (Neil Pilgrim)
737408f741
mypy: Add explicit flexible type parameters for Callable in run-dev.py.
2017-11-04 19:47:44 -07:00