Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

portico: Remove scroll-to attribute support. 

This feature was added in 3b55519b11
without any uses of it in the markup, and we do not appear to use
scroll-to anywhere in our portico pages.
This commit is contained in:
Rohitt Vashishtha 2019-07-11 00:47:49 +05:30 committed by Tim Abbott
parent d649dce468
commit f507a1a1d9
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
static/js/portico/landing-page.js
View File

@ -6,24 +6,6 @@ const ELECTRON_APP_URL_WINDOWS = "https://github.com/zulip/zulip-desktop/release
import render_tabs from './team.js';
import {detect_user_os} from './tabbed-instructions.js';
// this will either smooth scroll to an anchor where the `name`
// is the same as the `scroll-to` reference, or to a px height
// (as specified like `scroll-to='0px'`).
var ScrollTo = function () {
$("[scroll-to]").click(function () {
var sel = $(this).attr("scroll-to");
// if the `scroll-to` is a parse-able pixel value like `50px`,
// then use that as the scrollTop, else assume it is a selector name
// and find the `offsetTop`.
var top = /\dpx/.test(sel) ?
parseInt(sel, 10) :
$("[name='" + sel + "']").offset().top;
$("body").animate({ scrollTop: top + "px" }, 300);
});
};
export function path_parts() {
return window.location.pathname.split('/').filter(function (chunk) {
return chunk !== '';
@ -152,8 +134,6 @@ var apps_events = function () {
};
var events = function () {
ScrollTo();
// get the location url like `zulipchat.com/features/`, cut off the trailing
// `/` and then split by `/` to get ["zulipchat.com", "features"], then
// pop the last element to get the current section (eg. `features`).