Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

giphy: Upgrade giphy to implement TODO. 

Upgraded to use the tabindex support provided by giphy itself.
This commit is contained in:
Aman Agrawal 2024-06-27 12:16:12 +00:00 committed by Tim Abbott
parent d60075a8cf
commit f27488adc9
4 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package.json
View File

@ -8,8 +8,8 @@
"@babel/register": "^7.6.2", "@babel/register": "^7.6.2",
"@fontsource-variable/open-sans": "^5.0.9", "@fontsource-variable/open-sans": "^5.0.9",
"@formatjs/intl": "^2.0.0", "@formatjs/intl": "^2.0.0",
"@giphy/js-components": "^5.0.5", "@giphy/js-components": "^5.13.0",
"@giphy/js-fetch-api": "^5.0.0", "@giphy/js-fetch-api": "^5.6.0",
"@koa/bodyparser": "^5.0.0", "@koa/bodyparser": "^5.0.0",
"@sentry/browser": "^7.51.2", "@sentry/browser": "^7.51.2",
"@uppy/core": "^3.0.2", "@uppy/core": "^3.0.2",

4
pnpm-lock.yaml
View File

@ -38,10 +38,10 @@ importers:
specifier: ^2.0.0 specifier: ^2.0.0
version: 2.10.4(typescript@5.5.2) version: 2.10.4(typescript@5.5.2)
'@giphy/js-components': '@giphy/js-components':
specifier: ^5.0.5 specifier: ^5.13.0
version: 5.13.0(@babel/core@7.24.7) version: 5.13.0(@babel/core@7.24.7)
'@giphy/js-fetch-api': '@giphy/js-fetch-api':
specifier: ^5.0.0 specifier: ^5.6.0
version: 5.6.0 version: 5.6.0
'@koa/bodyparser': '@koa/bodyparser':
specifier: ^5.0.0 specifier: ^5.0.0

2
version.py
View File

@ -48,4 +48,4 @@ API_FEATURE_LEVEL = 266
# historical commits sharing the same major version, in which case a # historical commits sharing the same major version, in which case a
# minor version bump suffices. # minor version bump suffices.
PROVISION_VERSION = (284, 2) # bumped 2024-06-26 for upgrading transifex-cli PROVISION_VERSION = (284, 3) # bumped 2024-06-27 for upgrading giphy

8
web/src/giphy.js
View File

@ -102,14 +102,6 @@ async function renderGIPHYGrid(targetEl) {
); );
hide_giphy_popover(); hide_giphy_popover();
}, },
onGifVisible(_gif, e) {
// Set tabindex for all the GIFs that
// are visible to the user. This allows
// user to navigate the GIFs using tab.
// TODO: Remove this after https://github.com/Giphy/giphy-js/issues/174
// is closed.
e.target.tabIndex = 0;
},
}, },
targetEl, targetEl,
); );