From f27488adc96702aeeb77f1677d0703c1ff9c2806 Mon Sep 17 00:00:00 2001
From: Aman Agrawal <amanagr@zulip.com>
Date: Thu, 27 Jun 2024 12:16:12 +0000
Subject: [PATCH] giphy: Upgrade giphy to implement TODO.

Upgraded to use the tabindex support provided by giphy itself.
---
 package.json     | 4 ++--
 pnpm-lock.yaml   | 4 ++--
 version.py       | 2 +-
 web/src/giphy.js | 8 --------
 4 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/package.json b/package.json
index 2c4602b614..f3cb99f2ef 100644
--- a/package.json
+++ b/package.json
@@ -8,8 +8,8 @@
     "@babel/register": "^7.6.2",
     "@fontsource-variable/open-sans": "^5.0.9",
     "@formatjs/intl": "^2.0.0",
-    "@giphy/js-components": "^5.0.5",
-    "@giphy/js-fetch-api": "^5.0.0",
+    "@giphy/js-components": "^5.13.0",
+    "@giphy/js-fetch-api": "^5.6.0",
     "@koa/bodyparser": "^5.0.0",
     "@sentry/browser": "^7.51.2",
     "@uppy/core": "^3.0.2",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 892c69e84b..607684e915 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -38,10 +38,10 @@ importers:
         specifier: ^2.0.0
         version: 2.10.4(typescript@5.5.2)
       '@giphy/js-components':
-        specifier: ^5.0.5
+        specifier: ^5.13.0
         version: 5.13.0(@babel/core@7.24.7)
       '@giphy/js-fetch-api':
-        specifier: ^5.0.0
+        specifier: ^5.6.0
         version: 5.6.0
       '@koa/bodyparser':
         specifier: ^5.0.0
diff --git a/version.py b/version.py
index eddf674294..c78d55160c 100644
--- a/version.py
+++ b/version.py
@@ -48,4 +48,4 @@ API_FEATURE_LEVEL = 266
 #   historical commits sharing the same major version, in which case a
 #   minor version bump suffices.
 
-PROVISION_VERSION = (284, 2)  # bumped 2024-06-26 for upgrading transifex-cli
+PROVISION_VERSION = (284, 3)  # bumped 2024-06-27 for upgrading giphy
diff --git a/web/src/giphy.js b/web/src/giphy.js
index d064550c06..4f141d857e 100644
--- a/web/src/giphy.js
+++ b/web/src/giphy.js
@@ -102,14 +102,6 @@ async function renderGIPHYGrid(targetEl) {
                     );
                     hide_giphy_popover();
                 },
-                onGifVisible(_gif, e) {
-                    // Set tabindex for all the GIFs that
-                    // are visible to the user. This allows
-                    // user to navigate the GIFs using tab.
-                    // TODO: Remove this after https://github.com/Giphy/giphy-js/issues/174
-                    // is closed.
-                    e.target.tabIndex = 0;
-                },
             },
             targetEl,
         );