mirror of https://github.com/zulip/zulip.git
developer docs: Extend contributor guide.
Covers why someone's PR might not be merged right away.
This commit is contained in:
parent
4102816240
commit
c390d10fb3
|
@ -224,6 +224,26 @@ labels.
|
||||||
have a new feature you'd like to add, you can start a conversation [in our
|
have a new feature you'd like to add, you can start a conversation [in our
|
||||||
development community](https://zulip.com/development-community/#where-do-i-send-my-message)
|
development community](https://zulip.com/development-community/#where-do-i-send-my-message)
|
||||||
explaining the feature idea and the problem that you're hoping to solve.
|
explaining the feature idea and the problem that you're hoping to solve.
|
||||||
|
- **I think my PR is done, but it hasn't been merged yet. What's going on?**
|
||||||
|
1. **Double-check that you have addressed all the feedback**, including any comments
|
||||||
|
on [Git commit
|
||||||
|
discipline](https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-discipline).
|
||||||
|
2. If all the feedback has been addressed, did you leave a comment explaining that
|
||||||
|
you have done so and **requesting a re-review**? If not, it may not be a
|
||||||
|
clear to project maintainers that your PR is ready for another look.
|
||||||
|
3. It is common for PRs to require **multiple rounds of review**. For example,
|
||||||
|
prior to getting code review from project maintainers, you may receive
|
||||||
|
feedback on the UI (without regard for the implementation), and your code
|
||||||
|
may be reviewed by other contributors. This helps us make good use of
|
||||||
|
project maintainers' time, and helps you make progress on the PR by
|
||||||
|
getting more frequent feedback.
|
||||||
|
4. If you think the PR is ready and haven't seen any updates for a couple
|
||||||
|
of weeks, it can be helpful to post a **comment summarizing your
|
||||||
|
understanding of the state of the review process**.
|
||||||
|
5. Finally, **Zulip project maintainers are people too**! They may be busy
|
||||||
|
with other work, and sometimes they might even take a vacation. ;) It can
|
||||||
|
occasionally take a few weeks for a PR in the final stages of the review
|
||||||
|
process to be merged.
|
||||||
|
|
||||||
## What makes a great Zulip contributor?
|
## What makes a great Zulip contributor?
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue