From c390d10fb3f534287a8fdf0cb1e3fbbf320efe21 Mon Sep 17 00:00:00 2001 From: Alya Abbott Date: Wed, 12 Jan 2022 15:38:37 -0800 Subject: [PATCH] developer docs: Extend contributor guide. Covers why someone's PR might not be merged right away. --- CONTRIBUTING.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a0fe3c63c5..fe63ca7fc6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -224,6 +224,26 @@ labels. have a new feature you'd like to add, you can start a conversation [in our development community](https://zulip.com/development-community/#where-do-i-send-my-message) explaining the feature idea and the problem that you're hoping to solve. +- **I think my PR is done, but it hasn't been merged yet. What's going on?** + 1. **Double-check that you have addressed all the feedback**, including any comments + on [Git commit + discipline](https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-discipline). + 2. If all the feedback has been addressed, did you leave a comment explaining that + you have done so and **requesting a re-review**? If not, it may not be a + clear to project maintainers that your PR is ready for another look. + 3. It is common for PRs to require **multiple rounds of review**. For example, + prior to getting code review from project maintainers, you may receive + feedback on the UI (without regard for the implementation), and your code + may be reviewed by other contributors. This helps us make good use of + project maintainers' time, and helps you make progress on the PR by + getting more frequent feedback. + 4. If you think the PR is ready and haven't seen any updates for a couple + of weeks, it can be helpful to post a **comment summarizing your + understanding of the state of the review process**. + 5. Finally, **Zulip project maintainers are people too**! They may be busy + with other work, and sometimes they might even take a vacation. ;) It can + occasionally take a few weeks for a PR in the final stages of the review + process to be merged. ## What makes a great Zulip contributor?