Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

mypy: Fix strict_equality violations. 

puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag:98: error: Non-overlapping equality check (left operand type: "List[List[str]]", right operand type: "Literal[0]")  [comparison-overlap]
zerver/tests/test_realm.py:650: error: Non-overlapping container check (element type: "Dict[str, Any]", container item type: "str")  [comparison-overlap]

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2021-04-12 14:12:04 -07:00 committed by Tim Abbott
parent 2e928a0853
commit b01d43f339
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag
View File

@ -95,7 +95,7 @@ else:
replication_info = run_sql_query( replication_info = run_sql_query(
"client_addr, state, sent_lsn, write_lsn, flush_lsn, replay_lsn from pg_stat_replication" "client_addr, state, sent_lsn, write_lsn, flush_lsn, replay_lsn from pg_stat_replication"
) )
if replication_info == 0: if not replication_info:
report("CRITICAL", "No replicas!") report("CRITICAL", "No replicas!")
elif len(replication_info) == 1: elif len(replication_info) == 1:
report("WARNING", "Only one replica!") report("WARNING", "Only one replica!")

2
zerver/lib/test_classes.py
View File

@ -849,7 +849,7 @@ Output:
self.assertNotEqual(json["msg"], "Error parsing JSON in response!") self.assertNotEqual(json["msg"], "Error parsing JSON in response!")
return json return json
def get_json_error(self, result: HttpResponse, status_code: int = 400) -> Dict[str, Any]: def get_json_error(self, result: HttpResponse, status_code: int = 400) -> str:
try: try:
json = orjson.loads(result.content) json = orjson.loads(result.content)
except orjson.JSONDecodeError: # nocoverage except orjson.JSONDecodeError: # nocoverage