From b01d43f339bc4ab06400cddd6b2c725028fc4d1b Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 12 Apr 2021 14:12:04 -0700 Subject: [PATCH] mypy: Fix strict_equality violations. puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag:98: error: Non-overlapping equality check (left operand type: "List[List[str]]", right operand type: "Literal[0]") [comparison-overlap] zerver/tests/test_realm.py:650: error: Non-overlapping container check (element type: "Dict[str, Any]", container item type: "str") [comparison-overlap] Signed-off-by: Anders Kaseorg --- .../zulip_postgresql/check_postgresql_replication_lag | 2 +- zerver/lib/test_classes.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag b/puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag index 5be56dff58..5548b7b98b 100755 --- a/puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag +++ b/puppet/zulip/files/nagios_plugins/zulip_postgresql/check_postgresql_replication_lag @@ -95,7 +95,7 @@ else: replication_info = run_sql_query( "client_addr, state, sent_lsn, write_lsn, flush_lsn, replay_lsn from pg_stat_replication" ) - if replication_info == 0: + if not replication_info: report("CRITICAL", "No replicas!") elif len(replication_info) == 1: report("WARNING", "Only one replica!") diff --git a/zerver/lib/test_classes.py b/zerver/lib/test_classes.py index 23c28fff9d..613bd96c83 100644 --- a/zerver/lib/test_classes.py +++ b/zerver/lib/test_classes.py @@ -849,7 +849,7 @@ Output: self.assertNotEqual(json["msg"], "Error parsing JSON in response!") return json - def get_json_error(self, result: HttpResponse, status_code: int = 400) -> Dict[str, Any]: + def get_json_error(self, result: HttpResponse, status_code: int = 400) -> str: try: json = orjson.loads(result.content) except orjson.JSONDecodeError: # nocoverage