mirror of https://github.com/zulip/zulip.git
message_feed: Remove the parenthesis around edited notices.
They were found to not particularly improve the UI. Fixes #21043.
This commit is contained in:
parent
ad232c9b65
commit
67625d6c7b
|
@ -290,7 +290,7 @@ self-explanatory names.
|
||||||
- **message editing**: If the realm admin allows it, then after a user
|
- **message editing**: If the realm admin allows it, then after a user
|
||||||
posts a message, the user has a few minutes to click "Edit" and
|
posts a message, the user has a few minutes to click "Edit" and
|
||||||
change the content of their message. If they do, Zulip adds a
|
change the content of their message. If they do, Zulip adds a
|
||||||
marker such as "(EDITED)" at the top of the message, visible to
|
marker such as "EDITED" at the top of the message, visible to
|
||||||
anyone who can see the message.
|
anyone who can see the message.
|
||||||
|
|
||||||
- **realm**: What the codebase calls an "organization" in the UI.
|
- **realm**: What the codebase calls an "organization" in the UI.
|
||||||
|
|
|
@ -82,12 +82,12 @@ to test their appearance too:
|
||||||
Here's how we're going to test the message appearances:
|
Here's how we're going to test the message appearances:
|
||||||
|
|
||||||
- narrow to a new topic and send a message (this message will include sender)
|
- narrow to a new topic and send a message (this message will include sender)
|
||||||
- edit the message ("(EDITED)" label should appear beside sender name)
|
- edit the message ("EDITED" label should appear beside sender name)
|
||||||
- send another message (will not include sender)
|
- send another message (will not include sender)
|
||||||
- edit the message ("(EDITED)" label should appear in the left column, where the avatar is)
|
- edit the message ("EDITED" label should appear in the left column, where the avatar is)
|
||||||
- send a "/me" message (`/me test message`)
|
- send a "/me" message (`/me test message`)
|
||||||
- message should appear alongside sender name
|
- message should appear alongside sender name
|
||||||
- edit the message ("(EDITED)" label should appear beside the message)
|
- edit the message ("EDITED" label should appear beside the message)
|
||||||
|
|
||||||
For all the three cases, we need to test the click handlers and
|
For all the three cases, we need to test the click handlers and
|
||||||
the hotkeys too:
|
the hotkeys too:
|
||||||
|
|
|
@ -241,7 +241,7 @@ export class MessageListView {
|
||||||
|
|
||||||
_add_msg_edited_vars(message_container) {
|
_add_msg_edited_vars(message_container) {
|
||||||
// This adds variables to message_container object which calculate bools for
|
// This adds variables to message_container object which calculate bools for
|
||||||
// checking position of "(EDITED)" label as well as the edited timestring
|
// checking position of "EDITED" label as well as the edited timestring
|
||||||
// The bools can be defined only when the message is edited
|
// The bools can be defined only when the message is edited
|
||||||
// (or when the `last_edit_timestr` is defined). The bools are:
|
// (or when the `last_edit_timestr` is defined). The bools are:
|
||||||
// * `edited_in_left_col` -- when label appears in left column.
|
// * `edited_in_left_col` -- when label appears in left column.
|
||||||
|
|
|
@ -1,15 +1,15 @@
|
||||||
{{#if msg/local_edit_timestamp}}
|
{{#if msg/local_edit_timestamp}}
|
||||||
<div class="message_edit_notice auto-select" title="{{#tr}}Edited ({last_edit_timestr}){{/tr}}">
|
<div class="message_edit_notice auto-select" title="{{#tr}}Edited ({last_edit_timestr}){{/tr}}">
|
||||||
({{t "SAVING" }})
|
{{t "SAVING" }}
|
||||||
</div>
|
</div>
|
||||||
{{else}}
|
{{else}}
|
||||||
{{#if moved}}
|
{{#if moved}}
|
||||||
<div class="message_edit_notice auto-select" title="{{#tr}}Moved ({last_edit_timestr}){{/tr}}">
|
<div class="message_edit_notice auto-select" title="{{#tr}}Moved ({last_edit_timestr}){{/tr}}">
|
||||||
({{t "MOVED" }})
|
{{t "MOVED" }}
|
||||||
</div>
|
</div>
|
||||||
{{else}}
|
{{else}}
|
||||||
<div class="message_edit_notice auto-select" title="{{#tr}}Edited ({last_edit_timestr}){{/tr}}">
|
<div class="message_edit_notice auto-select" title="{{#tr}}Edited ({last_edit_timestr}){{/tr}}">
|
||||||
({{t "EDITED" }})
|
{{t "EDITED" }}
|
||||||
</div>
|
</div>
|
||||||
{{/if}}
|
{{/if}}
|
||||||
{{/if}}
|
{{/if}}
|
||||||
|
|
|
@ -28,7 +28,7 @@ content.
|
||||||
!!! warn ""
|
!!! warn ""
|
||||||
|
|
||||||
**Note:** After you have edited a message, the message is publicly marked as
|
**Note:** After you have edited a message, the message is publicly marked as
|
||||||
`(EDITED)`. You can [view](/help/view-a-messages-edit-history) a message's
|
`EDITED`. You can [view](/help/view-a-messages-edit-history) a message's
|
||||||
edit history, assuming that feature has not been
|
edit history, assuming that feature has not been
|
||||||
[disabled by an organization administrator](/help/disable-message-edit-history).
|
[disabled by an organization administrator](/help/disable-message-edit-history).
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue