From 67625d6c7b8731cda65b6a97d959843efeb8317c Mon Sep 17 00:00:00 2001 From: jai2201 Date: Tue, 8 Feb 2022 02:08:40 +0530 Subject: [PATCH] message_feed: Remove the parenthesis around edited notices. They were found to not particularly improve the UI. Fixes #21043. --- docs/overview/architecture-overview.md | 2 +- docs/testing/manual-testing.md | 6 +++--- static/js/message_list_view.js | 2 +- static/templates/edited_notice.hbs | 6 +++--- templates/zerver/help/edit-or-delete-a-message.md | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/overview/architecture-overview.md b/docs/overview/architecture-overview.md index ef62293db5..d8f835bde0 100644 --- a/docs/overview/architecture-overview.md +++ b/docs/overview/architecture-overview.md @@ -290,7 +290,7 @@ self-explanatory names. - **message editing**: If the realm admin allows it, then after a user posts a message, the user has a few minutes to click "Edit" and change the content of their message. If they do, Zulip adds a - marker such as "(EDITED)" at the top of the message, visible to + marker such as "EDITED" at the top of the message, visible to anyone who can see the message. - **realm**: What the codebase calls an "organization" in the UI. diff --git a/docs/testing/manual-testing.md b/docs/testing/manual-testing.md index 30b2657aef..9f2934237f 100644 --- a/docs/testing/manual-testing.md +++ b/docs/testing/manual-testing.md @@ -82,12 +82,12 @@ to test their appearance too: Here's how we're going to test the message appearances: - narrow to a new topic and send a message (this message will include sender) - - edit the message ("(EDITED)" label should appear beside sender name) + - edit the message ("EDITED" label should appear beside sender name) - send another message (will not include sender) - - edit the message ("(EDITED)" label should appear in the left column, where the avatar is) + - edit the message ("EDITED" label should appear in the left column, where the avatar is) - send a "/me" message (`/me test message`) - message should appear alongside sender name - - edit the message ("(EDITED)" label should appear beside the message) + - edit the message ("EDITED" label should appear beside the message) For all the three cases, we need to test the click handlers and the hotkeys too: diff --git a/static/js/message_list_view.js b/static/js/message_list_view.js index 2d9740a6f0..0f4957ca9f 100644 --- a/static/js/message_list_view.js +++ b/static/js/message_list_view.js @@ -241,7 +241,7 @@ export class MessageListView { _add_msg_edited_vars(message_container) { // This adds variables to message_container object which calculate bools for - // checking position of "(EDITED)" label as well as the edited timestring + // checking position of "EDITED" label as well as the edited timestring // The bools can be defined only when the message is edited // (or when the `last_edit_timestr` is defined). The bools are: // * `edited_in_left_col` -- when label appears in left column. diff --git a/static/templates/edited_notice.hbs b/static/templates/edited_notice.hbs index 41636bc46d..d61a3daab6 100644 --- a/static/templates/edited_notice.hbs +++ b/static/templates/edited_notice.hbs @@ -1,15 +1,15 @@ {{#if msg/local_edit_timestamp}}
- ({{t "SAVING" }}) + {{t "SAVING" }}
{{else}} {{#if moved}}
- ({{t "MOVED" }}) + {{t "MOVED" }}
{{else}}
- ({{t "EDITED" }}) + {{t "EDITED" }}
{{/if}} {{/if}} diff --git a/templates/zerver/help/edit-or-delete-a-message.md b/templates/zerver/help/edit-or-delete-a-message.md index 35dea863d5..3238ca49da 100644 --- a/templates/zerver/help/edit-or-delete-a-message.md +++ b/templates/zerver/help/edit-or-delete-a-message.md @@ -28,7 +28,7 @@ content. !!! warn "" **Note:** After you have edited a message, the message is publicly marked as - `(EDITED)`. You can [view](/help/view-a-messages-edit-history) a message's + `EDITED`. You can [view](/help/view-a-messages-edit-history) a message's edit history, assuming that feature has not been [disabled by an organization administrator](/help/disable-message-edit-history).