Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

gear_menu: Remove href="#logout" from logout button. 

Remove href="#logout" from last option of gear_menu as
logout is already handled by click handler for .logout_button.

Fixes part of #22802
This commit is contained in:
Hardik Dharmani 2023-07-17 22:11:26 +05:30 committed by Tim Abbott
parent 84f1ee84ff
commit 55b0b5cb96
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/e2e-tests/lib/common.ts
View File

@ -275,7 +275,7 @@ export async function log_in(
export async function log_out(page: Page): Promise<void> { export async function log_out(page: Page): Promise<void> {
await page.goto(realm_url); await page.goto(realm_url);
const menu_selector = "#settings-dropdown"; const menu_selector = "#settings-dropdown";
const logout_selector = '.dropdown-menu a[href="#logout"]'; const logout_selector = ".dropdown-menu a.logout_button";
console.log("Logging out"); console.log("Logging out");
await page.waitForSelector(menu_selector, {visible: true}); await page.waitForSelector(menu_selector, {visible: true});
await page.click(menu_selector); await page.click(menu_selector);

2
web/templates/gear_menu.hbs
View File

@ -176,7 +176,7 @@
</a> </a>
</li> </li>
<li role="presentation"> <li role="presentation">
<a href="#logout" class="logout_button hidden-for-spectators" role="menuitem"> <a class="logout_button hidden-for-spectators" role="menuitem">
<i class="fa fa-power-off" aria-hidden="true"></i> {{t 'Log out' }} <i class="fa fa-power-off" aria-hidden="true"></i> {{t 'Log out' }}
</a> </a>
</li> </li>