From 55b0b5cb965b7dee850244baf55a4d96e5e465c1 Mon Sep 17 00:00:00 2001
From: Hardik Dharmani <Ddharmani99@gmail.com>
Date: Mon, 17 Jul 2023 22:11:26 +0530
Subject: [PATCH] gear_menu: Remove href="#logout" from logout button.

Remove href="#logout" from last option of gear_menu as
logout is already handled by click handler for .logout_button.

Fixes part of #22802
---
 web/e2e-tests/lib/common.ts | 2 +-
 web/templates/gear_menu.hbs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/web/e2e-tests/lib/common.ts b/web/e2e-tests/lib/common.ts
index 4cf0dadfec..7e124f7419 100644
--- a/web/e2e-tests/lib/common.ts
+++ b/web/e2e-tests/lib/common.ts
@@ -275,7 +275,7 @@ export async function log_in(
 export async function log_out(page: Page): Promise<void> {
     await page.goto(realm_url);
     const menu_selector = "#settings-dropdown";
-    const logout_selector = '.dropdown-menu a[href="#logout"]';
+    const logout_selector = ".dropdown-menu a.logout_button";
     console.log("Logging out");
     await page.waitForSelector(menu_selector, {visible: true});
     await page.click(menu_selector);
diff --git a/web/templates/gear_menu.hbs b/web/templates/gear_menu.hbs
index c641a1a45b..195c2a37b5 100644
--- a/web/templates/gear_menu.hbs
+++ b/web/templates/gear_menu.hbs
@@ -176,7 +176,7 @@
                 </a>
             </li>
             <li role="presentation">
-                <a href="#logout" class="logout_button hidden-for-spectators" role="menuitem">
+                <a class="logout_button hidden-for-spectators" role="menuitem">
                     <i class="fa fa-power-off" aria-hidden="true"></i> {{t 'Log out' }}
                 </a>
             </li>