Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

analytics: Cleanup confusingly type-variable all_records.

This commit is contained in:
Tim Abbott 2016-01-25 19:12:35 -08:00
parent 23705f4f16
commit 2436ad19ba
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
analytics/views.py
View File

@ -818,7 +818,6 @@ def realm_user_summary_table(all_records, admin_emails):
@zulip_internal @zulip_internal
def get_realm_activity(request, realm): def get_realm_activity(request, realm):
data = [] data = []
all_records = {}
all_user_records = {} all_user_records = {}
try: try:
@ -829,8 +828,7 @@ def get_realm_activity(request, realm):
admin_emails = {admin.email for admin in admins} admin_emails = {admin.email for admin in admins}
for is_bot, page_title in [(False, 'Humans'), (True, 'Bots')]: for is_bot, page_title in [(False, 'Humans'), (True, 'Bots')]:
all_records = get_user_activity_records_for_realm(realm, is_bot) all_records = list(get_user_activity_records_for_realm(realm, is_bot))
all_records = list(all_records)
user_records, content = realm_user_summary_table(all_records, admin_emails) user_records, content = realm_user_summary_table(all_records, admin_emails)
all_user_records.update(user_records) all_user_records.update(user_records)