From 2436ad19bac4301794e8a12453d456a57c61b8f3 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Mon, 25 Jan 2016 19:12:35 -0800 Subject: [PATCH] analytics: Cleanup confusingly type-variable all_records. --- analytics/views.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/analytics/views.py b/analytics/views.py index 04fbf38859..fc27b41109 100644 --- a/analytics/views.py +++ b/analytics/views.py @@ -818,7 +818,6 @@ def realm_user_summary_table(all_records, admin_emails): @zulip_internal def get_realm_activity(request, realm): data = [] - all_records = {} all_user_records = {} try: @@ -829,8 +828,7 @@ def get_realm_activity(request, realm): admin_emails = {admin.email for admin in admins} for is_bot, page_title in [(False, 'Humans'), (True, 'Bots')]: - all_records = get_user_activity_records_for_realm(realm, is_bot) - all_records = list(all_records) + all_records = list(get_user_activity_records_for_realm(realm, is_bot)) user_records, content = realm_user_summary_table(all_records, admin_emails) all_user_records.update(user_records)