Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

email: Remove translation tags from email templates. 

The only thing being translated in any email was the title of the Zulip
header image in the html file, probably because not doing so breaks a linter
rule.

he name "Zulip" doesn't make sense to translate anyway.
This commit is contained in:
Rishi Gupta 2017-05-01 14:39:28 -07:00 committed by Tim Abbott
parent 975d5bd8c0
commit 21a2c7b9d9
5 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/zerver/emails/followup/day1.html
View File

@ -7,7 +7,7 @@
<body>
<table width="80%" style="align:center; max-width:800px" align="center">
<tr><td>
<a href="{{ realm_uri }}/"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="{{ _('Zulip') }}" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<a href="{{ realm_uri }}/"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="Zulip" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<h3 style="font-family:Arial; font-size:30px; margin: 5px 0px; color:#555">we love our users</h3>
</td></tr>

2
templates/zerver/emails/followup/day2.html
View File

@ -7,7 +7,7 @@
<body>
<table width="80%" style="align:center; max-width:800px" align="center">
<tr><td>
<a href="{{ realm_uri }}/"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="{{ _('Zulip') }}" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<a href="{{ realm_uri }}/"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="Zulip" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<h3 style="font-family:Arial; font-size:30px; margin: 5px 0px; color:#555">one last thing</h3>
</td></tr>

2
templates/zerver/emails/invitation/invitation_reminder_email.html
View File

@ -9,7 +9,7 @@
<tr>
<td>
<a href="{{ server_uri }}/hello">
<img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="{{ _('Zulip') }}" src="{{ server_uri }}/static/images/landing-page/zulip-header.png" />
<img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="Zulip" src="{{ server_uri }}/static/images/landing-page/zulip-header.png" />
</a>
<h3 style="font-family:Arial; font-size:30px; margin: 5px 0px; color:#555">
you're busy: we get you

2
templates/zerver/emails/new_login/new_login_alert.html
View File

@ -8,7 +8,7 @@
<table width="80%" style="align:center; max-width:800px" align="center">
<tr>
<td>
<a href="{{ realm_uri }}"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="{{ _('Zulip') }}" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<a href="{{ realm_uri }}"><img style="max-height:75px; height:75px;" height="75px" alt="Zulip" title="Zulip" src="{{ realm_uri }}/static/images/landing-page/zulip-header.png" /></a>
<h3 style="font-family:Arial; font-size:30px; margin: 5px 0px; color:#555">New login to Zulip</h3>
</td>
</tr>

1
tools/lint
View File

@ -501,6 +501,7 @@ def build_custom_checkers(by_lang):
('templates/zerver/markdown_help.html',
'<td><img alt=":heart:" class="emoji" src="/static/generated/emoji/images/emoji/heart.png" title=":heart:" /></td>')
]),
'exclude': set(["templates/zerver/emails"]),
'description': "`title` value should be translatable."},
] # type: RuleList
handlebars_rules = html_rules + [