From 21a2c7b9d94087768080a6d2dbf79a61f96d4322 Mon Sep 17 00:00:00 2001 From: Rishi Gupta Date: Mon, 1 May 2017 14:39:28 -0700 Subject: [PATCH] email: Remove translation tags from email templates. The only thing being translated in any email was the title of the Zulip header image in the html file, probably because not doing so breaks a linter rule. he name "Zulip" doesn't make sense to translate anyway. --- templates/zerver/emails/followup/day1.html | 2 +- templates/zerver/emails/followup/day2.html | 2 +- .../zerver/emails/invitation/invitation_reminder_email.html | 2 +- templates/zerver/emails/new_login/new_login_alert.html | 2 +- tools/lint | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/templates/zerver/emails/followup/day1.html b/templates/zerver/emails/followup/day1.html index 9669da19b4..772700fede 100644 --- a/templates/zerver/emails/followup/day1.html +++ b/templates/zerver/emails/followup/day1.html @@ -7,7 +7,7 @@ diff --git a/templates/zerver/emails/followup/day2.html b/templates/zerver/emails/followup/day2.html index 86d32ffc3c..05e94297ef 100644 --- a/templates/zerver/emails/followup/day2.html +++ b/templates/zerver/emails/followup/day2.html @@ -7,7 +7,7 @@
-Zulip +Zulip

we love our users

diff --git a/templates/zerver/emails/invitation/invitation_reminder_email.html b/templates/zerver/emails/invitation/invitation_reminder_email.html index 5240cc397c..55b91c5913 100644 --- a/templates/zerver/emails/invitation/invitation_reminder_email.html +++ b/templates/zerver/emails/invitation/invitation_reminder_email.html @@ -9,7 +9,7 @@
- Zulip + Zulip

one last thing

- Zulip + Zulip

you're busy: we get you diff --git a/templates/zerver/emails/new_login/new_login_alert.html b/templates/zerver/emails/new_login/new_login_alert.html index 535ae9ac46..7d964c0259 100644 --- a/templates/zerver/emails/new_login/new_login_alert.html +++ b/templates/zerver/emails/new_login/new_login_alert.html @@ -8,7 +8,7 @@ diff --git a/tools/lint b/tools/lint index ad9af07ea2..654e7ad357 100755 --- a/tools/lint +++ b/tools/lint @@ -501,6 +501,7 @@ def build_custom_checkers(by_lang): ('templates/zerver/markdown_help.html', '') ]), + 'exclude': set(["templates/zerver/emails"]), 'description': "`title` value should be translatable."}, ] # type: RuleList handlebars_rules = html_rules + [
- Zulip + Zulip

New login to Zulip
:heart: