Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_events: Don't update msg if we don't have it cached locally. 

This fixes a bug where we try to rerender the anchor message even
if we don't have it locally cached which results in error.

The bug was introduced in #31942.
This commit is contained in:
Aman Agrawal 2024-10-18 08:27:00 +00:00 committed by Tim Abbott
parent eaee5763d6
commit 1cc9947786
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/message_events.js
View File

@ -381,9 +381,14 @@ export function update_messages(events) {
const stream_archived = old_stream === undefined; const stream_archived = old_stream === undefined;
if (!topic_edited && !stream_changed) { if (!topic_edited && !stream_changed) {
// If the topic or stream of the message was changed, // If the topic or stream of the anchor message was changed,
// it will be rerendered if present in any rendered list. // it will be rerendered if present in any rendered list.
//
// But for content edits, we need to schedule it to be
// rerendered, if we have a local copy of it.
if (anchor_message !== undefined) {
messages_to_rerender.push(anchor_message); messages_to_rerender.push(anchor_message);
}
} else { } else {
const going_forward_change = ["change_later", "change_all"].includes( const going_forward_change = ["change_later", "change_all"].includes(
event.propagate_mode, event.propagate_mode,