From 1cc9947786e04ed61413bb4cfe58413e40686937 Mon Sep 17 00:00:00 2001 From: Aman Agrawal Date: Fri, 18 Oct 2024 08:27:00 +0000 Subject: [PATCH] message_events: Don't update msg if we don't have it cached locally. This fixes a bug where we try to rerender the anchor message even if we don't have it locally cached which results in error. The bug was introduced in #31942. --- web/src/message_events.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/web/src/message_events.js b/web/src/message_events.js index c53c2822ad..d74d4fd61f 100644 --- a/web/src/message_events.js +++ b/web/src/message_events.js @@ -381,9 +381,14 @@ export function update_messages(events) { const stream_archived = old_stream === undefined; if (!topic_edited && !stream_changed) { - // If the topic or stream of the message was changed, + // If the topic or stream of the anchor message was changed, // it will be rerendered if present in any rendered list. - messages_to_rerender.push(anchor_message); + // + // But for content edits, we need to schedule it to be + // rerendered, if we have a local copy of it. + if (anchor_message !== undefined) { + messages_to_rerender.push(anchor_message); + } } else { const going_forward_change = ["change_later", "change_all"].includes( event.propagate_mode,