Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

rocketchat: Fix "OSError: [Errno 36] File name too long" error. 

Earlier, we were replacing too long attachment name with random uuid
when the character count of the file name was greater than 255.

This results in "OSError: [Errno 36] File name too long" error in
few cases when the file name has less than 255 characters but more
than 255 bytes (file name with Non-ASCII characters).

This commit updates the code to check the file name's byte size
instead of characters count.
This commit is contained in:
Prakhar Pratyush 2024-08-14 19:26:23 +05:30 committed by Tim Abbott
parent 54492ec7a0
commit 19d56f77b5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/data_import/rocketchat.py
View File

@ -402,7 +402,7 @@ def process_message_attachment(
logging.info("Replacing invalid attachment name with random uuid: %s", file_name) logging.info("Replacing invalid attachment name with random uuid: %s", file_name)
sanitized_name = uuid.uuid4().hex sanitized_name = uuid.uuid4().hex
if len(sanitized_name) >= 255: # nocoverage if len(sanitized_name.encode("utf-8")) >= 255: # nocoverage
logging.info("Replacing too long attachment name with random uuid: %s", file_name) logging.info("Replacing too long attachment name with random uuid: %s", file_name)
sanitized_name = uuid.uuid4().hex sanitized_name = uuid.uuid4().hex