Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactoring: Remove unnecessary _allow_only_listed_keys in test_events. 

When I was initially writing the tests to solve issue #10131 in PR
2 schema checkers as I modified the code to send the rendered_value
only when required.

When I was using just 1 schema checker shared between two code paths,
we needed _allow_only_listed_keys. But after shifting to 2 schema
checkers for the two different cases, we no longer needed that flag,
and it's better to remove it for a stronger check.
This commit is contained in:
Hemanth V. Alluri 2019-01-18 15:42:59 +05:30 committed by Tim Abbott
parent 19a4c6de6a
commit 10211e7565
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/tests/test_events.py
View File

@ -1077,7 +1077,7 @@ class EventsRegisterTest(ZulipTestCase):
('custom_profile_field', check_dict([ ('custom_profile_field', check_dict([
('id', check_int), ('id', check_int),
('value', check_none_or(check_string)), ('value', check_none_or(check_string)),
], _allow_only_listed_keys=False)), ])),
])), ])),
]) ])
@ -1090,7 +1090,7 @@ class EventsRegisterTest(ZulipTestCase):
('id', check_int), ('id', check_int),
('value', check_none_or(check_string)), ('value', check_none_or(check_string)),
('rendered_value', check_none_or(check_string)), ('rendered_value', check_none_or(check_string)),
], _allow_only_listed_keys=False)), ])),
])), ])),
]) ])