From 10211e75650f64a4331fb652bd7306bad878b29a Mon Sep 17 00:00:00 2001 From: "Hemanth V. Alluri" Date: Fri, 18 Jan 2019 15:42:59 +0530 Subject: [PATCH] refactoring: Remove unnecessary _allow_only_listed_keys in test_events. When I was initially writing the tests to solve issue #10131 in PR 2 schema checkers as I modified the code to send the rendered_value only when required. When I was using just 1 schema checker shared between two code paths, we needed _allow_only_listed_keys. But after shifting to 2 schema checkers for the two different cases, we no longer needed that flag, and it's better to remove it for a stronger check. --- zerver/tests/test_events.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zerver/tests/test_events.py b/zerver/tests/test_events.py index 74ebd95c1c..730c45dcd6 100644 --- a/zerver/tests/test_events.py +++ b/zerver/tests/test_events.py @@ -1077,7 +1077,7 @@ class EventsRegisterTest(ZulipTestCase): ('custom_profile_field', check_dict([ ('id', check_int), ('value', check_none_or(check_string)), - ], _allow_only_listed_keys=False)), + ])), ])), ]) @@ -1090,7 +1090,7 @@ class EventsRegisterTest(ZulipTestCase): ('id', check_int), ('value', check_none_or(check_string)), ('rendered_value', check_none_or(check_string)), - ], _allow_only_listed_keys=False)), + ])), ])), ])