2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2021-04-13 06:51:54 +02:00
|
|
|
const {$t} = require("../zjsunit/i18n");
|
2021-06-16 15:58:34 +02:00
|
|
|
const {mock_jquery, zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-06-18 18:03:46 +02:00
|
|
|
const blueslip = require("../zjsunit/zblueslip");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
let env;
|
2021-03-11 05:43:42 +01:00
|
|
|
|
|
|
|
function make_tab(i) {
|
2022-01-25 11:36:19 +01:00
|
|
|
const $self = {};
|
2021-03-11 05:43:42 +01:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.tabs.length, i);
|
2021-03-11 05:43:42 +01:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.stub = true;
|
|
|
|
$self.class = [];
|
2021-03-11 05:43:42 +01:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.addClass = (c) => {
|
|
|
|
$self.class += " " + c;
|
|
|
|
const tokens = $self.class.trim().split(/ +/);
|
|
|
|
$self.class = Array.from(new Set(tokens)).join(" ");
|
2021-03-11 05:43:42 +01:00
|
|
|
};
|
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.removeClass = (c) => {
|
|
|
|
const tokens = $self.class.trim().split(/ +/);
|
|
|
|
$self.class = tokens.filter((token) => token !== c).join(" ");
|
2021-03-11 05:43:42 +01:00
|
|
|
};
|
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.hasClass = (c) => {
|
|
|
|
const tokens = $self.class.trim().split(/ +/);
|
2021-03-11 05:43:42 +01:00
|
|
|
return tokens.includes(c);
|
|
|
|
};
|
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.data = (name) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
assert.equal(name, "tab-id");
|
|
|
|
return i;
|
|
|
|
};
|
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.text = (text) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
assert.equal(
|
|
|
|
text,
|
|
|
|
[
|
|
|
|
"translated: Keyboard shortcuts",
|
|
|
|
"translated: Message formatting",
|
2022-12-09 04:13:09 +01:00
|
|
|
"translated: Search filters",
|
2021-03-11 05:43:42 +01:00
|
|
|
][i],
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.trigger = (type) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
if (type === "focus") {
|
2021-03-14 09:33:55 +01:00
|
|
|
env.focused_tab = i;
|
2021-03-11 05:43:42 +01:00
|
|
|
}
|
|
|
|
};
|
2019-05-08 09:26:27 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
env.tabs.push($self);
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
return $self;
|
2021-03-11 05:43:42 +01:00
|
|
|
}
|
2021-02-06 03:36:45 +01:00
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
const ind_tab = (function () {
|
2022-01-25 11:36:19 +01:00
|
|
|
const $self = {};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.stub = true;
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.on = (name, f) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
if (name === "click") {
|
2021-03-14 09:33:55 +01:00
|
|
|
env.click_f = f;
|
2021-03-11 05:43:42 +01:00
|
|
|
} else if (name === "keydown") {
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f = f;
|
2021-03-11 05:43:42 +01:00
|
|
|
}
|
|
|
|
};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.removeClass = (c) => {
|
|
|
|
for (const $tab of env.tabs) {
|
|
|
|
$tab.removeClass(c);
|
2021-03-11 05:43:42 +01:00
|
|
|
}
|
|
|
|
};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.eq = (idx) => env.tabs[idx];
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
return $self;
|
2021-03-11 05:43:42 +01:00
|
|
|
})();
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
function make_switcher() {
|
2022-01-25 11:36:19 +01:00
|
|
|
const $self = {};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.stub = true;
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.children = [];
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.classList = new Set();
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.append = (child) => {
|
|
|
|
$self.children.push(child);
|
2021-03-11 05:43:42 +01:00
|
|
|
};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.addClass = (c) => {
|
|
|
|
$self.classList.add(c);
|
|
|
|
$self.addedClass = c;
|
2021-03-11 05:43:42 +01:00
|
|
|
};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
$self.find = (sel) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
switch (sel) {
|
|
|
|
case ".ind-tab":
|
|
|
|
return ind_tab;
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore next */
|
2021-03-11 05:43:42 +01:00
|
|
|
default:
|
|
|
|
throw new Error("unknown selector: " + sel);
|
|
|
|
}
|
|
|
|
};
|
2020-04-20 22:41:03 +02:00
|
|
|
|
2022-01-25 11:36:19 +01:00
|
|
|
return $self;
|
2021-03-14 09:33:55 +01:00
|
|
|
}
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2022-08-16 06:50:20 +02:00
|
|
|
mock_jquery((sel) => {
|
2021-03-11 05:43:42 +01:00
|
|
|
if (sel.stub) {
|
|
|
|
// The component often redundantly re-wraps objects.
|
|
|
|
return sel;
|
|
|
|
}
|
2020-04-20 22:41:03 +02:00
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
switch (sel) {
|
2022-08-16 06:50:20 +02:00
|
|
|
case "<div>":
|
|
|
|
return {
|
|
|
|
addClass(className) {
|
|
|
|
if (className === "tab-switcher") {
|
|
|
|
return env.switcher;
|
|
|
|
}
|
|
|
|
|
|
|
|
assert.equal(className, "ind-tab");
|
|
|
|
return {
|
|
|
|
attr(attributes) {
|
|
|
|
const tab_id = attributes["data-tab-id"];
|
|
|
|
assert.deepEqual(
|
|
|
|
attributes,
|
|
|
|
[
|
|
|
|
{
|
|
|
|
"data-tab-key": "keyboard-shortcuts",
|
|
|
|
"data-tab-id": 0,
|
|
|
|
tabindex: 0,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"data-tab-key": "message-formatting",
|
|
|
|
"data-tab-id": 1,
|
|
|
|
tabindex: 0,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"data-tab-key": "search-operators",
|
|
|
|
"data-tab-id": 2,
|
|
|
|
tabindex: 0,
|
|
|
|
},
|
|
|
|
][tab_id],
|
|
|
|
);
|
|
|
|
return make_tab(tab_id);
|
|
|
|
},
|
|
|
|
};
|
|
|
|
},
|
|
|
|
};
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore next */
|
2021-03-11 05:43:42 +01:00
|
|
|
default:
|
|
|
|
throw new Error("unknown selector: " + sel);
|
|
|
|
}
|
|
|
|
});
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
const components = zrequire("components");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
const noop = () => {};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-05-26 19:51:07 +02:00
|
|
|
const LEFT_KEY = {key: "ArrowLeft", preventDefault: noop, stopPropagation: noop};
|
|
|
|
const RIGHT_KEY = {key: "ArrowRight", preventDefault: noop, stopPropagation: noop};
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
run_test("basics", () => {
|
2021-03-14 09:33:55 +01:00
|
|
|
env = {
|
|
|
|
keydown_f: undefined,
|
|
|
|
click_f: undefined,
|
|
|
|
tabs: [],
|
|
|
|
focused_tab: undefined,
|
|
|
|
switcher: make_switcher(),
|
|
|
|
};
|
|
|
|
|
2021-03-11 05:43:42 +01:00
|
|
|
let callback_args;
|
2019-11-02 00:06:25 +01:00
|
|
|
let callback_value;
|
2018-04-04 21:06:58 +02:00
|
|
|
|
2019-10-26 01:49:36 +02:00
|
|
|
let widget = null;
|
2018-04-04 21:06:58 +02:00
|
|
|
widget = components.toggle({
|
2018-03-29 15:05:37 +02:00
|
|
|
selected: 0,
|
|
|
|
values: [
|
2021-04-13 06:51:54 +02:00
|
|
|
{label: $t({defaultMessage: "Keyboard shortcuts"}), key: "keyboard-shortcuts"},
|
|
|
|
{label: $t({defaultMessage: "Message formatting"}), key: "message-formatting"},
|
2022-12-09 04:13:09 +01:00
|
|
|
{label: $t({defaultMessage: "Search filters"}), key: "search-operators"},
|
2018-03-29 15:05:37 +02:00
|
|
|
],
|
2020-04-20 22:41:03 +02:00
|
|
|
html_class: "stream_sorter_toggle",
|
2020-07-20 22:18:43 +02:00
|
|
|
callback(name, key) {
|
2018-03-29 15:05:37 +02:00
|
|
|
assert.equal(callback_args, undefined);
|
|
|
|
callback_args = [name, key];
|
2018-04-04 21:06:58 +02:00
|
|
|
|
|
|
|
// The subs code tries to get a widget value in the middle of a
|
|
|
|
// callback, which can lead to obscure bugs.
|
|
|
|
if (widget) {
|
|
|
|
callback_value = widget.value();
|
|
|
|
}
|
2018-03-29 15:05:37 +02:00
|
|
|
},
|
|
|
|
});
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(widget.get(), env.switcher);
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.deepEqual(env.switcher.children, env.tabs);
|
2018-03-29 15:05:37 +02:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.switcher.addedClass, "stream_sorter_toggle");
|
2020-04-20 22:41:03 +02:00
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.focused_tab, 0);
|
|
|
|
assert.equal(env.tabs[0].class, "first selected");
|
|
|
|
assert.equal(env.tabs[1].class, "middle");
|
|
|
|
assert.equal(env.tabs[2].class, "last");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.deepEqual(callback_args, ["translated: Keyboard shortcuts", "keyboard-shortcuts"]);
|
|
|
|
assert.equal(widget.value(), "translated: Keyboard shortcuts");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
|
|
|
callback_args = undefined;
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
widget.goto("message-formatting");
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.focused_tab, 1);
|
|
|
|
assert.equal(env.tabs[0].class, "first");
|
|
|
|
assert.equal(env.tabs[1].class, "middle selected");
|
|
|
|
assert.equal(env.tabs[2].class, "last");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.deepEqual(callback_args, ["translated: Message formatting", "message-formatting"]);
|
|
|
|
assert.equal(widget.value(), "translated: Message formatting");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
toggler: Always call back to callback function.
In our toggler component (the thing that handles tabs in things
like our markdown/search help, settings/org, etc.), we have
a callback mechanism when you switch to the tab. We were
being tricky and only calling it when the tab changed.
It turns out it's better to just always call the callback,
since these things are often in modals that open and close,
and if you open a modal for the second time, you want to do
the callback task for whichever setting you're going to.
There was actually kind of a nasty bug with this, where the
keyboard handling in the keyboard-help modal worked fine the
first time you opened it, but then it didn't work the second
time (if you focused some other element in the interim), and
it was due to not re-setting the focus to the inner modal
because we weren't calling the callback.
Of course, there are pitfalls in calling the same callbacks
twice, but our callbacks should generally be idempotent
for other reasons.
2018-06-03 22:12:10 +02:00
|
|
|
// Go to same tab twice and make sure we get callback.
|
2018-03-29 15:05:37 +02:00
|
|
|
callback_args = undefined;
|
2020-07-15 01:29:15 +02:00
|
|
|
widget.goto("message-formatting");
|
|
|
|
assert.deepEqual(callback_args, ["translated: Message formatting", "message-formatting"]);
|
2018-03-29 15:05:37 +02:00
|
|
|
|
toggler: Always call back to callback function.
In our toggler component (the thing that handles tabs in things
like our markdown/search help, settings/org, etc.), we have
a callback mechanism when you switch to the tab. We were
being tricky and only calling it when the tab changed.
It turns out it's better to just always call the callback,
since these things are often in modals that open and close,
and if you open a modal for the second time, you want to do
the callback task for whichever setting you're going to.
There was actually kind of a nasty bug with this, where the
keyboard handling in the keyboard-help modal worked fine the
first time you opened it, but then it didn't work the second
time (if you focused some other element in the interim), and
it was due to not re-setting the focus to the inner modal
because we weren't calling the callback.
Of course, there are pitfalls in calling the same callbacks
twice, but our callbacks should generally be idempotent
for other reasons.
2018-06-03 22:12:10 +02:00
|
|
|
callback_args = undefined;
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY);
|
|
|
|
assert.equal(env.focused_tab, 2);
|
|
|
|
assert.equal(env.tabs[0].class, "first");
|
|
|
|
assert.equal(env.tabs[1].class, "middle");
|
|
|
|
assert.equal(env.tabs[2].class, "last selected");
|
2022-12-09 04:13:09 +01:00
|
|
|
assert.deepEqual(callback_args, ["translated: Search filters", "search-operators"]);
|
|
|
|
assert.equal(widget.value(), "translated: Search filters");
|
2018-04-04 21:06:58 +02:00
|
|
|
assert.equal(widget.value(), callback_value);
|
2018-03-29 15:05:37 +02:00
|
|
|
|
|
|
|
// try to crash the key handler
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY);
|
2022-12-09 04:13:09 +01:00
|
|
|
assert.equal(widget.value(), "translated: Search filters");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
|
|
|
callback_args = undefined;
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], LEFT_KEY);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(widget.value(), "translated: Message formatting");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
|
|
|
callback_args = undefined;
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], LEFT_KEY);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(widget.value(), "translated: Keyboard shortcuts");
|
2018-03-29 15:05:37 +02:00
|
|
|
|
|
|
|
// try to crash the key handler
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], LEFT_KEY);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(widget.value(), "translated: Keyboard shortcuts");
|
2018-03-29 20:48:49 +02:00
|
|
|
|
2020-07-07 19:48:59 +02:00
|
|
|
callback_args = undefined;
|
|
|
|
widget.disable_tab("message-formatting");
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY);
|
2022-12-09 04:13:09 +01:00
|
|
|
assert.equal(widget.value(), "translated: Search filters");
|
2020-07-07 19:48:59 +02:00
|
|
|
|
|
|
|
callback_args = undefined;
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
env.keydown_f.call(env.tabs[env.focused_tab], LEFT_KEY);
|
2020-07-07 19:48:59 +02:00
|
|
|
assert.equal(widget.value(), "translated: Keyboard shortcuts");
|
|
|
|
|
|
|
|
widget.enable_tab("message-formatting");
|
|
|
|
|
2018-03-29 20:48:49 +02:00
|
|
|
callback_args = undefined;
|
|
|
|
|
2021-03-14 09:33:55 +01:00
|
|
|
env.click_f.call(env.tabs[1]);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(widget.value(), "translated: Message formatting");
|
2019-05-08 09:26:27 +02:00
|
|
|
|
|
|
|
callback_args = undefined;
|
|
|
|
widget.disable_tab("search-operators");
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.tabs[2].hasClass("disabled"), true);
|
|
|
|
assert.equal(env.tabs[2].class, "last disabled");
|
2019-05-08 09:26:27 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
widget.goto("keyboard-shortcuts");
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.focused_tab, 0);
|
2019-05-08 09:26:27 +02:00
|
|
|
widget.goto("search-operators");
|
2021-03-14 09:33:55 +01:00
|
|
|
assert.equal(env.focused_tab, 0);
|
2021-06-18 18:03:46 +02:00
|
|
|
|
|
|
|
blueslip.expect("warn", "Incorrect tab name given.", 3);
|
|
|
|
widget.disable_tab("incorrect-tab");
|
|
|
|
widget.enable_tab("incorrect-tab");
|
|
|
|
widget.goto("incorrect-tab");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|