Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/bitbucket2/tests.py

455 lines
26 KiB
Python
Raw Normal View History

requirements: Drop direct dependency on mock. mock is just a backport of the standard library’s unittest.mock now. The SAMLAuthBackendTest change is needed because MagicMock.call_args.args wasn’t introduced until Python 3.8 (https://bugs.python.org/issue21269). The PROVISION_VERSION bump is skipped because mock is still an indirect dev requirement via moto. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-26 07:16:25 +02:00
from unittest.mock import MagicMock, patch
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
from zerver.lib.request import RequestNotes
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
from zerver.lib.test_helpers import HostRequestMock
bitbucket2: Strengthen types using WildValue. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 07:03:22 +01:00
from zerver.lib.validator import wrap_wild_value
models: Extract zerver.models.clients. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-12-15 04:33:19 +01:00
from zerver.models.clients import get_client
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
from zerver.webhooks.bitbucket2.view import get_user_info
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC = "Repository name"
TOPIC_PR_EVENTS = "Repository name / PR #1 new commit"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
TOPIC_ISSUE_EVENTS = "Repository name / issue #1 Bug"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC_BRANCH_EVENTS = "Repository name / master"
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class Bitbucket2HookTests(WebhookTestCase):
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
STREAM_NAME = "bitbucket2"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
URL_TEMPLATE = "/api/v1/external/bitbucket2?stream={stream}&api_key={api_key}"
webhook: Rename FIXTURE_DIR_NAME to WEBHOOK_DIR_NAME. Since FIXTURE_DIR_NAME is the name of the folder that contains the view and tests modules of the webhook and another folder called "fixtures" that store the fixtures, it is more appropriate to call it WEBHOOK_DIR_NAME, especially when we want to refer to the view module using this variable.
2021-06-26 09:18:33 +02:00
WEBHOOK_DIR_NAME = "bitbucket2"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_event(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = f"Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n{commit_info}"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push", TOPIC_BRANCH_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n"
ruff: Fix E226 Missing whitespace around arithmetic operator. This is a preview rule, not yet enabled by default. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 02:57:55 +01:00
expected_message = f"""Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 3 commits to branch master. Commits by Ben (2) and Tomasz (1).\n\n{commit_info * 2}* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push_multiple_committers", TOPIC_BRANCH_EVENTS, expected_message)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_with_others(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n"
ruff: Fix E226 Missing whitespace around arithmetic operator. This is a preview rule, not yet enabled by default. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 02:57:55 +01:00
expected_message = f"""Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 10 commits to branch master. Commits by Tomasz (4), James (3), Brendon (2) and others (1).\n\n{commit_info * 9}* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"push_multiple_committers_with_others", TOPIC_BRANCH_EVENTS, expected_message
)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n"
ruff: Fix E226 Missing whitespace around arithmetic operator. This is a preview rule, not yet enabled by default. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 02:57:55 +01:00
expected_message = f"""Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 3 commits to branch master. Commits by Ben (2) and Tomasz (1).\n\n{commit_info * 2}* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push_multiple_committers", TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_with_others_filtered_by_branches(
self,
) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n"
ruff: Fix E226 Missing whitespace around arithmetic operator. This is a preview rule, not yet enabled by default. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 02:57:55 +01:00
expected_message = f"""Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 10 commits to branch master. Commits by Tomasz (4), James (3), Brendon (2) and others (1).\n\n{commit_info * 9}* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"push_multiple_committers_with_others", TOPIC_BRANCH_EVENTS, expected_message
)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_event_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = f"Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n{commit_info}"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push", TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_above_limit_event(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* a ([6f161a7bced](https://bitbucket.org/kolaszek/repository-name/commits/6f161a7bced94430ac8947d87dbf45c6deee3fb0))\n"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = f"Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branches/compare/6f161a7bced94430ac8947d87dbf45c6deee3fb0..1221f2fda6f1e3654b09f1f3a08390e4cb25bb48) 5 commits to branch master.\n\n{(commit_info * 5)}[and more commit(s)]"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push_commits_above_limit", TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 tests for commits more than limit.
2016-10-07 15:12:51 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_above_limit_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* a ([6f161a7bced](https://bitbucket.org/kolaszek/repository-name/commits/6f161a7bced94430ac8947d87dbf45c6deee3fb0))\n"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = f"Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branches/compare/6f161a7bced94430ac8947d87dbf45c6deee3fb0..1221f2fda6f1e3654b09f1f3a08390e4cb25bb48) 5 commits to branch master.\n\n{(commit_info * 5)}[and more commit(s)]"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("push_commits_above_limit", TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_force_push_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz [force pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) to branch master. Head is now 25f93d22b719e2d678a7ad5ee0ef0d1fcdf39c12."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("force_push", TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 force push event handler.
2016-10-06 15:32:10 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_force_push_event_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz [force pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) to branch master. Head is now 25f93d22b719e2d678a7ad5ee0ef0d1fcdf39c12."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("force_push", TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_remove_branch_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz deleted branch master."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("remove_branch", TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 remove branch message handler.
2016-10-06 16:14:51 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_fork_event(self) -> None:
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
expected_message = "Tomasz forked the repository into [kolaszek/repository-name2](https://bitbucket.org/kolaszek/repository-name2)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("fork", TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_commit_comment_created_event(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
expected_message = "Tomasz [commented](https://bitbucket.org/kolaszek/repository-name/commits/32c4ea19aa3af10acd08e419e2c354941a365d74#comment-3354963) on [32c4ea19aa3](https://bitbucket.org/kolaszek/repository-name/commits/32c4ea19aa3af10acd08e419e2c354941a365d74):\n~~~ quote\nNice fix!\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("commit_comment_created", TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_commit_status_changed_event(self) -> None:
webhooks: Use get_short_sha to get shortened sha. This unifies the length of the shortened SHA our integrations generate, and ensures that they are long enough for projects of various sizes with a chosen value defined in get_short_sha. Fixes #23475 Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:24:35 +01:00
expected_message = "[System mybuildtool](https://my-build-tool.com/builds/MY-PROJECT/BUILD-777) changed status of [9fec847784a](https://bitbucket.org/kolaszek/repository-name/commits/9fec847784abb10b2fa567ee63b85bd238955d0e) to SUCCESSFUL."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("commit_status_changed", TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_created_event(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz created [issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug) (assigned to Tomasz):\n\n~~~ quote\nSuch a bug\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("issue_created", TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_issue_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz created [issue #1 Bug](https://bitbucket.org/kolaszek/repository-name/issues/2/bug) (assigned to Tomasz):\n\n~~~ quote\nSuch a bug\n~~~"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_created", expected_topic_name, expected_message)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_updated_event(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz updated [issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("issue_updated", TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_commented_event(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz [commented](https://bitbucket.org/kolaszek/repository-name/issues/2#comment-28973596) on [issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("issue_commented", TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_issue_commented_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz [commented](https://bitbucket.org/kolaszek/repository-name/issues/2#comment-28973596) on [issue #1 Bug](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_commented", expected_topic_name, expected_message)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_created_event(self) -> None:
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
expected_message = "Tomasz created [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) from `new-branch` to `master` (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_created_or_updated",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:created",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
def test_bitbucket2_on_pull_request_created_without_reviewer_username_event(self) -> None:
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
expected_message = "Tomasz created [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) from `new-branch` to `master` (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_created_or_updated_without_username",
TOPIC_PR_EVENTS,
expected_message,
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
HTTP_X_EVENT_KEY="pullrequest:created",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
expected_message = "Tomasz created [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) from `new-branch` to `master` (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_created_or_updated",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
expected_message,
HTTP_X_EVENT_KEY="pullrequest:created",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_updated_event(self) -> None:
integration: Modify branch names for Bitbucket 2 events. This is a follow up to #24673, we want to modify every webhook events to follow the same pattern and consistency where branch name should only show on opened and merged events.
2023-03-24 23:22:48 +01:00
expected_message = "Tomasz updated [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_created_or_updated",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:updated",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_approved_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz approved [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_approved_or_unapproved",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:approved",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_approved_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz approved [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_approved_or_unapproved",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
expected_message,
HTTP_X_EVENT_KEY="pullrequest:approved",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_unapproved_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz unapproved [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_approved_or_unapproved",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:unapproved",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_declined_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz rejected [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_fulfilled_or_rejected",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:rejected",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_fulfilled_event(self) -> None:
integration: Modify branch names for Bitbucket 2 events. This is a follow up to #24673, we want to modify every webhook events to follow the same pattern and consistency where branch name should only show on opened and merged events.
2023-03-24 23:22:48 +01:00
expected_message = "Tomasz merged [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) from `new-branch` to `master`."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_fulfilled_or_rejected",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:fulfilled",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_created_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz [commented](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_comment_action",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:comment_created",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_comment_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz [commented](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_comment_action",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
expected_message,
HTTP_X_EVENT_KEY="pullrequest:comment_created",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_updated_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz updated a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_comment_action",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:comment_updated",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_comment_updated_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz updated a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_comment_action",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
expected_message,
HTTP_X_EVENT_KEY="pullrequest:comment_updated",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_deleted_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz deleted a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
"pull_request_comment_action",
TOPIC_PR_EVENTS,
expected_message,
HTTP_X_EVENT_KEY="pullrequest:comment_deleted",
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Add bitbucket tests for push, push a lot of commits and force push events.
2016-10-07 17:53:27 +02:00
webhooks/bitbucket2: Support events of type "repo:updated".
2018-04-25 01:36:03 +02:00
def test_bitbucket2_on_repo_updated_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "eeshangarg changed the website of the **new-name** repo to **http://zulipchat.com**.\neeshangarg changed the name of the **new-name** repo from **test-repo** to **new-name**.\neeshangarg changed the language of the **new-name** repo to **python**.\neeshangarg changed the full name of the **new-name** repo from **webhooktest/test-repo** to **webhooktest/new-name**.\neeshangarg changed the description of the **new-name** repo to **Random description.**"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "new-name"
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"repo_updated", expected_topic_name, expected_message, HTTP_X_EVENT_KEY="repo:updated"
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
)
webhooks/bitbucket2: Support events of type "repo:updated".
2018-04-25 01:36:03 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_one_tag_event(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Tomasz pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
)
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
self.check_webhook(
"push_one_tag", TOPIC, expected_message, HTTP_X_EVENT_KEY="pullrequest:push"
)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_remove_tag_event(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Tomasz removed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
)
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
self.check_webhook(
"push_remove_tag", TOPIC, expected_message, HTTP_X_EVENT_KEY="pullrequest:push"
)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_more_than_one_tag_event(self) -> None:
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
expected_message = "Tomasz pushed tag [{name}](https://bitbucket.org/kolaszek/repository-name/commits/tag/{name})."
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
self.subscribe(self.test_user, self.STREAM_NAME)
payload = self.get_body("push_more_than_one_tag")
msg = self.send_webhook_payload(
self.test_user,
self.url,
payload,
content_type="application/json",
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
HTTP_X_EVENT_KEY="pullrequest:push",
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
)
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
msg = self.get_second_to_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC,
content=expected_message.format(name="a"),
)
msg = self.get_last_message()
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC,
content=expected_message.format(name="b"),
)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event(self) -> None:
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
self.subscribe(self.test_user, self.STREAM_NAME)
payload = self.get_body("more_than_one_push_event")
msg = self.send_webhook_payload(
self.test_user,
self.url,
payload,
content_type="application/json",
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
HTTP_X_EVENT_KEY="pullrequest:push",
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
)
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
msg = self.get_second_to_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC_BRANCH_EVENTS,
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
content="Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))",
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
)
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
msg = self.get_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC,
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
content="Tomasz pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a).",
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
self.subscribe(self.test_user, self.STREAM_NAME)
payload = self.get_body("more_than_one_push_event")
msg = self.send_webhook_payload(
self.test_user,
self.url,
payload,
content_type="application/json",
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
HTTP_X_EVENT_KEY="pullrequest:push",
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
)
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
msg = self.get_second_to_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC_BRANCH_EVENTS,
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
content="Tomasz [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n* first commit ([84b96adc644](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))",
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
msg = self.get_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC,
bitbucket2: Format user info consistently. We now use get_user_info() to format all of our users in messages.
2020-09-23 21:17:04 +02:00
content="Tomasz pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a).",
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event_filtered_by_branches_ignore(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="changes,development")
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Tomasz pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
)
test_classes: Type kwargs for client_get and friends. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-12-17 08:14:22 +01:00
self.check_webhook(
"more_than_one_push_event", TOPIC, expected_message, HTTP_X_EVENT_KEY="pullrequest:push"
)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_event_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
docs: Fix spelling errors caught by codespell. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-25 22:54:23 +02:00
self.url = self.build_webhook_url(branches="changes,development")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("push")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_commits_above_limit_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
docs: Fix spelling errors caught by codespell. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-25 22:54:23 +02:00
self.url = self.build_webhook_url(branches="changes,development")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("push_commits_above_limit")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_force_push_event_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
docs: Fix spelling errors caught by codespell. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-25 22:54:23 +02:00
self.url = self.build_webhook_url(branches="changes,development")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("force_push")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_multiple_committers_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
docs: Fix spelling errors caught by codespell. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-25 22:54:23 +02:00
self.url = self.build_webhook_url(branches="changes,development")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("push_multiple_committers")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_multiple_committers_with_others_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
docs: Fix spelling errors caught by codespell. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-25 22:54:23 +02:00
self.url = self.build_webhook_url(branches="changes,development")
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("push_multiple_committers_with_others")
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.webhooks.bitbucket2.view.check_send_webhook_message")
mypy: Final small migrations to python3.5 annotations in many files.
2018-03-12 02:47:49 +01:00
def test_bitbucket2_on_push_without_changes_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
payload = self.get_body("push_without_changes")
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
self.assert_json_success(result)
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
def test_get_user_info(self) -> None:
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
request = HostRequestMock()
request.content_type = "application/json"
request.user = self.test_user
RequestNotes.get_notes(request).client = get_client("test")
self.assertEqual(get_user_info(request, wrap_wild_value("request", {})), "Unknown user")
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
dct = dict(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
nickname="alice",
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
noisy_field="whatever",
display_name="Alice Smith",
)
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
self.assertEqual(get_user_info(request, wrap_wild_value("request", dct)), "Alice Smith")
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
del dct["display_name"]
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
self.assertEqual(get_user_info(request, wrap_wild_value("request", dct)), "alice")
bitbucket2: Simplify how we display user for fork events. Even before GDPR changes, it was strange that we displayed users differently for fork events vs. all other events. After GDPR, we don't even get the `username` field any more. So now we simply use `display_name` if available, and then we try `nickname`. See https://developer.atlassian.com/cloud/bitbucket/bitbucket-api-changes-gdpr/ for more context.
2020-09-23 18:57:33 +02:00
del dct["nickname"]
logging_util: Remove dependence on get_current_request. Pass the HttpRequest explicitly through the two webhooks that log to the webhook loggers. get_current_request is now unused, so remove it (in the same commit for test coverage reasons). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-07-10 22:17:30 +02:00
self.assertEqual(get_user_info(request, wrap_wild_value("request", dct)), "Unknown user")