Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/bitbucket2/tests.py

337 lines
24 KiB
Python
Raw Normal View History

requirements: Drop direct dependency on mock. mock is just a backport of the standard library’s unittest.mock now. The SAMLAuthBackendTest change is needed because MagicMock.call_args.args wasn’t introduced until Python 3.8 (https://bugs.python.org/issue21269). The PROVISION_VERSION bump is skipped because mock is still an indirect dev requirement via moto. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-26 07:16:25 +02:00
from unittest.mock import MagicMock, patch
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC = "Repository name"
TOPIC_PR_EVENTS = "Repository name / PR #1 new commit"
TOPIC_ISSUE_EVENTS = "Repository name / Issue #1 Bug"
TOPIC_BRANCH_EVENTS = "Repository name / master"
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class Bitbucket2HookTests(WebhookTestCase):
STREAM_NAME = 'bitbucket2'
URL_TEMPLATE = "/api/v1/external/bitbucket2?stream={stream}&api_key={api_key}"
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
FIXTURE_DIR_NAME = 'bitbucket2'
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n{commit_info}"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push', TOPIC_BRANCH_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"""kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 3 commits to branch master. Commits by zbenjamin (2) and kolaszek (1).\n\n{commit_info*2}* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_multiple_committers', TOPIC_BRANCH_EVENTS, expected_message)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_with_others(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"""kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 10 commits to branch master. Commits by james (3), Brendon (2), Tomasz (2) and others (3).\n\n{commit_info*9}* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_multiple_committers_with_others', TOPIC_BRANCH_EVENTS, expected_message)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"""kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 3 commits to branch master. Commits by zbenjamin (2) and kolaszek (1).\n\n{commit_info*2}* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_multiple_committers', TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_multiple_committers_with_others_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))\n'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"""kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 10 commits to branch master. Commits by james (3), Brendon (2), Tomasz (2) and others (3).\n\n{commit_info*9}* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))"""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_multiple_committers_with_others', TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_event_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
commit_info = '* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))'
python: Convert "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, but with the NamedTuple changes reverted (see commit ba7906a3c657905fa35bbcfb4e97b053f050272d, #15132). Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-09 00:25:09 +02:00
expected_message = f"kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n{commit_info}"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push', TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_above_limit_event(self) -> None:
git integration: Change push commits message to show url at the end.
2017-03-15 10:15:03 +01:00
commit_info = '* a ([6f161a7](https://bitbucket.org/kolaszek/repository-name/commits/6f161a7bced94430ac8947d87dbf45c6deee3fb0))\n'
python: Convert more "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, with more restrictions patched out. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-10 06:40:53 +02:00
expected_message = f"kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branches/compare/6f161a7bced94430ac8947d87dbf45c6deee3fb0..1221f2fda6f1e3654b09f1f3a08390e4cb25bb48) 5 commits to branch master. Commits by Tomasz (5).\n\n{(commit_info * 5)}[and more commit(s)]"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_commits_above_limit', TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 tests for commits more than limit.
2016-10-07 15:12:51 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_commits_above_limit_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
commit_info = '* a ([6f161a7](https://bitbucket.org/kolaszek/repository-name/commits/6f161a7bced94430ac8947d87dbf45c6deee3fb0))\n'
python: Convert more "".format to Python 3.6 f-strings. Generated by pyupgrade --py36-plus --keep-percent-format, with more restrictions patched out. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-10 06:40:53 +02:00
expected_message = f"kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branches/compare/6f161a7bced94430ac8947d87dbf45c6deee3fb0..1221f2fda6f1e3654b09f1f3a08390e4cb25bb48) 5 commits to branch master. Commits by Tomasz (5).\n\n{(commit_info * 5)}[and more commit(s)]"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_commits_above_limit', TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_force_push_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek [force pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) to branch master. Head is now 25f93d22b719e2d678a7ad5ee0ef0d1fcdf39c12."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('force_push', TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 force push event handler.
2016-10-06 15:32:10 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_force_push_event_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek [force pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) to branch master. Head is now 25f93d22b719e2d678a7ad5ee0ef0d1fcdf39c12."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('force_push', TOPIC_BRANCH_EVENTS, expected_message)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_remove_branch_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek deleted branch master."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('remove_branch', TOPIC_BRANCH_EVENTS, expected_message)
Add bitbucket2 remove branch message handler.
2016-10-06 16:14:51 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_fork_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "User Tomasz(login: kolaszek) forked the repository into [kolaszek/repository-name2](https://bitbucket.org/kolaszek/repository-name2)."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('fork', TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_commit_comment_created_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek [commented](https://bitbucket.org/kolaszek/repository-name/commits/32c4ea19aa3af10acd08e419e2c354941a365d74#comment-3354963) on [32c4ea1](https://bitbucket.org/kolaszek/repository-name/commits/32c4ea19aa3af10acd08e419e2c354941a365d74):\n~~~ quote\nNice fix!\n~~~"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('commit_comment_created', TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_commit_status_changed_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "[System mybuildtool](https://my-build-tool.com/builds/MY-PROJECT/BUILD-777) changed status of [9fec847](https://bitbucket.org/kolaszek/repository-name/commits/9fec847784abb10b2fa567ee63b85bd238955d0e) to SUCCESSFUL."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('commit_status_changed', TOPIC, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_created_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek created [Issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug) (assigned to kolaszek):\n\n~~~ quote\nSuch a bug\n~~~"
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('issue_created', TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_issue_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek created [Issue #1 Bug](https://bitbucket.org/kolaszek/repository-name/issues/2/bug) (assigned to kolaszek):\n\n~~~ quote\nSuch a bug\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue_created', expected_topic, expected_message)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_updated_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek updated [Issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('issue_updated', TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_issue_commented_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek [commented](https://bitbucket.org/kolaszek/repository-name/issues/2#comment-28973596) on [Issue #1](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('issue_commented', TOPIC_ISSUE_EVENTS, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_issue_commented_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek [commented](https://bitbucket.org/kolaszek/repository-name/issues/2#comment-28973596) on [Issue #1 Bug](https://bitbucket.org/kolaszek/repository-name/issues/2/bug)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue_commented', expected_topic, expected_message)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_created_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek created [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) (assigned to tkolek) from `new-branch` to `master`:\n\n~~~ quote\ndescription\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:created',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_created_or_updated', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
def test_bitbucket2_on_pull_request_created_without_reviewer_username_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek created [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) (assigned to Tomasz Kolek) from `new-branch` to `master`:\n\n~~~ quote\ndescription\n~~~"
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:created',
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
}
self.send_and_test_stream_message('pull_request_created_or_updated_without_username',
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC_PR_EVENTS, expected_message, **kwargs)
webhooks/bitbucket2: Account for missing username in PR payloads. Certain PR payloads do not have a username for the reviewer, in such cases, we just return the reviewer's nickname or display name.
2019-06-22 21:45:15 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek created [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) (assigned to tkolek) from `new-branch` to `master`:\n\n~~~ quote\ndescription\n~~~"
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:created',
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
}
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_created_or_updated', expected_topic, expected_message, **kwargs)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_updated_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek updated [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1) (assigned to tkolek) from `new-branch` to `master`:\n\n~~~ quote\ndescription\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:updated',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_created_or_updated', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_approved_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek approved [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:approved',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_approved_or_unapproved', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_approved_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek approved [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:approved',
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
}
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_approved_or_unapproved', expected_topic, expected_message, **kwargs)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_unapproved_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek unapproved [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:unapproved',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_approved_or_unapproved', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_declined_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek rejected [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:rejected',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_fulfilled_or_rejected', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_fulfilled_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek merged [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:fulfilled',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_fulfilled_or_rejected', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_created_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek [commented](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:comment_created',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_comment_action', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_comment_created_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek [commented](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:comment_created',
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
}
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_comment_action', expected_topic, expected_message, **kwargs)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_updated_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek updated a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:comment_updated',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_comment_action', TOPIC_PR_EVENTS, expected_message, **kwargs)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
def test_bitbucket2_on_pull_request_comment_updated_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic="notifications")
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_topic = "notifications"
expected_message = "kolaszek updated a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1 new commit](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:comment_updated',
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
}
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_comment_action', expected_topic, expected_message, **kwargs)
webhooks/bitbucket2: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a BitBucket integration are grouped under one user specified topic (specified in the URL), we should include the title of the PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-25 00:57:45 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_pull_request_comment_deleted_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek deleted a [comment](https://bitbucket.org/kolaszek/repository-name/pull-requests/3/_/diff#comment-20576503) on [PR #1](https://bitbucket.org/kolaszek/repository-name/pull-requests/3):\n\n~~~ quote\nComment1\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:comment_deleted',
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('pull_request_comment_action', TOPIC_PR_EVENTS, expected_message, **kwargs)
Add bitbucket tests for push, push a lot of commits and force push events.
2016-10-07 17:53:27 +02:00
webhooks/bitbucket2: Support events of type "repo:updated".
2018-04-25 01:36:03 +02:00
def test_bitbucket2_on_repo_updated_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "eeshangarg changed the website of the **new-name** repo to **http://zulipchat.com**.\neeshangarg changed the name of the **new-name** repo from **test-repo** to **new-name**.\neeshangarg changed the language of the **new-name** repo to **python**.\neeshangarg changed the full name of the **new-name** repo from **webhooktest/test-repo** to **webhooktest/new-name**.\neeshangarg changed the description of the **new-name** repo to **Random description.**"
expected_topic = "new-name"
webhooks/bitbucket2: Support events of type "repo:updated".
2018-04-25 01:36:03 +02:00
kwargs = {"HTTP_X_EVENT_KEY": 'repo:updated'}
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('repo_updated', expected_topic,
webhooks/bitbucket2: Support events of type "repo:updated".
2018-04-25 01:36:03 +02:00
expected_message, **kwargs)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_one_tag_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_one_tag', TOPIC, expected_message, **kwargs)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_remove_tag_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek removed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
}
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.send_and_test_stream_message('push_remove_tag', TOPIC, expected_message, **kwargs)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_push_more_than_one_tag_event(self) -> None:
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek pushed tag [{name}](https://bitbucket.org/kolaszek/repository-name/commits/tag/{name})."
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
}
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
self.send_and_test_stream_message('push_more_than_one_tag', **kwargs)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
msg = self.get_last_message()
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
self.do_test_message(msg, expected_message.format(name='b'))
msg = self.get_second_to_last_message()
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC)
Normalize pushing tags event messages in Bitbucket2 integration.
2016-11-09 16:05:45 +01:00
self.do_test_message(msg, expected_message.format(name='a'))
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event(self) -> None:
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
}
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
self.send_and_test_stream_message('more_than_one_push_event', **kwargs)
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
msg = self.get_second_to_last_message()
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
self.do_test_message(msg, 'kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))')
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC_BRANCH_EVENTS)
Add handling multiple push info in one request to Bitbucket2 integration.
2016-11-11 13:32:41 +01:00
msg = self.get_last_message()
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
self.do_test_message(msg, 'kolaszek pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a).')
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event_filtered_by_branches(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='master,development')
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
}
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
self.send_and_test_stream_message('more_than_one_push_event', **kwargs)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
msg = self.get_second_to_last_message()
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
self.do_test_message(msg, 'kolaszek [pushed](https://bitbucket.org/kolaszek/repository-name/branch/master) 1 commit to branch master.\n\n* first commit ([84b96ad](https://bitbucket.org/kolaszek/repository-name/commits/84b96adc644a30fd6465b3d196369d880762afed))')
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC_BRANCH_EVENTS)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
msg = self.get_last_message()
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
self.do_test_message(msg, 'kolaszek pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a).')
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
self.do_test_topic(msg, TOPIC)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_bitbucket2_on_more_than_one_push_event_filtered_by_branches_ignore(self) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,development')
kwargs = {
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
"HTTP_X_EVENT_KEY": 'pullrequest:push',
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
}
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "kolaszek pushed tag [a](https://bitbucket.org/kolaszek/repository-name/commits/tag/a)."
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
self.send_and_test_stream_message('more_than_one_push_event',
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC,
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
expected_message, **kwargs)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_event_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,devlopment')
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
payload = self.get_body('push')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_commits_above_limit_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,devlopment')
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
payload = self.get_body('push_commits_above_limit')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_force_push_event_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,devlopment')
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
payload = self.get_body('force_push')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_multiple_committers_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,devlopment')
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
payload = self.get_body('push_multiple_committers')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
def test_bitbucket2_on_push_multiple_committers_with_others_filtered_by_branches_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.url = self.build_webhook_url(branches='changes,devlopment')
webhooks: Move all fixtures to zerver/webhooks/<webhook_name>/fixtures. All webhook fixtures in zerver/fixtures/<webhook_name> have now been moved to dedicated webhook-specific directories under zerver/webhooks/<webhook_name>/fixtures, where <webhook_name> is the name of the webhook.
2017-04-27 21:19:05 +02:00
payload = self.get_body('push_multiple_committers_with_others')
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Filter specific BitBucket Git branches. This is the last of the Git integrations that didn't have this feature. Fixes #4327.
2017-04-05 02:52:31 +02:00
self.assert_json_success(result)
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
@patch('zerver.webhooks.bitbucket2.view.check_send_webhook_message')
mypy: Final small migrations to python3.5 annotations in many files.
2018-03-12 02:47:49 +01:00
def test_bitbucket2_on_push_without_changes_ignore(
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
payload = self.get_body('push_without_changes')
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/bitbucket2: Ignore push events with no changes. We now ignore payloads where payload['push']['changes'] is empty, because an empty push doesn't really convey any useful information. I couldn't find a way to replicate the action that would generate such a payload, so I took one of our existing payloads and editted out payload['push']['changes'] myself, so this payload is not authentic.
2017-11-27 01:03:52 +01:00
self.assert_json_success(result)