Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/settings/image_upload_widget.hbs

23 lines
1.1 KiB
Handlebars
Raw Normal View History

settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
<div id ="{{widget}}-upload-widget" class="inline-block avatar-icon-logo-settings">
{{#if is_editable_by_current_user}}
user avatar: Rename and convert "#user-settings-avatar". Renaming "user-settings-avatar" to "image_upload_button" since the `user-settings-avatar` name is irrelevant/confusing for the upload button, and converting the id into a class so that we could just have only one outer id.
2020-06-13 06:27:28 +02:00
<div class="image_upload_button">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
<div class="settings-page-image-background"></div>
user avatar: Remove user_avatar_delete_button id. we can remove `user_avatar_delete_button` id and access delete button from `#user-avatar-upload-widget .settings-page-delete-button` so that we can have only one id at top level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-13 08:12:47 +02:00
<span class="settings-page-delete-button" aria-label="{{t delete_text }}" role="button" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
&times;
</span>
user avatar: Remove `user_avatar_delete` id. We can remove id="user_avatar_delete" and access delete-text from `#user-avatar-upload-widget .settings-page-delete-text` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-14 07:07:38 +02:00
<span class="settings-page-delete-text" aria-label="{{t delete_text }}" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
{{t delete_text }}
</span>
user avatar: Remove `user_avatar_upload_button` id. The upload text element is wrongly named as id=user_avatar_upload_button. now we can remove that id and access upload text element from `#user-avatar-upload-widget .settings-page-upload-text` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 06:37:57 +02:00
<span class="settings-page-upload-text" aria-label="{{t upload_text }}" role="button" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
{{t upload_text }}
</span>
user avatar: Remove `avatar-spinner-background` id. Now we can remove the id `avatar-spinner-background` and access spinner element from `#user-avatar-upload-widget .settings-page-upload-text` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 06:48:41 +02:00
<span class="upload-spinner-background">
user avatar: Remove `avatar-spinner-background` id. Now we can remove the id `avatar-spinner-background` and access spinner element from `#user-avatar-upload-widget .image_upload_spinner` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 07:18:39 +02:00
<object class="image_upload_spinner" type="image/svg+xml" data="/static/images/tail-spin.svg"></object>
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
</span>
</div>
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
{{/if}}
user avatar: Remove `image-block` id. Now we can remove `user-avatar-block` id and add common class `image_block`. we can access this class using `#user-avatar-upload-widget .image_block` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 07:38:56 +02:00
<img class="image-block" src="{{ image }}"/>
user avatar: Remove `user_avatar_file_input` id. Now we can remove `user-avatar-block` id and added new class 'image_file_input'.we can access this class using `#user-avatar-upload-widget .image_file_input` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 07:59:13 +02:00
<input type="file" name="file_input" class="notvisible image_file_input" value="{{t upload_text }}" />
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
<div id="user_avatar_file_input_error" class="text-error"></div>
</div>