Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/settings/image_upload_widget.hbs

23 lines
1.3 KiB
Handlebars
Raw Normal View History

settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
<div id ="{{widget}}-upload-widget" class="inline-block avatar-icon-logo-settings">
{{#if is_editable_by_current_user}}
<div id="user-settings-avatar">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
<div class="settings-page-image-background"></div>
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
<span id="user_avatar_delete_button" class="settings-page-delete-button" aria-label="{{t 'Delete profile picture'}}" role="button" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
&times;
</span>
<span id="user_avatar_delete" class="settings-page-delete-text" aria-label="{{t 'Delete profile picture'}}" tabindex="0">
{{t delete_text }}
</span>
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
<span id="user_avatar_upload_button" class="settings-page-upload-text" aria-label="{{t 'Upload new profile picture'}}" role="button" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
{{t upload_text }}
</span>
<span id="avatar-spinner-background" class="upload-spinner-background">
<object id="user-avatar-spinner" type="image/svg+xml" data="/static/images/tail-spin.svg"></object>
</span>
</div>
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
{{/if}}
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
<img id="user-avatar-block" src="{{ image }}"/>
<input type="file" name="user_avatar_file_input" class="notvisible" id="user_avatar_file_input" value="{{t 'Upload profile picture' }}" />
<div id="user_avatar_file_input_error" class="text-error"></div>
</div>