2021-02-20 05:52:06 +01:00
|
|
|
import {strict as assert} from "assert";
|
2020-08-01 03:43:15 +02:00
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
import type {ElementHandle, Page} from "puppeteer";
|
2020-07-07 18:19:41 +02:00
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
import common from "../puppeteer_lib/common";
|
2020-07-07 18:19:41 +02:00
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function user_row_selector(page: Page, name: string): Promise<string> {
|
2020-07-07 18:19:41 +02:00
|
|
|
const user_id = await common.get_user_id_from_name(page, name);
|
2022-02-08 18:56:40 +01:00
|
|
|
const selector = `.remove_potential_subscriber[data-user-id="${user_id}"]`;
|
|
|
|
return selector;
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function await_user_visible(page: Page, name: string): Promise<void> {
|
|
|
|
const selector = await user_row_selector(page, name);
|
|
|
|
await page.waitForSelector(selector, {visible: true});
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function await_user_hidden(page: Page, name: string): Promise<void> {
|
|
|
|
const selector = await user_row_selector(page, name);
|
|
|
|
await page.waitForSelector(selector, {hidden: true});
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function add_user_to_stream(page: Page, name: string): Promise<void> {
|
|
|
|
const user_id = await common.get_user_id_from_name(page, name);
|
|
|
|
await page.evaluate(
|
|
|
|
(user_id: Number) => zulip_test.add_user_id_to_new_stream(user_id),
|
|
|
|
user_id,
|
2020-07-07 18:19:41 +02:00
|
|
|
);
|
2022-02-08 18:56:40 +01:00
|
|
|
await await_user_visible(page, name);
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function stream_name_error(page: Page): Promise<string> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForSelector("#stream_name_error", {visible: true});
|
|
|
|
return await common.get_text_from_selector(page, "#stream_name_error");
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function open_streams_modal(page: Page): Promise<void> {
|
2021-03-31 08:57:11 +02:00
|
|
|
const all_streams_selector = "#add-stream-link";
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForSelector(all_streams_selector, {visible: true});
|
|
|
|
await page.click(all_streams_selector);
|
|
|
|
|
|
|
|
await page.waitForSelector("#subscription_overlay.new-style", {visible: true});
|
2021-03-01 06:38:03 +01:00
|
|
|
const url = await common.page_url_with_fragment(page);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(url.includes("#streams/all"));
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2022-02-09 18:37:45 +01:00
|
|
|
async function test_subscription_button(page: Page): Promise<void> {
|
|
|
|
const stream_selector = "[data-stream-name='Venice']";
|
|
|
|
const button_selector = `${stream_selector} .sub_unsub_button`;
|
2021-02-18 15:54:19 +01:00
|
|
|
const subscribed_selector = `${button_selector}.checked`;
|
|
|
|
const unsubscribed_selector = `${button_selector}:not(.checked)`;
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function subscribed(): Promise<ElementHandle | null> {
|
2021-02-18 15:54:19 +01:00
|
|
|
return await page.waitForSelector(subscribed_selector, {visible: true});
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function unsubscribed(): Promise<ElementHandle | null> {
|
2021-02-18 15:54:19 +01:00
|
|
|
return await page.waitForSelector(unsubscribed_selector, {visible: true});
|
|
|
|
}
|
|
|
|
|
2022-02-09 18:37:45 +01:00
|
|
|
// Make sure that Venice is even in our list of streams.
|
|
|
|
await page.waitForSelector(stream_selector, {visible: true});
|
|
|
|
await page.waitForSelector(button_selector, {visible: true});
|
|
|
|
|
2021-02-18 15:54:19 +01:00
|
|
|
// Note that we intentionally re-find the button after each click, since
|
|
|
|
// the live-update code may replace the whole row.
|
|
|
|
let button;
|
|
|
|
|
2022-02-09 18:37:45 +01:00
|
|
|
// We assume Venice is already subscribed, so the first line here
|
2021-02-18 15:54:19 +01:00
|
|
|
// should happen immediately.
|
|
|
|
button = await subscribed();
|
2021-09-22 22:52:53 +02:00
|
|
|
await button!.click();
|
2021-02-18 15:54:19 +01:00
|
|
|
button = await unsubscribed();
|
2021-09-22 22:52:53 +02:00
|
|
|
await button!.click();
|
2021-02-18 15:54:19 +01:00
|
|
|
button = await subscribed();
|
2021-09-22 22:52:53 +02:00
|
|
|
await button!.click();
|
2021-02-18 15:54:19 +01:00
|
|
|
button = await unsubscribed();
|
2021-09-22 22:52:53 +02:00
|
|
|
await button!.click();
|
2021-02-18 15:54:19 +01:00
|
|
|
button = await subscribed();
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function click_create_new_stream(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.click("#add_new_subscription .create_stream_button");
|
2022-03-18 15:24:39 +01:00
|
|
|
await page.waitForSelector(".finalize_create_stream", {visible: true});
|
|
|
|
|
|
|
|
// sanity check that desdemona is the initial subsscriber
|
2022-02-08 18:56:40 +01:00
|
|
|
await await_user_visible(page, "desdemona");
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function clear_ot_filter_with_backspace(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.click(".add-user-list-filter");
|
|
|
|
await page.keyboard.press("Backspace");
|
|
|
|
await page.keyboard.press("Backspace");
|
|
|
|
}
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
async function test_user_filter_ui(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForSelector("form#stream_creation_form", {visible: true});
|
2022-02-08 18:56:40 +01:00
|
|
|
// Desdemona should be there by default
|
|
|
|
await await_user_visible(page, "desdemona");
|
|
|
|
|
|
|
|
await add_user_to_stream(page, "cordelia");
|
|
|
|
await add_user_to_stream(page, "othello");
|
2020-07-07 18:19:41 +02:00
|
|
|
|
2021-05-11 15:14:51 +02:00
|
|
|
await page.type(`form#stream_creation_form [name="user_list_filter"]`, "ot", {delay: 100});
|
2022-02-08 18:56:40 +01:00
|
|
|
await page.waitForSelector("#create_stream_subscribers", {visible: true});
|
2021-05-11 15:14:51 +02:00
|
|
|
// Wait until filtering is completed.
|
|
|
|
await page.waitForFunction(
|
2022-02-08 18:56:40 +01:00
|
|
|
() =>
|
|
|
|
document.querySelectorAll("#create_stream_subscribers .remove_potential_subscriber")
|
|
|
|
.length === 1,
|
2021-05-11 15:14:51 +02:00
|
|
|
);
|
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
await await_user_hidden(page, "cordelia");
|
|
|
|
await await_user_hidden(page, "desdemona");
|
|
|
|
await await_user_visible(page, "othello");
|
2020-07-07 18:19:41 +02:00
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
// Clear the filter.
|
2020-07-07 18:19:41 +02:00
|
|
|
await clear_ot_filter_with_backspace(page);
|
2022-02-08 18:56:40 +01:00
|
|
|
|
|
|
|
await await_user_visible(page, "cordelia");
|
|
|
|
await await_user_visible(page, "desdemona");
|
|
|
|
await await_user_visible(page, "othello");
|
2020-07-07 18:19:41 +02:00
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function create_stream(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForXPath('//*[text()="Create stream"]', {visible: true});
|
|
|
|
await common.fill_form(page, "form#stream_creation_form", {
|
|
|
|
stream_name: "Puppeteer",
|
2020-10-23 02:43:28 +02:00
|
|
|
stream_description: "Everything Puppeteer",
|
2020-07-07 18:19:41 +02:00
|
|
|
});
|
2022-02-15 21:16:10 +01:00
|
|
|
await page.click("form#stream_creation_form .finalize_create_stream");
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForFunction(() => $(".stream-name").is(':contains("Puppeteer")'));
|
|
|
|
const stream_name = await common.get_text_from_selector(
|
|
|
|
page,
|
2021-07-05 11:26:23 +02:00
|
|
|
".stream-header .stream-name .sub-stream-name",
|
2020-07-07 18:19:41 +02:00
|
|
|
);
|
|
|
|
const stream_description = await common.get_text_from_selector(
|
|
|
|
page,
|
2021-07-05 11:26:23 +02:00
|
|
|
".stream-description .sub-stream-description",
|
2020-07-07 18:19:41 +02:00
|
|
|
);
|
|
|
|
const subscriber_count_selector = "[data-stream-name='Puppeteer'] .subscriber-count";
|
|
|
|
assert.strictEqual(stream_name, "Puppeteer");
|
2020-10-23 02:43:28 +02:00
|
|
|
assert.strictEqual(stream_description, "Everything Puppeteer");
|
2020-07-07 18:19:41 +02:00
|
|
|
|
2022-02-08 18:56:40 +01:00
|
|
|
// Assert subscriber count becomes 3 (cordelia, desdemona, othello)
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.waitForFunction(
|
2022-02-08 18:56:40 +01:00
|
|
|
(subscriber_count_selector: string) => $(subscriber_count_selector).text().trim() === "3",
|
2020-07-07 18:19:41 +02:00
|
|
|
{},
|
|
|
|
subscriber_count_selector,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function test_streams_with_empty_names_cannot_be_created(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await page.click("#add_new_subscription .create_stream_button");
|
|
|
|
await page.waitForSelector("form#stream_creation_form", {visible: true});
|
|
|
|
await common.fill_form(page, "form#stream_creation_form", {stream_name: " "});
|
2022-02-08 18:56:40 +01:00
|
|
|
await page.click("form#stream_creation_form button.finalize_create_stream");
|
2020-07-07 18:19:41 +02:00
|
|
|
assert.strictEqual(await stream_name_error(page), "A stream needs to have a name");
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function test_streams_with_duplicate_names_cannot_be_created(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await common.fill_form(page, "form#stream_creation_form", {stream_name: "Puppeteer"});
|
2022-02-08 18:56:40 +01:00
|
|
|
await page.click("form#stream_creation_form button.finalize_create_stream");
|
2020-07-07 18:19:41 +02:00
|
|
|
assert.strictEqual(await stream_name_error(page), "A stream with this name already exists");
|
|
|
|
|
|
|
|
const cancel_button_selector = "form#stream_creation_form button.button.white";
|
|
|
|
await page.click(cancel_button_selector);
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function test_stream_creation(page: Page): Promise<void> {
|
2022-02-08 18:56:40 +01:00
|
|
|
await click_create_new_stream(page);
|
|
|
|
await test_user_filter_ui(page);
|
2020-07-07 18:19:41 +02:00
|
|
|
await create_stream(page);
|
|
|
|
await test_streams_with_empty_names_cannot_be_created(page);
|
|
|
|
await test_streams_with_duplicate_names_cannot_be_created(page);
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function test_streams_search_feature(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
assert.strictEqual(await common.get_text_from_selector(page, "#search_stream_name"), "");
|
|
|
|
const hidden_streams_selector = ".stream-row.notdisplayed .stream-name";
|
|
|
|
assert.strictEqual(
|
|
|
|
await common.get_text_from_selector(
|
|
|
|
page,
|
|
|
|
'.stream-row[data-stream-name="Verona"] .stream-name',
|
|
|
|
),
|
|
|
|
"Verona",
|
|
|
|
);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(
|
2020-07-07 18:19:41 +02:00
|
|
|
!(await common.get_text_from_selector(page, hidden_streams_selector)).includes("Verona"),
|
|
|
|
"#Verona is hidden",
|
|
|
|
);
|
|
|
|
|
|
|
|
await page.type('#stream_filter input[type="text"]', "Puppeteer");
|
2021-04-29 17:22:48 +02:00
|
|
|
await page.waitForSelector(".stream-row[data-stream-name='core team']", {hidden: true});
|
2020-07-07 18:19:41 +02:00
|
|
|
assert.strictEqual(
|
|
|
|
await common.get_text_from_selector(page, ".stream-row:not(.notdisplayed) .stream-name"),
|
|
|
|
"Puppeteer",
|
|
|
|
);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(
|
2020-07-07 18:19:41 +02:00
|
|
|
(await common.get_text_from_selector(page, hidden_streams_selector)).includes("Verona"),
|
|
|
|
"#Verona is not hidden",
|
|
|
|
);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(
|
2020-07-07 18:19:41 +02:00
|
|
|
!(await common.get_text_from_selector(page, hidden_streams_selector)).includes("Puppeteer"),
|
|
|
|
"Puppeteer is hidden after searching.",
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-02-20 05:52:06 +01:00
|
|
|
async function subscriptions_tests(page: Page): Promise<void> {
|
2020-07-07 18:19:41 +02:00
|
|
|
await common.log_in(page);
|
|
|
|
await open_streams_modal(page);
|
2022-02-09 18:37:45 +01:00
|
|
|
await test_subscription_button(page);
|
2020-07-07 18:19:41 +02:00
|
|
|
await test_stream_creation(page);
|
|
|
|
await test_streams_search_feature(page);
|
|
|
|
}
|
|
|
|
|
|
|
|
common.run_test(subscriptions_tests);
|