Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer: Make subscribe/unsubscribe test more robust. 

We generally want to avoid clicking on DOM elements
that may not actually be visible due to the prior
operation.  Instead, we can just find the visible
element after each step.

I also introduce a couple helper functions to
de-clutter the click/unclick/click steps, and I do
a couple extra clicks for good measure.

You can verify that the test will fail if you
add an early return to update_check_button_for_sub.
This commit is contained in:
Steve Howell 2021-02-18 14:54:19 +00:00 committed by Steve Howell
parent ca0b01033d
commit b4ab662442
1 changed files with 27 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
frontend_tests/puppeteer_tests/04-subscriptions.js
View File

@ -47,17 +47,33 @@ async function open_streams_modal(page) {
}
async function test_subscription_button_verona_stream(page) {
const verona_subscribed_selector = "[data-stream-name='Verona'] .sub_unsub_button.checked";
const verona_unsubscribed_selector =
"[data-stream-name='Verona'] .sub_unsub_button:not(.checked)";
// assert it's already checked.
await page.waitForSelector(verona_subscribed_selector, {visible: true});
// get subscribe/unsubscribe button element.
const subscription_checkmark = await page.$("[data-stream-name='Verona'] .sub_unsub_button");
await subscription_checkmark.click(); // Unsubscribe.
await page.waitForSelector(verona_unsubscribed_selector); // Unsubscribed.
await subscription_checkmark.click(); // Subscribe again now.
await page.waitForSelector(verona_subscribed_selector, {visible: true}); // Subscribed.
const button_selector = "[data-stream-name='Verona'] .sub_unsub_button";
const subscribed_selector = `${button_selector}.checked`;
const unsubscribed_selector = `${button_selector}:not(.checked)`;
async function subscribed() {
return await page.waitForSelector(subscribed_selector, {visible: true});
}
async function unsubscribed() {
return await page.waitForSelector(unsubscribed_selector, {visible: true});
}
// Note that we intentionally re-find the button after each click, since
// the live-update code may replace the whole row.
let button;
// We assume Verona is already subscribed, so the first line here
// should happen immediately.
button = await subscribed();
button.click();
button = await unsubscribed();
button.click();
button = await subscribed();
button.click();
button = await unsubscribed();
button.click();
button = await subscribed();
}
async function click_create_new_stream(page, cordelia_checkbox, othello_checkbox) {