Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/jira/tests.py

208 lines
10 KiB
Python
Raw Normal View History

Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
# -*- coding: utf-8 -*-
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
webhooks/jira: Decode stream name on our end. Recently, one of our users reported that a JIRA webhook was not able to send messages to a stream with a space character in its name. Turns out that JIRA does something weird with webhook URLs, such that escaped space characters (%20) are escaped again, so that when the request gets to Zulip, the double escaped %20 is evaluated as the literal characters `%20`, and not as a space. We fix this by unescaping the stream name on our end before sending the message forward!
2018-11-06 17:07:04 +01:00
from urllib.parse import quote, unquote
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
users: Get all API keys via wrapper method. Now reading API keys from a user is done with the get_api_key wrapper method, rather than directly fetching it from the user object. Also, every place where an action should be done for each API key is now using get_all_api_keys. This method returns for the moment a single-item list, containing the specified user's API key. This commit is the first step towards allowing users have multiple API keys.
2018-08-01 10:53:40 +02:00
from zerver.lib.users import get_api_key
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class JiraHookTests(WebhookTestCase):
STREAM_NAME = 'jira'
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
URL_TEMPLATE = u"/api/v1/external/jira?api_key={api_key}&stream={stream}"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_custom_stream(self) -> None:
users: Get all API keys via wrapper method. Now reading API keys from a user is done with the get_api_key wrapper method, rather than directly fetching it from the user object. Also, every place where an action should be done for each API key is now using get_all_api_keys. This method returns for the moment a single-item list, containing the specified user's API key. This commit is the first step towards allowing users have multiple API keys.
2018-08-01 10:53:40 +02:00
api_key = get_api_key(self.test_user)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
url = "/api/v1/external/jira?api_key=%s&stream=jira_custom" % (api_key,)
tests: Clean up subscribing from webhook tests.
2017-08-25 06:37:47 +02:00
msg = self.send_json_payload(self.test_user,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
url,
Add support for old Jira API's version to Jira integration.
2017-01-30 19:26:48 +01:00
self.get_body('created_v2'),
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
stream_name="jira_custom",
content_type="application/json")
self.assertEqual(msg.topic_name(), "BUG-15: New bug with hook")
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi created [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
self.assertEqual(msg.content, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_created(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi created [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('created_v1', expected_topic, expected_message)
self.send_and_test_stream_message('created_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Decode stream name on our end. Recently, one of our users reported that a JIRA webhook was not able to send messages to a stream with a space character in its name. Turns out that JIRA does something weird with webhook URLs, such that escaped space characters (%20) are escaped again, so that when the request gets to Zulip, the double escaped %20 is evaluated as the literal characters `%20`, and not as a space. We fix this by unescaping the stream name on our end before sending the message forward!
2018-11-06 17:07:04 +01:00
def test_created_with_stream_with_spaces_escaped(self) -> None:
self.STREAM_NAME = quote('jira alerts')
self.url = self.build_webhook_url()
self.subscribe(self.test_user, unquote(self.STREAM_NAME))
payload = self.get_body('created_v1')
result = self.client_post(self.url, payload, content_type='application/json')
self.assert_json_success(result)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi created [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15):
webhooks/jira: Decode stream name on our end. Recently, one of our users reported that a JIRA webhook was not able to send messages to a stream with a space character in its name. Turns out that JIRA does something weird with webhook URLs, such that escaped space characters (%20) are escaped again, so that when the request gets to Zulip, the double escaped %20 is evaluated as the literal characters `%20`, and not as a space. We fix this by unescaping the stream name on our end before sending the message forward!
2018-11-06 17:07:04 +01:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
webhooks/jira: Test double-escaped stream names with spaces. A recent change to check_send_webhook_message allows webhooks to unescape stream names before sending a message. This commit adds a test for the edge case where the webhook URL is escaped twice by a third-party.
2018-11-07 01:14:21 +01:00
msg = self.get_last_message()
self.assertEqual(msg.content, expected_message)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.assertEqual(msg.topic_name(), expected_topic)
webhooks/jira: Test double-escaped stream names with spaces. A recent change to check_send_webhook_message allows webhooks to unescape stream names before sending a message. This commit adds a test for the edge case where the webhook URL is escaped twice by a third-party.
2018-11-07 01:14:21 +01:00
def test_created_with_stream_with_spaces_double_escaped(self) -> None:
self.STREAM_NAME = quote(quote('jira alerts'))
self.url = self.build_webhook_url()
self.subscribe(self.test_user, unquote(unquote(self.STREAM_NAME)))
payload = self.get_body('created_v1')
result = self.client_post(self.url, payload, content_type='application/json')
self.assert_json_success(result)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi created [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15):
webhooks/jira: Test double-escaped stream names with spaces. A recent change to check_send_webhook_message allows webhooks to unescape stream names before sending a message. This commit adds a test for the edge case where the webhook URL is escaped twice by a third-party.
2018-11-07 01:14:21 +01:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
webhooks/jira: Decode stream name on our end. Recently, one of our users reported that a JIRA webhook was not able to send messages to a stream with a space character in its name. Turns out that JIRA does something weird with webhook URLs, such that escaped space characters (%20) are escaped again, so that when the request gets to Zulip, the double escaped %20 is evaluated as the literal characters `%20`, and not as a space. We fix this by unescaping the stream name on our end before sending the message forward!
2018-11-06 17:07:04 +01:00
msg = self.get_last_message()
self.assertEqual(msg.content, expected_message)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.assertEqual(msg.topic_name(), expected_topic)
webhooks/jira: Decode stream name on our end. Recently, one of our users reported that a JIRA webhook was not able to send messages to a stream with a space character in its name. Turns out that JIRA does something weird with webhook URLs, such that escaped space characters (%20) are escaped again, so that when the request gets to Zulip, the double escaped %20 is evaluated as the literal characters `%20`, and not as a space. We fix this by unescaping the stream name on our end before sending the message forward!
2018-11-06 17:07:04 +01:00
webhooks/jira: Decode topics on our end. The problem addressed in 006e47198c5db5e6dd40170100f1831b7114dc18 resurfaces with topics when a user provides a custom topic in the webhook URL.
2018-12-04 01:59:39 +01:00
def test_created_with_topic_with_spaces_double_escaped(self) -> None:
self.url = self.build_webhook_url(topic=quote(quote('alerts test')))
expected_topic = "alerts test"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi created [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15):
webhooks/jira: Decode topics on our end. The problem addressed in 006e47198c5db5e6dd40170100f1831b7114dc18 resurfaces with topics when a user provides a custom topic in the webhook URL.
2018-12-04 01:59:39 +01:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
webhooks/jira: Decode topics on our end. The problem addressed in 006e47198c5db5e6dd40170100f1831b7114dc18 resurfaces with topics when a user provides a custom topic in the webhook URL.
2018-12-04 01:59:39 +01:00
self.send_and_test_stream_message('created_v1', expected_topic, expected_message)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_created_with_unicode(self) -> None:
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
expected_topic = u"BUG-15: New bug with à hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchià created [BUG-15: New bug with à hook](http://lfranchi.com:8080/browse/BUG-15):
jira integration: Add support for unicode chars. Fixes: #3967
2017-03-15 21:23:51 +01:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: no one
""".strip()
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
self.send_and_test_stream_message('created_with_unicode_v1', expected_topic, expected_message)
self.send_and_test_stream_message('created_with_unicode_v2', expected_topic, expected_message)
jira integration: Add support for unicode chars. Fixes: #3967
2017-03-15 21:23:51 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_created_assignee(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "TEST-4: Test Created Assignee"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leonardo Franchi [Administrator] created [TEST-4: Test Created Assignee](https://zulipp.atlassian.net/browse/TEST-4):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
* **Priority**: Major
* **Assignee**: Leonardo Franchi [Administrator]
""".strip()
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('created_assignee_v1', expected_topic, expected_message)
self.send_and_test_stream_message('created_assignee_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_commented(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi commented on [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15) (assigned to **Othello, the Moor of Venice**):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
``` quote
Adding a comment. Oh, what a comment it is!
```
""".strip()
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('commented_v1', expected_topic, expected_message)
self.send_and_test_stream_message('commented_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/jira: Fix markup conversion of full links. This commit modifies the regex used when parsing JIRA's full links of the form `[text|link]` so that if you have two in a message, Zulip markup conversion doesn't think that the first link extends to the closing `]` of the second link.
2019-05-23 10:17:17 +02:00
def test_commented_with_two_full_links(self) -> None:
expected_topic = "BUG-15: New bug with hook"
expected_message = """
Leo Franchi commented on [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15) (assigned to **Othello, the Moor of Venice**):
``` quote
This is the [first link](https://google.com) and this is the [second link](https://google.com) and this is the end.
```
""".strip()
self.send_and_test_stream_message('commented_v2_with_two_full_links', expected_topic, expected_message)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_comment_edited(self) -> None:
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """
Leo Franchi edited a comment on [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15) (assigned to **Othello, the Moor of Venice**):
Change way of handling comments event in jira integration.
2017-01-03 18:44:13 +01:00
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
``` quote
Adding a comment. Oh, what a comment it is!
```
""".strip()
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
self.send_and_test_stream_message('comment_edited_v2', expected_topic, expected_message)
Change way of handling comments event in jira integration.
2017-01-03 18:44:13 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_comment_deleted(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "TOM-1: New Issue"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = "Tomasz Kolek deleted a comment from [TOM-1: New Issue](https://zuliptomek.atlassian.net/browse/TOM-1) (assigned to **kolaszek@go2.pl**)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('comment_deleted_v2', expected_topic, expected_message)
Change way of handling comments event in jira integration.
2017-01-03 18:44:13 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_commented_markup(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "TEST-7: Testing of rich text"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """Leonardo Franchi [Administrator] commented on [TEST-7: Testing of rich text](https://zulipp.atlassian.net/browse/TEST-7):\n\n``` quote\nThis is a comment that likes to **exercise** a lot of _different_ `conventions` that `jira uses`.\r\n\r\n~~~\n\r\nthis code is not highlighted, but monospaced\r\n\n~~~\r\n\r\n~~~\n\r\ndef python():\r\n print "likes to be formatted"\r\n\n~~~\r\n\r\n[http://www.google.com](http://www.google.com) is a bare link, and [Google](http://www.google.com) is given a title.\r\n\r\nThanks!\r\n\r\n~~~ quote\n\r\nSomeone said somewhere\r\n\n~~~\n```"""
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('commented_markup_v1', expected_topic, expected_message)
self.send_and_test_stream_message('commented_markup_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_deleted(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = "Leo Franchi deleted [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('deleted_v1', expected_topic, expected_message)
self.send_and_test_stream_message('deleted_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_reassigned(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "BUG-15: New bug with hook"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """Leo Franchi updated [BUG-15: New bug with hook](http://lfranchi.com:8080/browse/BUG-15) (assigned to **Othello, the Moor of Venice**):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
messages: Strip trailing whitespace in message contents. I dug into why we never did this before, and it turns out we did, but using `$.trim()` (which removes leading whitespace as well!). When removing the `$.trim()` usage. Fixes #3294.
2017-02-12 04:22:13 +01:00
* Changed assignee to **Othello, the Moor of Venice**"""
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('reassigned_v1', expected_topic, expected_message)
self.send_and_test_stream_message('reassigned_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_priority_updated(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = "TEST-1: Fix That"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """Leonardo Franchi [Administrator] updated [TEST-1: Fix That](https://zulipp.atlassian.net/browse/TEST-1) (assigned to **leo@zulip.com**):
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
messages: Strip trailing whitespace in message contents. I dug into why we never did this before, and it turns out we did, but using `$.trim()` (which removes leading whitespace as well!). When removing the `$.trim()` usage. Fixes #3294.
2017-02-12 04:22:13 +01:00
* Changed priority from **Critical** to **Major**"""
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('updated_priority_v1', expected_topic, expected_message)
self.send_and_test_stream_message('updated_priority_v2', expected_topic, expected_message)
Add support for old Jira API's version to Jira integration.
2017-01-30 19:26:48 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_status_changed(self) -> None:
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
expected_topic = "TEST-1: Fix That"
webhooks/jira: Improve punctuation and message formatting.
2019-05-09 03:40:38 +02:00
expected_message = """Leonardo Franchi [Administrator] updated [TEST-1: Fix That](https://zulipp.atlassian.net/browse/TEST-1):
Add support for old Jira API's version to Jira integration.
2017-01-30 19:26:48 +01:00
messages: Strip trailing whitespace in message contents. I dug into why we never did this before, and it turns out we did, but using `$.trim()` (which removes leading whitespace as well!). When removing the `$.trim()` usage. Fixes #3294.
2017-02-12 04:22:13 +01:00
* Changed status from **To Do** to **In Progress**"""
tools: Upgrade Pycodestyle and fix new linter errors. Here, we are upgrading pycodestyle version from 2.4.0 to 2.5.0. Fixes: #11396.
2019-01-31 14:32:37 +01:00
self.send_and_test_stream_message('change_status_v1', expected_topic, expected_message)
self.send_and_test_stream_message('change_status_v2', expected_topic, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Change use of typing.Text to str.
2018-05-10 19:34:01 +02:00
def get_body(self, fixture_name: str) -> str:
tests: Refactor use of test and webhook data fixtures.
2018-04-20 03:57:21 +02:00
return self.webhook_fixture_data('jira', fixture_name)
webhooks/jira: Update webhook to support improved comment events. Atlassian announced that it will no longer provide information about comments along with their "issue" type event payloads for Jira. So we must now update the Jira integration to appropriately respond to "comment" type events (the reason why we didn't do this before was that initially, the "comment" type event payloads didn't contain sufficient information about their issues, but this payload has since been improved). Note: This commit does *not* remove support for the older "issue" type event payloads where information about comments was included. This way we can maintain compatibility with old self-hosted versions of self hosted Jira (2016 and before). Source: https://developer.atlassian.com/cloud/jira/platform/change-notice- removal-of-comments-from-issue-webhooks/ Fixes #13012
2019-08-16 17:20:07 +02:00
def test_comment_event_comment_created(self) -> None:
expected_topic = "SP-1: Add support for newer format Jira issue comment events"
expected_message = """Hemanth V. Alluri commented on issue: *"Add support for newer format Jira issue comment events"*\n``` quote\nSounds like it’s pretty important. I’ll get this fixed ASAP!\n```"""
self.send_and_test_stream_message("comment_created", expected_topic, expected_message)
def test_comment_event_comment_edited(self) -> None:
expected_topic = "SP-1: Add support for newer format Jira issue comment events"
expected_message = """Hemanth V. Alluri updated their comment on issue: *"Add support for newer format Jira issue comment events"*\n``` quote\nThis is a very important issue! I’m on it!\n```"""
self.send_and_test_stream_message("comment_updated", expected_topic, expected_message)
def test_comment_event_comment_deleted(self) -> None:
expected_topic = "SP-1: Add support for newer format Jira issue comment events"
expected_message = """Hemanth V. Alluri deleted their comment on issue: *"Add support for newer format Jira issue comment events"*\n``` quote\n~~This is a very important issue! I’m on it!~~\n```"""
self.send_and_test_stream_message("comment_deleted", expected_topic, expected_message)