Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

webhooks/jira: Test double-escaped stream names with spaces. 

A recent change to check_send_webhook_message allows webhooks to
unescape stream names before sending a message. This commit adds
a test for the edge case where the webhook URL is escaped twice by
a third-party.
This commit is contained in:
Eeshan Garg 2018-11-06 20:44:21 -03:30 committed by Tim Abbott
parent e14a35b490
commit f9d867e138
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/webhooks/jira/tests.py
View File

@ -43,6 +43,24 @@ class JiraHookTests(WebhookTestCase):
expected_subject = "BUG-15: New bug with hook"
expected_message = """Leo Franchi **created** [BUG-15](http://lfranchi.com:8080/browse/BUG-15) priority Major, assigned to **no one**:
> New bug with hook"""
msg = self.get_last_message()
self.assertEqual(msg.content, expected_message)
self.assertEqual(msg.topic_name(), expected_subject)
def test_created_with_stream_with_spaces_double_escaped(self) -> None:
self.STREAM_NAME = quote(quote('jira alerts'))
self.url = self.build_webhook_url()
self.subscribe(self.test_user, unquote(unquote(self.STREAM_NAME)))
payload = self.get_body('created_v1')
result = self.client_post(self.url, payload, content_type='application/json')
self.assert_json_success(result)
expected_subject = "BUG-15: New bug with hook"
expected_message = """Leo Franchi **created** [BUG-15](http://lfranchi.com:8080/browse/BUG-15) priority Major, assigned to **no one**:
> New bug with hook"""
msg = self.get_last_message()
self.assertEqual(msg.content, expected_message)