2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2021-03-06 19:05:17 +01:00
|
|
|
const {mock_module, set_global, with_field, zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-02-21 15:38:51 +01:00
|
|
|
const $ = require("../zjsunit/zjquery");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("page_params", {
|
|
|
|
stop_words: ["what", "about"],
|
2019-01-28 17:44:48 +01:00
|
|
|
});
|
2020-04-13 18:53:07 +02:00
|
|
|
|
2021-03-06 19:05:17 +01:00
|
|
|
const stream_topic_history = mock_module("stream_topic_history");
|
2020-12-01 23:21:38 +01:00
|
|
|
const hash_util = zrequire("hash_util");
|
2021-03-06 17:37:51 +01:00
|
|
|
|
2020-12-01 23:21:38 +01:00
|
|
|
const compose_state = zrequire("compose_state");
|
|
|
|
const narrow_state = zrequire("narrow_state");
|
|
|
|
const people = zrequire("people");
|
|
|
|
const stream_data = zrequire("stream_data");
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
const {Filter} = zrequire("../js/filter");
|
2021-02-10 04:53:22 +01:00
|
|
|
const narrow = zrequire("narrow");
|
2017-04-25 15:25:31 +02:00
|
|
|
|
2013-09-18 19:01:21 +02:00
|
|
|
function set_filter(operators) {
|
2020-07-02 01:39:34 +02:00
|
|
|
operators = operators.map((op) => ({
|
js: Convert _.map(a, …) to a.map(…).
And convert the corresponding function expressions to arrow style
while we’re here.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitCallExpression(path) {
const { callee, arguments: args } = path.node;
if (
n.MemberExpression.check(callee) &&
!callee.computed &&
n.Identifier.check(callee.object) &&
callee.object.name === "_" &&
n.Identifier.check(callee.property) &&
callee.property.name === "map" &&
args.length === 2 &&
checkExpression(args[0]) &&
checkExpression(args[1])
) {
const [arr, fn] = args;
path.replace(
b.callExpression(b.memberExpression(arr, b.identifier("map")), [
n.FunctionExpression.check(fn) ||
n.ArrowFunctionExpression.check(fn)
? b.arrowFunctionExpression(
fn.params,
n.BlockStatement.check(fn.body) &&
fn.body.body.length === 1 &&
n.ReturnStatement.check(fn.body.body[0])
? fn.body.body[0].argument || b.identifier("undefined")
: fn.body
)
: fn,
])
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 02:43:49 +01:00
|
|
|
operator: op[0],
|
|
|
|
operand: op[1],
|
|
|
|
}));
|
2017-04-25 15:25:31 +02:00
|
|
|
narrow_state.set_current_filter(new Filter(operators));
|
2013-09-18 19:01:21 +02:00
|
|
|
}
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const me = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "me@example.com",
|
2018-10-18 19:41:44 +02:00
|
|
|
user_id: 5,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Me Myself",
|
2018-10-18 19:41:44 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "alice@example.com",
|
2018-05-28 14:10:33 +02:00
|
|
|
user_id: 23,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Alice Smith",
|
2018-05-28 14:10:33 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const ray = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "ray@example.com",
|
2018-05-28 14:10:33 +02:00
|
|
|
user_id: 22,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Raymond",
|
2018-05-28 14:10:33 +02:00
|
|
|
};
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("uris", () => {
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(ray);
|
|
|
|
people.add_active_user(alice);
|
|
|
|
people.add_active_user(me);
|
2018-10-18 19:41:44 +02:00
|
|
|
people.initialize_current_user(me.user_id);
|
2017-01-06 14:42:52 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let uri = hash_util.pm_with_uri(ray.email);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(uri, "#narrow/pm-with/22-ray");
|
2017-01-06 14:42:52 +01:00
|
|
|
|
2018-08-04 16:52:37 +02:00
|
|
|
uri = hash_util.huddle_with_uri("22,23");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(uri, "#narrow/pm-with/22,23-group");
|
2017-01-06 14:42:52 +01:00
|
|
|
|
2018-08-04 17:19:03 +02:00
|
|
|
uri = hash_util.by_sender_uri(ray.email);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(uri, "#narrow/sender/22-ray");
|
2017-01-19 03:53:50 +01:00
|
|
|
|
2020-12-01 00:57:57 +01:00
|
|
|
let emails = hash_util.decode_operand("pm-with", "22,23-group");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(emails, "alice@example.com,ray@example.com");
|
2018-10-18 19:41:44 +02:00
|
|
|
|
2020-12-01 00:57:57 +01:00
|
|
|
emails = hash_util.decode_operand("pm-with", "5,22,23-group");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(emails, "alice@example.com,ray@example.com");
|
2018-10-18 19:41:44 +02:00
|
|
|
|
2020-12-01 00:57:57 +01:00
|
|
|
emails = hash_util.decode_operand("pm-with", "5-group");
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(emails, "me@example.com");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("show_empty_narrow_message", () => {
|
2017-04-25 15:25:31 +02:00
|
|
|
narrow_state.reset_current_filter();
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($(".empty_feed_notice").visible(), false);
|
|
|
|
assert($("#empty_narrow_message").visible());
|
2019-01-28 15:41:33 +01:00
|
|
|
assert.equal(
|
2020-07-15 01:29:15 +02:00
|
|
|
$("#left_bar_compose_reply_button_big").attr("title"),
|
|
|
|
"translated: There are no messages to reply to.",
|
2019-01-28 15:41:33 +01:00
|
|
|
);
|
2017-01-25 19:13:10 +01:00
|
|
|
|
|
|
|
// for non-existent or private stream
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["stream", "Foo"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#nonsubbed_private_nonexistent_stream_narrow_message").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
|
|
|
// for non sub public stream
|
2020-07-15 01:29:15 +02:00
|
|
|
stream_data.add_sub({name: "ROME", stream_id: 99});
|
2019-03-08 22:31:09 +01:00
|
|
|
stream_data.update_calculated_fields(stream_data.get_sub("ROME"));
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["stream", "Rome"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#nonsubbed_stream_narrow_message").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "starred"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_star_narrow_message").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "mentioned"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_narrow_all_mentioned").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "private"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_narrow_all_private_message").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["is", "unread"]]);
|
2017-06-18 23:50:00 +02:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#no_unread_narrow_message").visible());
|
2017-06-18 23:50:00 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", ["Yo"]]]);
|
2018-05-28 14:10:33 +02:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#non_existing_user").visible());
|
2018-05-28 14:10:33 +02:00
|
|
|
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(alice);
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", ["alice@example.com", "Yo"]]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#non_existing_users").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["pm-with", "alice@example.com"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_narrow_private_message").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["group-pm-with", "alice@example.com"]]);
|
2017-09-24 19:26:51 +02:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_narrow_group_private_message").visible());
|
2017-09-24 19:26:51 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["sender", "ray@example.com"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#silent_user").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["sender", "sinwar@example.com"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#non_existing_user").visible());
|
2017-01-25 19:13:10 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const display = $("#empty_search_stop_words_string");
|
2019-01-28 17:44:48 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const items = [];
|
2019-01-28 17:44:48 +01:00
|
|
|
display.append = (html) => {
|
|
|
|
items.push(html);
|
|
|
|
};
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["search", "grail"]]);
|
2017-01-25 19:13:10 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2019-01-28 17:44:48 +01:00
|
|
|
|
|
|
|
assert.equal(items.length, 2);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(items[0], " ");
|
|
|
|
assert.equal(items[1].text(), "grail");
|
2019-03-07 09:27:45 +01:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("show_search_stopwords", () => {
|
2019-03-07 09:27:45 +01:00
|
|
|
narrow_state.reset_current_filter();
|
2019-11-02 00:06:25 +01:00
|
|
|
let items = [];
|
2019-03-07 09:27:45 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const display = $("#empty_search_stop_words_string");
|
2019-01-28 17:44:48 +01:00
|
|
|
|
|
|
|
display.append = (html) => {
|
|
|
|
if (html.text) {
|
|
|
|
items.push(html.selector + html.text());
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_filter([["search", "what about grail"]]);
|
2019-01-28 17:44:48 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2019-01-28 17:44:48 +01:00
|
|
|
|
|
|
|
assert.equal(items.length, 3);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(items[0], "<del>what");
|
|
|
|
assert.equal(items[1], "<del>about");
|
|
|
|
assert.equal(items[2], "<span>grail");
|
2019-03-07 09:27:45 +01:00
|
|
|
|
|
|
|
items = [];
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "streamA"],
|
|
|
|
["search", "what about grail"],
|
|
|
|
]);
|
2019-03-07 09:27:45 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2019-03-07 09:27:45 +01:00
|
|
|
|
|
|
|
assert.equal(items.length, 4);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(items[0], "<span>stream: streamA");
|
|
|
|
assert.equal(items[1], "<del>what");
|
|
|
|
assert.equal(items[2], "<del>about");
|
|
|
|
assert.equal(items[3], "<span>grail");
|
2019-03-07 09:27:45 +01:00
|
|
|
|
|
|
|
items = [];
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "streamA"],
|
|
|
|
["topic", "topicA"],
|
|
|
|
["search", "what about grail"],
|
|
|
|
]);
|
2019-03-07 09:27:45 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2019-03-07 09:27:45 +01:00
|
|
|
|
|
|
|
assert.equal(items.length, 4);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(items[0], "<span>stream: streamA topic: topicA");
|
|
|
|
assert.equal(items[1], "<del>what");
|
|
|
|
assert.equal(items[2], "<del>about");
|
|
|
|
assert.equal(items[3], "<span>grail");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-11-30 00:20:10 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("show_invalid_narrow_message", () => {
|
2019-03-07 09:12:00 +01:00
|
|
|
narrow_state.reset_current_filter();
|
2019-11-02 00:06:25 +01:00
|
|
|
const display = $("#empty_search_stop_words_string");
|
2019-03-07 09:12:00 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
stream_data.add_sub({name: "streamA", stream_id: 88});
|
|
|
|
stream_data.add_sub({name: "streamB", stream_id: 77});
|
2019-03-07 09:12:00 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["stream", "streamA"],
|
|
|
|
["stream", "streamB"],
|
|
|
|
]);
|
2019-03-07 09:12:00 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.equal(
|
|
|
|
display.text(),
|
|
|
|
"translated: You are searching for messages that belong to more than one stream, which is not possible.",
|
|
|
|
);
|
2019-03-07 09:12:00 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["topic", "topicA"],
|
|
|
|
["topic", "topicB"],
|
|
|
|
]);
|
2019-03-07 09:12:00 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.equal(
|
|
|
|
display.text(),
|
|
|
|
"translated: You are searching for messages that belong to more than one topic, which is not possible.",
|
|
|
|
);
|
2019-03-07 09:12:00 +01:00
|
|
|
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(ray);
|
|
|
|
people.add_active_user(alice);
|
2019-03-07 09:12:00 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
set_filter([
|
|
|
|
["sender", "alice@example.com"],
|
|
|
|
["sender", "ray@example.com"],
|
|
|
|
]);
|
2019-03-07 09:12:00 +01:00
|
|
|
narrow.show_empty_narrow_message();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert($("#empty_search_narrow_message").visible());
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.equal(
|
|
|
|
display.text(),
|
|
|
|
"translated: You are searching for messages that are sent by more than one person, which is not possible.",
|
|
|
|
);
|
2019-03-07 09:12:00 +01:00
|
|
|
});
|
|
|
|
|
2021-02-24 15:39:43 +01:00
|
|
|
run_test("narrow_to_compose_target errors", () => {
|
|
|
|
function test() {
|
|
|
|
with_field(
|
|
|
|
narrow,
|
|
|
|
"activate",
|
|
|
|
() => {
|
|
|
|
throw new Error("should not activate!");
|
|
|
|
},
|
|
|
|
() => {
|
|
|
|
narrow.to_compose_target();
|
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// No-op when not composing.
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.set_message_type(false);
|
|
|
|
test();
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// No-op when empty stream.
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.set_message_type("stream");
|
|
|
|
compose_state.stream_name("");
|
|
|
|
test();
|
|
|
|
});
|
|
|
|
|
|
|
|
run_test("narrow_to_compose_target streams", (override) => {
|
|
|
|
const args = {called: false};
|
|
|
|
override(narrow, "activate", (operators, opts) => {
|
|
|
|
args.operators = operators;
|
|
|
|
args.opts = opts;
|
|
|
|
args.called = true;
|
|
|
|
});
|
2018-11-30 00:20:10 +01:00
|
|
|
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.set_message_type("stream");
|
2020-07-15 01:29:15 +02:00
|
|
|
stream_data.add_sub({name: "ROME", stream_id: 99});
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.stream_name("ROME");
|
|
|
|
override(stream_topic_history, "get_recent_topic_names", () => ["one", "two", "three"]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with existing topic
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.topic("one");
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(args.opts.trigger, "narrow_to_compose_target");
|
2018-11-30 00:20:10 +01:00
|
|
|
assert.deepEqual(args.operators, [
|
2020-07-15 01:29:15 +02:00
|
|
|
{operator: "stream", operand: "ROME"},
|
|
|
|
{operator: "topic", operand: "one"},
|
2018-11-30 00:20:10 +01:00
|
|
|
]);
|
|
|
|
|
|
|
|
// Test with new topic
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.topic("four");
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "stream", operand: "ROME"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with blank topic
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.topic("");
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "stream", operand: "ROME"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with no topic
|
2021-02-24 15:39:43 +01:00
|
|
|
compose_state.topic(undefined);
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "stream", operand: "ROME"}]);
|
2021-02-24 15:39:43 +01:00
|
|
|
});
|
2018-11-30 00:20:10 +01:00
|
|
|
|
2021-02-24 15:39:43 +01:00
|
|
|
run_test("narrow_to_compose_target PMs", (override) => {
|
|
|
|
const args = {called: false};
|
|
|
|
override(narrow, "activate", (operators, opts) => {
|
|
|
|
args.operators = operators;
|
|
|
|
args.opts = opts;
|
|
|
|
args.called = true;
|
|
|
|
});
|
|
|
|
|
|
|
|
let emails;
|
|
|
|
override(compose_state, "private_message_recipient", () => emails);
|
|
|
|
|
|
|
|
compose_state.set_message_type("private");
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(ray);
|
|
|
|
people.add_active_user(alice);
|
|
|
|
people.add_active_user(me);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with valid person
|
2021-02-24 15:39:43 +01:00
|
|
|
emails = "alice@example.com";
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "pm-with", operand: "alice@example.com"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with valid persons
|
2021-02-24 15:39:43 +01:00
|
|
|
emails = "alice@example.com,ray@example.com";
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
|
|
|
assert.deepEqual(args.operators, [
|
2020-07-15 01:29:15 +02:00
|
|
|
{operator: "pm-with", operand: "alice@example.com,ray@example.com"},
|
2018-11-30 00:20:10 +01:00
|
|
|
]);
|
|
|
|
|
2020-03-28 01:25:56 +01:00
|
|
|
// Test with some invalid persons
|
2021-02-24 15:39:43 +01:00
|
|
|
emails = "alice@example.com,random,ray@example.com";
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "is", operand: "private"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
2020-03-28 01:25:56 +01:00
|
|
|
// Test with all invalid persons
|
2021-02-24 15:39:43 +01:00
|
|
|
emails = "alice,random,ray";
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "is", operand: "private"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
|
|
|
|
// Test with no persons
|
2021-02-24 15:39:43 +01:00
|
|
|
emails = "";
|
2018-11-30 00:20:10 +01:00
|
|
|
args.called = false;
|
|
|
|
narrow.to_compose_target();
|
|
|
|
assert.equal(args.called, true);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(args.operators, [{operator: "is", operand: "private"}]);
|
2018-11-30 00:20:10 +01:00
|
|
|
});
|