Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/stream_create.js

470 lines
17 KiB
JavaScript
Raw Normal View History

js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"use strict";
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const render_announce_stream_docs = require("../templates/announce_stream_docs.hbs");
const render_new_stream_users = require("../templates/new_stream_users.hbs");
const render_subscription_invites_warning_modal = require("../templates/subscription_invites_warning_modal.hbs");
templates: Replace templates.render with require calls. This removes an unnecessary layer of indirection and allows webpack to catch filename mistakes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 21:24:00 +02:00
js: Purge people module from window.
2020-08-20 21:24:06 +02:00
const people = require("./people");
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let created_stream;
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
exports.reset_created_stream = function () {
created_stream = undefined;
};
exports.set_name = function (stream) {
created_stream = stream;
};
exports.get_name = function () {
return created_stream;
};
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
class StreamSubscriptionError {
report_no_subs_to_stream() {
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
$("#stream_subscription_error").text(
i18n.t("You cannot create a stream with no subscribers!"),
);
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
$("#stream_subscription_error").show();
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
}
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
cant_create_stream_without_susbscribing() {
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
$("#stream_subscription_error").text(
i18n.t(
"You must be an organization administrator to create a stream without subscribing.",
),
);
create stream: Restrict non-admin to create stream without subscribing. Only allow realm admins to create stream without subscribing themselves, restrict non realm admin users. This new restriction is only for the UI; we don't actually block it at the backend/API level (one could always create and then remove oneself anyway).
2018-02-03 09:04:45 +01:00
$("#stream_subscription_error").show();
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
}
create stream: Restrict non-admin to create stream without subscribing. Only allow realm admins to create stream without subscribing themselves, restrict non realm admin users. This new restriction is only for the UI; we don't actually block it at the backend/API level (one could always create and then remove oneself anyway).
2018-02-03 09:04:45 +01:00
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
clear_errors() {
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
$("#stream_subscription_error").hide();
stream_create: Convert stream_subscription_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:37:12 +02:00
}
}
const stream_subscription_error = new StreamSubscriptionError();
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
class StreamNameError {
report_already_exists() {
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
$("#stream_name_error").text(i18n.t("A stream with this name already exists"));
$("#stream_name_error").show();
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
}
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
clear_errors() {
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
$("#stream_name_error").hide();
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
}
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
report_empty_stream() {
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
$("#stream_name_error").text(i18n.t("A stream needs to have a name"));
$("#stream_name_error").show();
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
}
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
select() {
js: Replace deprecated jQuery event trigger shorthand. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 21:24:26 +02:00
$("#create_stream_name").trigger("focus").trigger("select");
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
}
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
pre_validate(stream_name) {
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
// Don't worry about empty strings...we just want to call this
// to warn users early before they start doing too much work
// after they make the effort to type in a stream name. (The
// use case here is that I go to create a stream, only to find
// out it already exists, and I was just too lazy to look at
// the public streams that I'm not subscribed to yet. Once I
// realize the stream already exists, I may want to cancel.)
if (stream_name && stream_data.get_sub(stream_name)) {
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
this.report_already_exists();
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
return;
}
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
this.clear_errors();
}
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
validate_for_submit(stream_name) {
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
if (!stream_name) {
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
this.report_empty_stream();
this.select();
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
return false;
}
if (stream_data.get_sub(stream_name)) {
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
this.report_already_exists();
this.select();
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
return false;
}
// If we got this far, then we think we have a new unique stream
// name, so we'll submit to the server. (It's still plausible,
// however, that there's some invite-only stream that we don't
// know about locally that will cause a name collision.)
return true;
stream_create: Convert stream_name_error to an ES6 class. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 02:39:41 +02:00
}
}
const stream_name_error = new StreamNameError();
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
// Within the new stream modal...
function update_announce_stream_state() {
Hide "Announce stream" if realm has no "announce" stream. When you create a stream, there was always an "Announce stream" option that would be enabled for public streams. We are about to make it so that we never send PMs to announce new streams to folks, so the only mechanism will be sending a message to the realm's notification stream. If a realm has no notifications stream, the decision is moot, so we hide the option.
2017-05-16 18:34:36 +02:00
// If there is no notifications_stream, we simply hide the widget.
stream_data: Create realm_has_notifications_stream(). We use this as part of our effort to wrap the use of -1 for null/None from the rest of the code.
2020-04-15 18:29:26 +02:00
if (!stream_data.realm_has_notifications_stream()) {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#announce-new-stream").hide();
Hide "Announce stream" if realm has no "announce" stream. When you create a stream, there was always an "Announce stream" option that would be enabled for public streams. We are about to make it so that we never send PMs to announce new streams to folks, so the only mechanism will be sending a message to the realm's notification stream. If a realm has no notifications stream, the decision is moot, so we hide the option.
2017-05-16 18:34:36 +02:00
return;
}
create stream: Remove disabling announce stream, if all users checked. Remove disabling announce stream option in stream creation, if all users are checked to add into stream.
2017-12-29 11:02:24 +01:00
// If the stream is invite only, disable the "Announce stream" option.
// Otherwise enable it.
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const announce_stream_checkbox = $("#announce-new-stream input");
const announce_stream_label = $("#announce-new-stream");
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let disable_it = false;
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const privacy_type = $("input:radio[name=privacy]:checked").val();
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
const is_invite_only =
privacy_type === "invite-only" || privacy_type === "invite-only-public-history";
create stream: Disable announce stream label, not only checkbox. If stream is private, disable announce stream label with checkbox.
2017-12-29 11:06:12 +01:00
announce_stream_label.removeClass("control-label-disabled");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
if (is_invite_only) {
disable_it = true;
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
announce_stream_checkbox.prop("checked", false);
create stream: Disable announce stream label, not only checkbox. If stream is private, disable announce stream label with checkbox.
2017-12-29 11:06:12 +01:00
announce_stream_label.addClass("control-label-disabled");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
announce_stream_checkbox.prop("disabled", disable_it);
$("#announce-new-stream").show();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
stream_create: Extract get_principals.
2017-07-08 04:04:55 +02:00
function get_principals() {
eslint: Enable arrow-parens. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:39:34 +02:00
return Array.from($("#stream_creation_form input:checkbox[name=user]:checked"), (elem) => {
js: Convert _.map on jQuery collections to Array.from. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 02:24:21 +01:00
const label = $(elem).closest(".add-user-label");
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
return Number.parseInt(label.attr("data-user-id"), 10);
js: Convert _.map on jQuery collections to Array.from. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 02:24:21 +01:00
});
stream_create: Extract get_principals.
2017-07-08 04:04:55 +02:00
}
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
function create_stream() {
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
const data = {};
js: Replace deprecated $.trim method. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-22 03:39:41 +02:00
const stream_name = $("#create_stream_name").val().trim();
const description = $("#create_stream_description").val().trim();
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
created_stream = stream_name;
// Even though we already check to make sure that while typing the user cannot enter
docs: Fix capitalization of keyboard keys. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 02:09:14 +02:00
// newline characters (by pressing the Enter key) it would still be possible to copy
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
// and paste over a description with newline characters in it. Prevent that.
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
if (description.includes("\n")) {
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
ui_report.message(
i18n.t("The stream description cannot contain newline characters."),
$(".stream_create_info"),
"alert-error",
);
eslint: Replace empty-returns with consistent-return. Instead of prohibiting ‘return undefined’ (#8669), we require that a function must return an explicit value always or never. This prevents you from forgetting to return a value in some cases. It will also be important for TypeScript, which distinguishes between undefined and void. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-24 07:50:36 +02:00
return undefined;
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
}
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
data.subscriptions = JSON.stringify([{name: stream_name, description}]);
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let invite_only;
let history_public_to_subscribers;
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const privacy_setting = $("#stream_creation_form input[name=privacy]:checked").val();
settings: Migrate to stream_post_policy structure. This commit includes a new `stream_post_policy` setting, by replacing the `is_announcement_only` field from the Stream model, which is done by mirroring the structure of the existing `create_stream_policy`. It includes the necessary schema and database migrations to migrate the is_announcement_only boolean field to stream_post_policy, a smallPositiveInteger field similar to many other settings. This change is done to allow organization administrators to restrict new members from creating and posting to a stream. However, this does not affect admins who are new members. With many tweaks by tabbott to documentation under /help, etc. Fixes #13616.
2020-02-04 21:50:55 +01:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
if (privacy_setting === "invite-only") {
frontend: Add UI to create/edit private streams with public history. This completes the effort of making this a user-facing feature.
2018-05-03 18:52:39 +02:00
invite_only = true;
history_public_to_subscribers = false;
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
} else if (privacy_setting === "invite-only-public-history") {
frontend: Add UI to create/edit private streams with public history. This completes the effort of making this a user-facing feature.
2018-05-03 18:52:39 +02:00
invite_only = true;
history_public_to_subscribers = true;
} else {
invite_only = false;
history_public_to_subscribers = true;
}
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
data.invite_only = JSON.stringify(invite_only);
data.history_public_to_subscribers = JSON.stringify(history_public_to_subscribers);
frontend: Add UI to create/edit private streams with public history. This completes the effort of making this a user-facing feature.
2018-05-03 18:52:39 +02:00
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
const stream_post_policy = Number.parseInt(
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
$("#stream_creation_form input[name=stream-post-policy]:checked").val(),
10,
);
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
data.stream_post_policy = JSON.stringify(stream_post_policy);
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
let message_retention_selection = $(
"#stream_creation_form select[name=stream_message_retention_setting]",
).val();
streams: Add frontend to set/update message_retention_days of a stream. This commit adds frontend support for setting and updating message retention days of a stream from stream settings. Message retention days can be changed from stream privacy modal of the stream and can be set from stream_creation_form while creating streams. Only admins can create streams with message_retention_days value other than realm_default. This commit also contains relevant changes to docs.
2020-06-15 17:00:00 +02:00
if (message_retention_selection === "retain_for_period") {
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
message_retention_selection = Number.parseInt(
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
$("#stream_creation_form input[name=stream-message-retention-days]").val(),
10,
);
streams: Add frontend to set/update message_retention_days of a stream. This commit adds frontend support for setting and updating message retention days of a stream from stream settings. Message retention days can be changed from stream privacy modal of the stream and can be set from stream_creation_form while creating streams. Only admins can create streams with message_retention_days value other than realm_default. This commit also contains relevant changes to docs.
2020-06-15 17:00:00 +02:00
}
data.message_retention_days = JSON.stringify(message_retention_selection);
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
const announce =
stream_data.realm_has_notifications_stream() &&
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#announce-new-stream input").prop("checked");
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
data.announce = JSON.stringify(announce);
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
// TODO: We can eliminate the user_ids -> principals conversion
// once we upgrade the backend to accept user_ids.
const user_ids = get_principals();
stream_edit: Use user_ids for subscribing/unsubscribing users to a stream. We now send user_ids to the backend API for subscribing/unsubscribing users to a stream instead of emails. This change is done now because we have just migrated the backend API to support sending user_ids in 2187c84, so it wasn't possible before. This change is helpful because sending user_ids is more robust, as those are an immutable reference to a user, rather than something that can change with time.
2020-06-03 21:38:43 +02:00
data.principals = JSON.stringify(user_ids);
streams_edit: Prevent newline characters in the description. This commit achieves two things: 1. Changes the UI of the "Create stream" form to make the textarea previously used to get the stream description a simple input field of type text (to suggest a single line description). 2. Adds an extra check on the frontend side to make sure that when users create a new stream via. the "Create stream" option in the settings panel, they can't enter any newline characters (i.e. we disallow the enter key from being registered when typing out the stream description). We must also make sure that they cannot copy-and-paste over descriptions containing newline characters. resolves #11617
2019-02-20 18:36:46 +01:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
loading.make_indicator($("#stream_creating_indicator"), {text: i18n.t("Creating stream...")});
stream_settings: Add loading spinner when creating a new stream. Add a spinner for when a stream is being created to show that an operation is being performed, while also disallowing users to modify the form in the meanwhile. Commit modified by Brock Whittaker <brock@zulipchat.com>. Fixes: #5268.
2017-11-04 19:19:12 +01:00
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
// Subscribe yourself and possible other people to a new stream.
return channel.post({
url: "/json/users/me/subscriptions",
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
data,
success() {
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
$("#create_stream_name").val("");
$("#create_stream_description").val("");
ui_report.success(i18n.t("Stream successfully created!"), $(".stream_create_info"));
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
loading.destroy_indicator($("#stream_creating_indicator"));
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
// The rest of the work is done via the subscribe event we will get
},
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
error(xhr) {
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
const msg = JSON.parse(xhr.responseText).msg;
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
if (msg.includes("access")) {
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
// If we can't access the stream, we can safely assume it's
// a duplicate stream that we are not invited to.
//
// BUG: This check should be using error codes, not
// parsing the error string, so it works correctly
// with i18n. And likely we should be reporting the
// error text directly rather than turning it into
// "Error creating stream"?
stream_name_error.report_already_exists(stream_name);
js: Replace deprecated jQuery event trigger shorthand. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 21:24:26 +02:00
stream_name_error.trigger("select");
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
}
ui_report.error(i18n.t("Error creating stream"), xhr, $(".stream_create_info"));
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
loading.destroy_indicator($("#stream_creating_indicator"));
refactor: Inline ajaxSubscribeForCreation. This is done to simplify the flow of `create_stream`. Tweaked by tabbott to actually inline the full function.
2020-02-08 06:45:49 +01:00
},
});
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
}
subscriptions: Confirm inviting 100+ users to a new stream. Our current workflow for creating a new stream allows the user to invite as many other users as they like but since there can be mistakes in doing so, we now open a modal with a warning if the number of invites are more than 100 just to confirm that user indeed wanted to do this. Fixes: #1663.
2017-06-02 15:06:33 +02:00
stream_create: Use stream_name as local variable for stream names. This is a lot clearer than using "stream", which could refer to an actual object.
2017-07-08 04:31:11 +02:00
exports.new_stream_clicked = function (stream_name) {
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
// this changes the tab switcher (settings/preview) which isn't necessary
// to a add new stream title.
subscriptions: Simplify the displaying of subs pane. ".stream-info-title" selector is used to hide both "#add_new_stream_title" and "#stream_settings_title" classes. This will be helpful when we add new html elements to display in the title area.. `clear_edit_panel` can be removed as the next line to where it is called makes it redundant, we only need to de-select the stream row, as done in this commit.
2020-07-08 23:54:13 +02:00
subs.show_subs_pane.create_stream();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
$(".stream-row.active").removeClass("active");
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
if (stream_name !== "") {
$("#create_stream_name").val(stream_name);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
exports.show_new_stream_modal();
create_stream: Remove no longer required condition. The issue raised in the comment here seems to have been fixed on its own. Tested on chrome and safari on macOS. This was introduced in 2dd36aa4227cab311d5df0351c06cdcfc73ff37c.
2020-11-01 04:05:19 +01:00
$("#create_stream_name").trigger("focus");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
};
stream_create: Clear errors when re-submitting form. Previously, if you fixed the errors and then tried to re-create a stream, you'd see an error.
2018-03-10 03:14:48 +01:00
function clear_error_display() {
stream_name_error.clear_errors();
$(".stream_create_info").hide();
stream_subscription_error.clear_errors();
}
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
exports.show_new_stream_modal = function () {
$("#stream-creation").removeClass("hide");
$(".right .settings").hide();
create stream: Show current user on top of "People to add" list Fixes #7475
2017-11-26 12:57:03 +01:00
refactor: Rename people.get_rest_of_realm(). We want to mostly deprecate this function (see the comment I added), so I gave it a more specific name. Ideally I'd just fix `stream_create`, but it does use this function in a couple places, and it's helpful to reuse the same sort here. In one place stream_create actually unshifts the "me" user back to the top of the list, which makes sense for its use case.
2020-01-01 23:20:49 +01:00
const all_users = people.get_people_for_stream_create();
create stream: Show current user on top of "People to add" list Fixes #7475
2017-11-26 12:57:03 +01:00
// Add current user on top of list
people: Rename method to get_by_user_id(). This name is consistent with: get_by_email() get_by_name()
2020-02-05 14:30:59 +01:00
all_users.unshift(people.get_by_user_id(page_params.user_id));
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const html = render_new_stream_users({
create stream: Show current user on top of "People to add" list Fixes #7475
2017-11-26 12:57:03 +01:00
users: all_users,
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
streams: stream_data.get_streams_for_settings_page(),
create stream: Restrict non-admin to create stream without subscribing. Only allow realm admins to create stream without subscribing themselves, restrict non realm admin users. This new restriction is only for the UI; we don't actually block it at the backend/API level (one could always create and then remove oneself anyway).
2018-02-03 09:04:45 +01:00
is_admin: page_params.is_admin,
stream_create: Make handlers more modular for users. We now wire up the handlers that correspond to elements in the 'new_stream_users' template when we render that template, rather than at startup time. We also delegate the events only up to #people_to_add, rather than all the way up to body/document.
2018-03-25 18:11:23 +02:00
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const container = $("#people_to_add");
stream_create: Make handlers more modular for users. We now wire up the handlers that correspond to elements in the 'new_stream_users' template when we render that template, rather than at startup time. We also delegate the events only up to #people_to_add, rather than all the way up to body/document.
2018-03-25 18:11:23 +02:00
container.html(html);
exports.create_handlers_for_users(container);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
// Make the options default to the same each time:
// public, "announce stream" on.
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#make-invite-only input:radio[value=public]").prop("checked", true);
streams: Add frontend to set/update message_retention_days of a stream. This commit adds frontend support for setting and updating message retention days of a stream from stream settings. Message retention days can be changed from stream privacy modal of the stream and can be set from stream_creation_form while creating streams. Only admins can create streams with message_retention_days value other than realm_default. This commit also contains relevant changes to docs.
2020-06-15 17:00:00 +02:00
$("#stream_creation_form .stream-message-retention-days-input").hide();
$("#stream_creation_form select[name=stream_message_retention_setting]").val("realm_default");
Hide "Announce stream" if realm has no "announce" stream. When you create a stream, there was always an "Announce stream" option that would be enabled for public streams. We are about to make it so that we never send PMs to announce new streams to folks, so the only mechanism will be sending a message to the realm's notification stream. If a realm has no notifications stream, the decision is moot, so we hide the option.
2017-05-16 18:34:36 +02:00
stream_data: Create realm_has_notifications_stream(). We use this as part of our effort to wrap the use of -1 for null/None from the rest of the code.
2020-04-15 18:29:26 +02:00
if (stream_data.realm_has_notifications_stream()) {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#announce-new-stream").show();
$("#announce-new-stream input").prop("disabled", false);
$("#announce-new-stream input").prop("checked", true);
Hide "Announce stream" if realm has no "announce" stream. When you create a stream, there was always an "Announce stream" option that would be enabled for public streams. We are about to make it so that we never send PMs to announce new streams to folks, so the only mechanism will be sending a message to the realm's notification stream. If a realm has no notifications stream, the decision is moot, so we hide the option.
2017-05-16 18:34:36 +02:00
} else {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#announce-new-stream").hide();
Hide "Announce stream" if realm has no "announce" stream. When you create a stream, there was always an "Announce stream" option that would be enabled for public streams. We are about to make it so that we never send PMs to announce new streams to folks, so the only mechanism will be sending a message to the realm's notification stream. If a realm has no notifications stream, the decision is moot, so we hide the option.
2017-05-16 18:34:36 +02:00
}
stream_create: Clear errors when re-submitting form. Previously, if you fixed the errors and then tried to re-create a stream, you'd see an error.
2018-03-10 03:14:48 +01:00
clear_error_display();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#stream-checkboxes label.checkbox").on("change", function (e) {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const elem = $(this);
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
const stream_id = Number.parseInt(elem.attr("data-stream-id"), 10);
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const checked = elem.find("input").prop("checked");
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const subscriber_ids = stream_data.get_sub_by_id(stream_id).subscribers;
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#user-checkboxes label.checkbox").each(function () {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const user_elem = $(this);
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
const user_id = Number.parseInt(user_elem.attr("data-user-id"), 10);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
if (subscriber_ids.has(user_id)) {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
user_elem.find("input").prop("checked", checked);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
});
e.preventDefault();
});
};
stream_create: Make handlers more modular for users. We now wire up the handlers that correspond to elements in the 'new_stream_users' template when we render that template, rather than at startup time. We also delegate the events only up to #people_to_add, rather than all the way up to body/document.
2018-03-25 18:11:23 +02:00
exports.create_handlers_for_users = function (container) {
// container should be $('#people_to_add')...see caller to verify
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("change", "#user-checkboxes input", update_announce_stream_state);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
// 'Check all' and 'Uncheck all' visible users
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("click", ".subs_set_all_users", (e) => {
$("#user-checkboxes .checkbox").each((idx, li) => {
js: Remove extra consecutive spaces. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-16 23:29:01 +02:00
if (li.style.display !== "none") {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$(li.firstElementChild).prop("checked", true);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
});
e.preventDefault();
update_announce_stream_state();
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("click", ".subs_unset_all_users", (e) => {
$("#user-checkboxes .checkbox").each((idx, li) => {
create stream: Restrict non-admin to create stream without subscribing. Only allow realm admins to create stream without subscribing themselves, restrict non realm admin users. This new restriction is only for the UI; we don't actually block it at the backend/API level (one could always create and then remove oneself anyway).
2018-02-03 09:04:45 +01:00
if (li.style.display !== "none") {
// The first checkbox is the one for ourself; this is the code path for:
// `stream_subscription_error.cant_create_stream_without_susbscribing`
if (idx === 0 && !page_params.is_admin) {
return;
}
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$(li.firstElementChild).prop("checked", false);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
});
e.preventDefault();
update_announce_stream_state();
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("click", "#copy-from-stream-expand-collapse", (e) => {
$("#stream-checkboxes").toggle();
$("#copy-from-stream-expand-collapse .toggle").toggleClass("fa-caret-right fa-caret-down");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
e.preventDefault();
});
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
// Search people or streams
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("input", ".add-user-list-filter", (e) => {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const user_list = $(".add-user-list-filter");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
if (user_list === 0) {
return;
}
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const search_term = user_list.expectOne().val().trim();
const search_terms = search_term.toLowerCase().split(",");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
(function filter_user_checkboxes() {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const user_labels = $("#user-checkboxes label.add-user-label");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
if (search_term === "") {
user_labels.css({display: "block"});
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
return;
}
refactor: Rename people.get_rest_of_realm(). We want to mostly deprecate this function (see the comment I added), so I gave it a more specific name. Ideally I'd just fix `stream_create`, but it does use this function in a couple places, and it's helpful to reuse the same sort here. In one place stream_create actually unshifts the "me" user back to the top of the list, which makes sense for its use case.
2020-01-01 23:20:49 +01:00
const users = people.get_people_for_stream_create();
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const filtered_users = people.filter_people_by_search_terms(users, search_terms);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
// Be careful about modifying the follow code. A naive implementation
// will work very poorly with a large user population (~1000 users).
//
// I tested using: `./manage.py populate_db --extra-users 3500`
//
// This would break the previous implementation, whereas the new
// implementation is merely sluggish.
user_labels.each(function () {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const elem = $(this);
eslint: Fix unicorn/prefer-number-properties. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-number-properties.md MDN says these were added to Number for modularization of globals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 09:17:30 +02:00
const user_id = Number.parseInt(elem.attr("data-user-id"), 10);
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const user_checked = filtered_users.has(user_id);
const display = user_checked ? "block" : "none";
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
elem.css({display});
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
});
js: Use inside variant of IIFE wrappers. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-16 22:35:58 +02:00
})();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
e.preventDefault();
});
Extract stream_create.create_handlers_for_users().
2018-03-25 17:43:17 +02:00
};
stream_create: Finish handler cleanup. This commit is similar to the prior commit, in that we are more disciplined about setting up handlers. We set them up right as the widgets get rendered, and the handlers only delegate up to the container div (id="stream_creation").
2018-03-25 18:46:10 +02:00
exports.set_up_handlers = function () {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const container = $("#stream-creation").expectOne();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
container.on("change", "#make-invite-only input", update_announce_stream_state);
stream_create: Finish handler cleanup. This commit is similar to the prior commit, in that we are more disciplined about setting up handlers. We set them up right as the widgets get rendered, and the handlers only delegate up to the container div (id="stream_creation").
2018-03-25 18:46:10 +02:00
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("submit", "#stream_creation_form", (e) => {
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
e.preventDefault();
stream_create: Clear errors when re-submitting form. Previously, if you fixed the errors and then tried to re-create a stream, you'd see an error.
2018-03-10 03:14:48 +01:00
clear_error_display();
js: Replace deprecated $.trim method. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-22 03:39:41 +02:00
const stream_name = $("#create_stream_name").val().trim();
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const name_ok = stream_name_error.validate_for_submit(stream_name);
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
if (!name_ok) {
return;
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
}
subscriptions: Confirm inviting 100+ users to a new stream. Our current workflow for creating a new stream allows the user to invite as many other users as they like but since there can be mistakes in doing so, we now open a modal with a warning if the number of invites are more than 100 just to confirm that user indeed wanted to do this. Fixes: #1663.
2017-06-02 15:06:33 +02:00
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const principals = get_principals();
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
if (principals.length === 0) {
stream_subscription_error.report_no_subs_to_stream();
return;
}
js: Convert a.indexOf(…) !== -1 to a.includes(…). Babel polyfills this for us for Internet Explorer. import * as babelParser from "recast/parsers/babel"; import * as recast from "recast"; import * as tsParser from "recast/parsers/typescript"; import { builders as b, namedTypes as n } from "ast-types"; import K from "ast-types/gen/kinds"; import fs from "fs"; import path from "path"; import process from "process"; const checkExpression = (node: n.Node): node is K.ExpressionKind => n.Expression.check(node); for (const file of process.argv.slice(2)) { console.log("Parsing", file); const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), { parser: path.extname(file) === ".ts" ? tsParser : babelParser, }); let changed = false; recast.visit(ast, { visitBinaryExpression(path) { const { operator, left, right } = path.node; if ( n.CallExpression.check(left) && n.MemberExpression.check(left.callee) && !left.callee.computed && n.Identifier.check(left.callee.property) && left.callee.property.name === "indexOf" && left.arguments.length === 1 && checkExpression(left.arguments[0]) && ((["===", "!==", "==", "!=", ">", "<="].includes(operator) && n.UnaryExpression.check(right) && right.operator == "-" && n.Literal.check(right.argument) && right.argument.value === 1) || ([">=", "<"].includes(operator) && n.Literal.check(right) && right.value === 0)) ) { const test = b.callExpression( b.memberExpression(left.callee.object, b.identifier("includes")), [left.arguments[0]] ); path.replace( ["!==", "!=", ">", ">="].includes(operator) ? test : b.unaryExpression("!", test) ); changed = true; } this.traverse(path); }, }); if (changed) { console.log("Writing", file); fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" }); } } Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 04:55:06 +01:00
if (!principals.includes(people.my_current_user_id()) && !page_params.is_admin) {
create stream: Restrict non-admin to create stream without subscribing. Only allow realm admins to create stream without subscribing themselves, restrict non realm admin users. This new restriction is only for the UI; we don't actually block it at the backend/API level (one could always create and then remove oneself anyway).
2018-02-03 09:04:45 +01:00
stream_subscription_error.cant_create_stream_without_susbscribing();
return;
}
create stream: Don't allow creating stream with zero subscribers. Restrict users(even realm admins) from creating stream with zero subscribers only in UI. In backend, if subscribers are zero, we automatically subscribe current user to stream.
2018-01-21 09:34:50 +01:00
subscriptions: Edit copy for the new stream creation confirmation flow. The new text is a bit simpler and clearer. We also decrease the threshhold for this page to 50 subscribers.
2017-07-08 04:21:19 +02:00
if (principals.length >= 50) {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const invites_warning_modal = render_subscription_invites_warning_modal({
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
stream_name,
templates: Replace templates.render with require calls. This removes an unnecessary layer of indirection and allows webpack to catch filename mistakes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 21:24:00 +02:00
count: principals.length,
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#stream-creation").append(invites_warning_modal);
subscriptions: Confirm inviting 100+ users to a new stream. Our current workflow for creating a new stream allows the user to invite as many other users as they like but since there can be mistakes in doing so, we now open a modal with a warning if the number of invites are more than 100 just to confirm that user indeed wanted to do this. Fixes: #1663.
2017-06-02 15:06:33 +02:00
} else {
create_stream();
}
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("click", ".close-invites-warning-modal", () => {
subscriptions: Confirm inviting 100+ users to a new stream. Our current workflow for creating a new stream allows the user to invite as many other users as they like but since there can be mistakes in doing so, we now open a modal with a warning if the number of invites are more than 100 just to confirm that user indeed wanted to do this. Fixes: #1663.
2017-06-02 15:06:33 +02:00
$("#invites-warning-overlay").remove();
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("click", ".confirm-invites-warning-modal", () => {
stream_create: Extract create_stream.
2017-07-08 04:07:36 +02:00
create_stream();
subscriptions: Confirm inviting 100+ users to a new stream. Our current workflow for creating a new stream allows the user to invite as many other users as they like but since there can be mistakes in doing so, we now open a modal with a warning if the number of invites are more than 100 just to confirm that user indeed wanted to do this. Fixes: #1663.
2017-06-02 15:06:33 +02:00
$("#invites-warning-overlay").remove();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("input", "#create_stream_name", () => {
js: Replace deprecated $.trim method. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-22 03:39:41 +02:00
const stream_name = $("#create_stream_name").val().trim();
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
Improve how we report errors when we name new streams. When the user creates a stream, we no longer do a synchronous check on the back end to find if the stream name already exists. Instead, we only check our local data, which will prevent many typical errors, and then we let the back end capture duplicates for stream names that the client doesn't know about. We also tone down errors when the stream name is blank--we only whine about empty streams right before submitting the form. Also, since our check for duplicate streams is less expensive, we now capture the "input" event instead of the "focusout" event, so that if you fix up the name to avoid a collision, you get more immediate feedback. When we do detect stream name errors, we conveniently focus the text field to let the user correct the problem.
2017-04-28 22:04:32 +02:00
// This is an inexpensive check.
stream_create: Use stream_name as local variable for stream names. This is a lot clearer than using "stream", which could refer to an actual object.
2017-07-08 04:31:11 +02:00
stream_name_error.pre_validate(stream_name);
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("mouseover", "#announce-stream-docs", (e) => {
js: Automatically convert var to let and const in more files. This commit was automatically generated by `tools/lint --only=eslint --fix`, after an `.eslintrc.json` change. A half dozen files were removed from the changes by tabbott pending further work to ensure we avoid breaking valuable PRs with merge conflicts. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const announce_stream_docs = $("#announce-stream-docs");
js: Fix a bunch of indentation issues found by eslint. This is preparation for enabling an eslint indentation configuration. 90% of these changes are just fixes for indentation errors that have snuck into the codebase over the years; the others are more significant reformatting to make eslint happy (that are not otherwise actually improvements). The one area that we do not attempt to work on here is the "switch/case" indentation.
2018-05-06 21:43:17 +02:00
announce_stream_docs.popover({
placement: "right",
templates: Replace templates.render with require calls. This removes an unnecessary layer of indirection and allows webpack to catch filename mistakes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-09 21:24:00 +02:00
content: render_announce_stream_docs({
stream_data: Remove page_params.notifications_stream. We shouldn't add redundant data to page_params. Since we already have page_params.realm_notifications_stream_id, we can use that value instead of creating page_params.notifications_stream. We, however, still need the name of the notifications stream to render it in templates. Thus we create stream_data.get_notifications_stream().
2020-04-14 12:55:18 +02:00
notifications_stream: stream_data.get_notifications_stream(),
}),
bootstrap: Change tooltip html default to false. Bootstrap v2.2.0^2~40^2~6 changes this default to false, so this is a prerequisite to upgrading Bootstrap, and it’s also safer. This closes an HTML injection path via user full names in the emoji reaction tooltip. It doesn’t appear to be exploitable for cross-site scripting because we disallow `>` in full names, and the code happens to be written such that the next `>` is in a different parser invocation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-09-17 23:54:52 +02:00
html: true,
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
trigger: "manual",
});
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
announce_stream_docs.popover("show");
announce_stream_docs.data("popover").tip().css("z-index", 2000);
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
announce_stream_docs
.data("popover")
.tip()
.find(".popover-content")
.css("margin", "9px 14px");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
e.stopPropagation();
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("mouseout", "#announce-stream-docs", (e) => {
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
$("#announce-stream-docs").popover("hide");
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
e.stopPropagation();
});
streams_edit: Prevent newline characters in the description. This commit achieves two things: 1. Changes the UI of the "Create stream" form to make the textarea previously used to get the stream description a simple input field of type text (to suggest a single line description). 2. Adds an extra check on the frontend side to make sure that when users create a new stream via. the "Create stream" option in the settings panel, they can't enter any newline characters (i.e. we disallow the enter key from being registered when typing out the stream description). We must also make sure that they cannot copy-and-paste over descriptions containing newline characters. resolves #11617
2019-02-20 18:36:46 +01:00
// Do not allow the user to enter newline characters while typing out the
// stream's description during it's creation.
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
container.on("keydown", "#create_stream_description", (e) => {
streams_edit: Prevent newline characters in the description. This commit achieves two things: 1. Changes the UI of the "Create stream" form to make the textarea previously used to get the stream description a simple input field of type text (to suggest a single line description). 2. Adds an extra check on the frontend side to make sure that when users create a new stream via. the "Create stream" option in the settings panel, they can't enter any newline characters (i.e. we disallow the enter key from being registered when typing out the stream description). We must also make sure that they cannot copy-and-paste over descriptions containing newline characters. resolves #11617
2019-02-20 18:36:46 +01:00
if ((e.keyCode || e.which) === 13) {
e.preventDefault();
}
});
stream_create: Finish handler cleanup. This commit is similar to the prior commit, in that we are more disciplined about setting up handlers. We set them up right as the widgets get rendered, and the handlers only delegate up to the container div (id="stream_creation").
2018-03-25 18:46:10 +02:00
};
Extract stream_create.js. This new modules handles the UI to create streams. It mostly moves code from subs.js. It introduces an API around what used to be called meta.stream_created: reset_created_stream() set_name() get_name() It only partially moves new_stream_clicked().
2017-04-22 22:22:25 +02:00
js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-10-25 09:45:13 +02:00
window.stream_create = exports;