2017-11-06 15:10:33 +01:00
|
|
|
zrequire('people');
|
2018-07-31 07:20:03 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const return_false = function () { return false; };
|
|
|
|
const return_true = function () { return true; };
|
2018-08-04 15:40:25 +02:00
|
|
|
set_global('reload_state', {
|
2018-07-31 07:20:03 +02:00
|
|
|
is_in_progress: return_false,
|
2018-04-23 21:13:21 +02:00
|
|
|
});
|
2017-11-06 15:10:33 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const me = {
|
2017-11-06 15:10:33 +01:00
|
|
|
email: 'me@example.com',
|
|
|
|
user_id: 30,
|
|
|
|
full_name: 'Me Myself',
|
|
|
|
timezone: 'US/Pacific',
|
|
|
|
};
|
|
|
|
|
|
|
|
people.init();
|
|
|
|
people.add(me);
|
|
|
|
people.initialize_current_user(me.user_id);
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('report_late_add', () => {
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Added user late: user_id=55 email=foo@example.com');
|
2017-11-06 17:03:01 +01:00
|
|
|
people.report_late_add(55, 'foo@example.com');
|
2018-04-23 21:13:21 +02:00
|
|
|
|
2020-04-20 12:53:34 +02:00
|
|
|
blueslip.expect('log', 'Added user late: user_id=55 email=foo@example.com');
|
2018-08-04 15:40:25 +02:00
|
|
|
reload_state.is_in_progress = return_true;
|
2018-04-23 21:13:21 +02:00
|
|
|
people.report_late_add(55, 'foo@example.com');
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-11-06 17:03:01 +01:00
|
|
|
|
2019-12-31 14:02:30 +01:00
|
|
|
run_test('is_my_user_id', () => {
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'user_id is a string in my_user_id: 999');
|
2019-12-31 14:02:30 +01:00
|
|
|
assert.equal(people.is_my_user_id('999'), false);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'user_id is a string in my_user_id: 30');
|
2019-12-31 14:02:30 +01:00
|
|
|
assert.equal(people.is_my_user_id(me.user_id.toString()), true);
|
|
|
|
});
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('blueslip', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const unknown_email = "alicebobfred@example.com";
|
2017-11-06 15:10:33 +01:00
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('debug', 'User email operand unknown: ' + unknown_email);
|
2017-11-06 15:10:33 +01:00
|
|
|
people.id_matches_email_operand(42, unknown_email);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Unknown user_id: 9999');
|
2020-02-16 14:16:46 +01:00
|
|
|
people.get_actual_name_from_user_id(9999);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Unknown email for get_user_id: ' + unknown_email);
|
2017-11-06 15:10:33 +01:00
|
|
|
people.get_user_id(unknown_email);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('warn', 'No user_id provided for person@example.com');
|
2019-11-02 00:06:25 +01:00
|
|
|
const person = {
|
2017-11-06 15:10:33 +01:00
|
|
|
email: 'person@example.com',
|
|
|
|
user_id: undefined,
|
|
|
|
full_name: 'Person Person',
|
|
|
|
};
|
|
|
|
people.add(person);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'No user_id found for person@example.com');
|
2019-11-02 00:06:25 +01:00
|
|
|
const user_id = people.get_user_id('person@example.com');
|
2017-11-06 15:10:33 +01:00
|
|
|
assert.equal(user_id, undefined);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('warn', 'Unknown user ids: 1,2');
|
2017-11-06 15:10:33 +01:00
|
|
|
people.user_ids_string_to_emails_string('1,2');
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('warn', 'Unknown emails: ' + unknown_email);
|
2020-02-08 01:27:04 +01:00
|
|
|
people.email_list_to_user_ids_string([unknown_email]);
|
2017-11-06 15:10:33 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let message = {
|
2017-11-06 15:10:33 +01:00
|
|
|
type: 'private',
|
|
|
|
display_recipient: [],
|
|
|
|
sender_id: me.user_id,
|
|
|
|
};
|
2020-04-20 12:38:24 +02:00
|
|
|
blueslip.expect('error', 'Empty recipient list in message', 4);
|
2017-11-06 15:10:33 +01:00
|
|
|
people.pm_with_user_ids(message);
|
|
|
|
people.group_pm_with_user_ids(message);
|
2018-10-18 22:05:28 +02:00
|
|
|
people.all_user_ids_in_pm(message);
|
|
|
|
assert.equal(people.pm_perma_link(message), undefined);
|
2017-11-06 15:10:33 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const charles = {
|
2017-11-06 15:10:33 +01:00
|
|
|
email: 'charles@example.com',
|
|
|
|
user_id: 451,
|
|
|
|
full_name: 'Charles Dickens',
|
|
|
|
avatar_url: 'charles.com/foo.png',
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const maria = {
|
2017-11-06 15:10:33 +01:00
|
|
|
email: 'athens@example.com',
|
|
|
|
user_id: 452,
|
|
|
|
full_name: 'Maria Athens',
|
|
|
|
};
|
|
|
|
people.add(charles);
|
|
|
|
people.add(maria);
|
|
|
|
|
|
|
|
message = {
|
|
|
|
type: 'private',
|
|
|
|
display_recipient: [
|
|
|
|
{id: maria.user_id},
|
|
|
|
{id: 42},
|
2020-01-01 13:02:34 +01:00
|
|
|
{id: charles.user_id},
|
2017-11-06 15:10:33 +01:00
|
|
|
],
|
|
|
|
sender_id: charles.user_id,
|
|
|
|
};
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Unknown user id in message: 42');
|
2019-11-02 00:06:25 +01:00
|
|
|
const reply_to = people.pm_reply_to(message);
|
js: Convert a.indexOf(…) !== -1 to a.includes(…).
Babel polyfills this for us for Internet Explorer.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitBinaryExpression(path) {
const { operator, left, right } = path.node;
if (
n.CallExpression.check(left) &&
n.MemberExpression.check(left.callee) &&
!left.callee.computed &&
n.Identifier.check(left.callee.property) &&
left.callee.property.name === "indexOf" &&
left.arguments.length === 1 &&
checkExpression(left.arguments[0]) &&
((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
n.UnaryExpression.check(right) &&
right.operator == "-" &&
n.Literal.check(right.argument) &&
right.argument.value === 1) ||
([">=", "<"].includes(operator) &&
n.Literal.check(right) &&
right.value === 0))
) {
const test = b.callExpression(
b.memberExpression(left.callee.object, b.identifier("includes")),
[left.arguments[0]]
);
path.replace(
["!==", "!=", ">", ">="].includes(operator)
? test
: b.unaryExpression("!", test)
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 04:55:06 +01:00
|
|
|
assert(reply_to.includes('?'));
|
2017-11-06 15:10:33 +01:00
|
|
|
|
|
|
|
people.pm_with_user_ids = function () { return [42]; };
|
2020-02-05 14:30:59 +01:00
|
|
|
people.get_by_user_id = function () { return; };
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Unknown people in message');
|
2019-11-02 00:06:25 +01:00
|
|
|
const uri = people.pm_with_url({});
|
2017-11-06 15:10:33 +01:00
|
|
|
assert.equal(uri.indexOf('unk'), uri.length - 3);
|
2020-02-07 22:26:05 +01:00
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Undefined field id');
|
2020-02-07 22:26:05 +01:00
|
|
|
assert.equal(people.my_custom_profile_data(undefined), undefined);
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('error', 'Trying to set undefined field id');
|
2020-02-07 22:26:05 +01:00
|
|
|
people.set_custom_profile_field_data(maria.user_id, {});
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|