2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2020-12-01 00:19:42 +01:00
|
|
|
const {stub_templates} = require("../zjsunit/handlebars");
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
const {rewiremock, set_global, with_field, zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-02-21 15:38:51 +01:00
|
|
|
const $ = require("../zjsunit/zjquery");
|
2020-07-15 01:29:15 +02:00
|
|
|
|
2020-07-16 23:29:01 +02:00
|
|
|
const noop = function () {};
|
2018-04-12 17:43:43 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("current_msg_list", {});
|
|
|
|
set_global("page_params", {
|
2019-07-18 15:21:09 +02:00
|
|
|
is_admin: false,
|
|
|
|
realm_email_address_visibility: 3,
|
2018-04-24 02:24:14 +02:00
|
|
|
custom_profile_fields: [],
|
|
|
|
});
|
2021-03-06 17:37:51 +01:00
|
|
|
const rows = {};
|
2018-04-12 17:43:43 +02:00
|
|
|
|
2021-02-28 01:26:16 +01:00
|
|
|
rewiremock("../../static/js/emoji_picker").with({
|
2018-04-12 17:43:43 +02:00
|
|
|
hide_emoji_popover: noop,
|
|
|
|
});
|
2021-03-06 17:37:51 +01:00
|
|
|
rewiremock("../../static/js/message_viewport").with({
|
|
|
|
height: () => 500,
|
|
|
|
});
|
|
|
|
rewiremock("../../static/js/rows").with(rows);
|
2021-02-28 01:02:37 +01:00
|
|
|
rewiremock("../../static/js/stream_popover").with({
|
2018-04-12 17:43:43 +02:00
|
|
|
hide_stream_popover: noop,
|
|
|
|
hide_topic_popover: noop,
|
|
|
|
hide_all_messages_popover: noop,
|
2019-02-22 12:28:29 +01:00
|
|
|
hide_starred_messages_popover: noop,
|
2019-07-10 02:54:23 +02:00
|
|
|
hide_streamlist_sidebar: noop,
|
2018-04-12 17:43:43 +02:00
|
|
|
});
|
|
|
|
|
2021-03-06 17:37:51 +01:00
|
|
|
const stream_data = {};
|
2021-02-28 00:53:59 +01:00
|
|
|
|
|
|
|
rewiremock("../../static/js/stream_data").with(stream_data);
|
2020-12-01 23:21:38 +01:00
|
|
|
const people = zrequire("people");
|
2021-03-06 17:37:51 +01:00
|
|
|
|
2020-12-01 23:21:38 +01:00
|
|
|
const user_status = zrequire("user_status");
|
|
|
|
const message_edit = zrequire("message_edit");
|
2021-02-22 13:55:34 +01:00
|
|
|
|
|
|
|
// Bypass some scary code that runs when we import the module.
|
2021-02-24 22:31:50 +01:00
|
|
|
const popovers = with_field($.fn, "popover", noop, () => zrequire("popovers"));
|
2018-04-12 17:43:43 +02:00
|
|
|
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
popovers.__Rewire__("ClipboardJS", noop);
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "alice@example.com",
|
|
|
|
full_name: "Alice Smith",
|
2018-04-12 17:43:43 +02:00
|
|
|
user_id: 42,
|
2020-04-07 20:09:30 +02:00
|
|
|
avatar_version: 5,
|
2018-12-17 02:25:00 +01:00
|
|
|
is_guest: false,
|
2019-04-20 18:08:29 +02:00
|
|
|
is_admin: false,
|
2018-04-12 17:43:43 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const me = {
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "me@example.com",
|
2018-04-12 17:43:43 +02:00
|
|
|
user_id: 30,
|
2020-07-15 01:29:15 +02:00
|
|
|
full_name: "Me Myself",
|
2020-10-27 01:41:00 +01:00
|
|
|
timezone: "America/Los_Angeles",
|
2018-04-12 17:43:43 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const e = {
|
2019-06-15 06:31:57 +02:00
|
|
|
stopPropagation: noop,
|
|
|
|
};
|
|
|
|
|
2018-04-12 17:43:43 +02:00
|
|
|
function initialize_people() {
|
|
|
|
people.init();
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(me);
|
|
|
|
people.add_active_user(alice);
|
2018-04-12 17:43:43 +02:00
|
|
|
people.initialize_current_user(me.user_id);
|
|
|
|
}
|
|
|
|
|
|
|
|
initialize_people();
|
|
|
|
|
|
|
|
function make_image_stubber() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const images = [];
|
2018-04-12 17:43:43 +02:00
|
|
|
|
|
|
|
function stub_image() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const image = {};
|
2020-07-02 01:41:40 +02:00
|
|
|
image.to_$ = () => ({
|
|
|
|
on: (name, f) => {
|
|
|
|
assert.equal(name, "load");
|
|
|
|
image.load_f = f;
|
|
|
|
},
|
|
|
|
});
|
2018-04-12 17:43:43 +02:00
|
|
|
images.push(image);
|
|
|
|
return image;
|
|
|
|
}
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("Image", stub_image);
|
2018-04-12 17:43:43 +02:00
|
|
|
|
|
|
|
return {
|
|
|
|
get: (i) => images[i],
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2021-02-21 12:44:39 +01:00
|
|
|
function test_ui(label, f) {
|
|
|
|
run_test(label, (override) => {
|
|
|
|
popovers.register_click_handlers();
|
|
|
|
f(override);
|
|
|
|
});
|
|
|
|
}
|
2018-04-12 17:43:43 +02:00
|
|
|
|
2021-02-21 12:44:39 +01:00
|
|
|
test_ui("sender_hover", (override) => {
|
2021-02-11 01:23:23 +01:00
|
|
|
override(popovers, "hide_user_profile", noop);
|
2021-02-22 13:55:34 +01:00
|
|
|
override($.fn, "popover", noop);
|
2020-07-26 16:38:46 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const selection = ".sender_name, .sender_name-in-status, .inline_profile_picture";
|
2020-07-15 01:29:15 +02:00
|
|
|
const handler = $("#main_div").get_on_handler("click", selection);
|
2018-04-12 17:43:43 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const message = {
|
2018-04-12 17:43:43 +02:00
|
|
|
id: 999,
|
|
|
|
sender_id: alice.user_id,
|
|
|
|
};
|
|
|
|
|
2019-02-01 02:33:01 +01:00
|
|
|
user_status.set_status_text({
|
|
|
|
user_id: alice.user_id,
|
2020-07-15 01:29:15 +02:00
|
|
|
status_text: "on the beach",
|
2019-02-01 02:33:01 +01:00
|
|
|
});
|
|
|
|
|
2018-04-12 17:43:43 +02:00
|
|
|
rows.id = () => message.id;
|
|
|
|
|
|
|
|
current_msg_list.get = (msg_id) => {
|
|
|
|
assert.equal(msg_id, message.id);
|
|
|
|
return message;
|
|
|
|
};
|
|
|
|
|
|
|
|
current_msg_list.select_id = (msg_id) => {
|
|
|
|
assert.equal(msg_id, message.id);
|
|
|
|
};
|
|
|
|
|
2021-02-21 12:44:39 +01:00
|
|
|
const target = $.create("click target");
|
|
|
|
|
2018-04-12 17:43:43 +02:00
|
|
|
target.closest = (sel) => {
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(sel, ".message_row");
|
2018-04-12 17:43:43 +02:00
|
|
|
return {};
|
|
|
|
};
|
|
|
|
|
2020-12-01 00:19:42 +01:00
|
|
|
stub_templates((fn, opts) => {
|
2018-04-12 17:43:43 +02:00
|
|
|
switch (fn) {
|
2020-07-15 00:34:28 +02:00
|
|
|
case "no_arrow_popover":
|
|
|
|
assert.deepEqual(opts, {
|
|
|
|
class: "message-info-popover",
|
|
|
|
});
|
|
|
|
return "popover-html";
|
|
|
|
|
|
|
|
case "user_info_popover_title":
|
|
|
|
assert.deepEqual(opts, {
|
|
|
|
user_avatar: "avatar/alice@example.com",
|
|
|
|
user_is_guest: false,
|
|
|
|
});
|
|
|
|
return "title-html";
|
|
|
|
|
|
|
|
case "user_info_popover_content":
|
|
|
|
assert.deepEqual(opts, {
|
|
|
|
can_set_away: false,
|
|
|
|
can_revoke_away: false,
|
|
|
|
user_full_name: "Alice Smith",
|
|
|
|
user_email: "alice@example.com",
|
|
|
|
user_id: 42,
|
|
|
|
user_time: undefined,
|
|
|
|
user_type: i18n.t("Member"),
|
|
|
|
user_circle_class: "user_circle_empty",
|
|
|
|
user_last_seen_time_status: "translated: More than 2 weeks ago",
|
|
|
|
pm_with_uri: "#narrow/pm-with/42-alice",
|
|
|
|
sent_by_uri: "#narrow/sender/42-alice",
|
|
|
|
private_message_class: "respond_personal_button",
|
|
|
|
show_email: false,
|
|
|
|
show_user_profile: false,
|
|
|
|
is_me: false,
|
|
|
|
is_active: true,
|
|
|
|
is_bot: undefined,
|
|
|
|
is_sender_popover: true,
|
2020-06-27 21:33:09 +02:00
|
|
|
has_message_context: true,
|
2020-07-15 00:34:28 +02:00
|
|
|
status_text: "on the beach",
|
2020-06-27 21:33:09 +02:00
|
|
|
user_mention_syntax: "@**Alice Smith**",
|
2020-07-15 00:34:28 +02:00
|
|
|
});
|
|
|
|
return "content-html";
|
|
|
|
|
|
|
|
default:
|
2020-10-07 09:58:04 +02:00
|
|
|
throw new Error("unrecognized template: " + fn);
|
2018-04-12 17:43:43 +02:00
|
|
|
}
|
2019-07-11 05:06:20 +02:00
|
|
|
});
|
2018-04-12 17:43:43 +02:00
|
|
|
|
2021-02-08 15:48:50 +01:00
|
|
|
$.create(".user_popover_email", {children: []});
|
2019-11-02 00:06:25 +01:00
|
|
|
const image_stubber = make_image_stubber();
|
2020-04-07 20:09:30 +02:00
|
|
|
window.location = {
|
2020-07-15 01:29:15 +02:00
|
|
|
href: "http://chat.zulip.org/",
|
2020-04-07 20:09:30 +02:00
|
|
|
};
|
|
|
|
const base_url = window.location.href;
|
2018-04-12 17:43:43 +02:00
|
|
|
handler.call(target, e);
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const avatar_img = image_stubber.get(0);
|
2020-07-15 01:29:15 +02:00
|
|
|
const expected_url = new URL("avatar/42/medium?v=" + alice.avatar_version, base_url);
|
2020-04-07 20:09:30 +02:00
|
|
|
assert.equal(avatar_img.src.toString(), expected_url.toString());
|
2018-04-12 17:43:43 +02:00
|
|
|
|
|
|
|
// todo: load image
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2019-06-15 06:31:57 +02:00
|
|
|
|
2021-02-21 12:44:39 +01:00
|
|
|
test_ui("actions_popover", (override) => {
|
2021-02-22 13:55:34 +01:00
|
|
|
override($.fn, "popover", noop);
|
|
|
|
|
2021-02-21 12:44:39 +01:00
|
|
|
const target = $.create("click target");
|
|
|
|
|
2021-02-11 01:23:23 +01:00
|
|
|
override(popovers, "hide_user_profile", noop);
|
2020-07-26 16:38:46 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
const handler = $("#main_div").get_on_handler("click", ".actions_hover");
|
2019-06-15 06:31:57 +02:00
|
|
|
|
|
|
|
window.location = {
|
2020-07-15 01:29:15 +02:00
|
|
|
protocol: "http:",
|
|
|
|
host: "chat.zulip.org",
|
|
|
|
pathname: "/",
|
2019-06-15 06:31:57 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const message = {
|
2019-06-15 06:31:57 +02:00
|
|
|
id: 999,
|
2020-07-15 01:29:15 +02:00
|
|
|
topic: "Actions (1)",
|
|
|
|
type: "stream",
|
2019-06-15 06:31:57 +02:00
|
|
|
stream_id: 123,
|
|
|
|
};
|
|
|
|
|
|
|
|
current_msg_list.get = (msg_id) => {
|
|
|
|
assert.equal(msg_id, message.id);
|
|
|
|
return message;
|
|
|
|
};
|
|
|
|
|
2021-02-28 00:56:21 +01:00
|
|
|
message_edit.__Rewire__("get_editability", () => 4);
|
2019-06-15 06:31:57 +02:00
|
|
|
|
|
|
|
stream_data.id_to_slug = (stream_id) => {
|
|
|
|
assert.equal(stream_id, 123);
|
2020-07-15 01:29:15 +02:00
|
|
|
return "Bracket ( stream";
|
2019-06-15 06:31:57 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
target.closest = (sel) => {
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(sel, ".message_row");
|
2019-06-15 06:31:57 +02:00
|
|
|
return {
|
|
|
|
toggleClass: noop,
|
|
|
|
};
|
|
|
|
};
|
|
|
|
|
2020-12-01 00:19:42 +01:00
|
|
|
stub_templates((fn, opts) => {
|
2019-06-15 06:31:57 +02:00
|
|
|
// TODO: Test all the properties of the popover
|
|
|
|
switch (fn) {
|
2020-07-15 00:34:28 +02:00
|
|
|
case "actions_popover_content":
|
|
|
|
assert.equal(
|
|
|
|
opts.conversation_time_uri,
|
|
|
|
"http://chat.zulip.org/#narrow/stream/Bracket.20%28.20stream/topic/Actions.20%281%29/near/999",
|
|
|
|
);
|
|
|
|
return "actions-content";
|
|
|
|
default:
|
2020-10-07 09:58:04 +02:00
|
|
|
throw new Error("unrecognized template: " + fn);
|
2019-06-15 06:31:57 +02:00
|
|
|
}
|
2019-07-11 05:06:20 +02:00
|
|
|
});
|
2019-06-15 06:31:57 +02:00
|
|
|
|
|
|
|
handler.call(target, e);
|
|
|
|
});
|