2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2020-12-01 00:02:16 +01:00
|
|
|
const {set_global, zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-02-21 15:38:51 +01:00
|
|
|
const $ = require("../zjsunit/zjquery");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("page_params", {
|
2018-07-14 12:46:02 +02:00
|
|
|
search_pills_enabled: true,
|
|
|
|
});
|
2021-02-10 04:53:22 +01:00
|
|
|
const search = zrequire("search");
|
|
|
|
const search_pill = zrequire("search_pill");
|
|
|
|
const Filter = zrequire("Filter", "js/filter");
|
2020-07-08 23:44:01 +02:00
|
|
|
zrequire("message_view_header");
|
2018-06-22 12:19:40 +02:00
|
|
|
|
|
|
|
const noop = () => {};
|
|
|
|
const return_true = () => true;
|
|
|
|
const return_false = () => false;
|
|
|
|
|
2021-02-10 04:53:22 +01:00
|
|
|
const narrow_state = set_global("narrow_state", {filter: return_false});
|
|
|
|
const search_suggestion = set_global("search_suggestion", {});
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("ui_util", {
|
2018-06-22 12:19:40 +02:00
|
|
|
change_tab_to: noop,
|
2020-06-09 12:59:12 +02:00
|
|
|
place_caret_at_end: noop,
|
2018-06-22 12:19:40 +02:00
|
|
|
});
|
2021-02-10 04:53:22 +01:00
|
|
|
const narrow = set_global("narrow", {});
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("search_pill_widget", {
|
2020-06-18 17:17:11 +02:00
|
|
|
widget: {
|
|
|
|
getByID: return_true,
|
|
|
|
},
|
|
|
|
});
|
2018-07-14 16:10:00 +02:00
|
|
|
|
2020-12-01 00:02:16 +01:00
|
|
|
set_global("setTimeout", (func) => func());
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("clear_search_form", () => {
|
|
|
|
$("#search_query").val("noise");
|
2020-07-20 21:24:26 +02:00
|
|
|
$("#search_query").trigger("focus");
|
2020-07-15 01:29:15 +02:00
|
|
|
$(".search_button").prop("disabled", false);
|
Simplify narrow/search interactions.
Before this change, if you hit ESC, then hotkey
code would call search.clear_search, which would
call narrow.deactivate(), which would then use
`$('#search_query')` to clear a value, but then
let search.clear_search blur the input and
disable the exit button. It was all confusing.
Things are a bit more organized now.
Now the code works like this:
hotkey.process_escape_key
Just call narrow.deactivate.
$('#search_exit').on('click', ...):
Just call narrow.deactivate.
narrow.deactivate:
Just call search.clear_search_form
search.clear_search_form:
Just do simple jquery stuff. Don't
change the entire user's narrow, not
even indirectly!
There's still a two-way interaction between
the narrow.js module and the search.js module,
but in each direction it's a one-liner.
The guiding principle here is that we only
want one top-level API, which is narrow.deactivate,
and that does the whole "kitchen sink" of
clearing searches, closing popovers, switching
in views, etc. And then all the functions it
calls out to tend to have much smaller jobs to
do.
This commit can mostly be considered a refactoring, but the
order of operations changes slightly. Basically, as
soon as you hit ESC or click on the search "X", we
clear the search widget. Most users won't notice
any difference, because we don't have to hit the
server to populate the home view. And it's arguably
an improvement to give more immediate feedback.
2018-09-10 19:36:58 +02:00
|
|
|
|
|
|
|
search.clear_search_form();
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($("#search_query").is_focused(), false);
|
|
|
|
assert.equal($("#search_query").val(), "");
|
|
|
|
assert.equal($(".search_button").prop("disabled"), true);
|
Simplify narrow/search interactions.
Before this change, if you hit ESC, then hotkey
code would call search.clear_search, which would
call narrow.deactivate(), which would then use
`$('#search_query')` to clear a value, but then
let search.clear_search blur the input and
disable the exit button. It was all confusing.
Things are a bit more organized now.
Now the code works like this:
hotkey.process_escape_key
Just call narrow.deactivate.
$('#search_exit').on('click', ...):
Just call narrow.deactivate.
narrow.deactivate:
Just call search.clear_search_form
search.clear_search_form:
Just do simple jquery stuff. Don't
change the entire user's narrow, not
even indirectly!
There's still a two-way interaction between
the narrow.js module and the search.js module,
but in each direction it's a one-liner.
The guiding principle here is that we only
want one top-level API, which is narrow.deactivate,
and that does the whole "kitchen sink" of
clearing searches, closing popovers, switching
in views, etc. And then all the functions it
calls out to tend to have much smaller jobs to
do.
This commit can mostly be considered a refactoring, but the
order of operations changes slightly. Basically, as
soon as you hit ESC or click on the search "X", we
clear the search widget. Most users won't notice
any difference, because we don't have to hit the
server to populate the home view. And it's arguably
an improvement to give more immediate feedback.
2018-09-10 19:36:58 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("update_button_visibility", () => {
|
|
|
|
const search_query = $("#search_query");
|
|
|
|
const search_button = $(".search_button");
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-05-31 16:47:55 +02:00
|
|
|
search_query.is = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_query.val("");
|
2020-05-31 16:47:55 +02:00
|
|
|
narrow_state.active = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_button.prop("disabled", true);
|
2020-05-31 16:47:55 +02:00
|
|
|
search.update_button_visibility();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert(search_button.prop("disabled"));
|
2020-05-31 16:47:55 +02:00
|
|
|
|
2018-06-22 12:19:40 +02:00
|
|
|
search_query.is = return_true;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_query.val("");
|
2018-06-22 12:19:40 +02:00
|
|
|
narrow_state.active = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_button.prop("disabled", true);
|
2018-06-22 12:19:40 +02:00
|
|
|
search.update_button_visibility();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert(!search_button.prop("disabled"));
|
2018-06-22 12:19:40 +02:00
|
|
|
|
|
|
|
search_query.is = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_query.val("Test search term");
|
2018-06-22 12:19:40 +02:00
|
|
|
narrow_state.active = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_button.prop("disabled", true);
|
2018-06-22 12:19:40 +02:00
|
|
|
search.update_button_visibility();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert(!search_button.prop("disabled"));
|
2018-06-22 12:19:40 +02:00
|
|
|
|
|
|
|
search_query.is = return_false;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_query.val("");
|
2018-06-22 12:19:40 +02:00
|
|
|
narrow_state.active = return_true;
|
2020-07-15 01:29:15 +02:00
|
|
|
search_button.prop("disabled", true);
|
2018-06-22 12:19:40 +02:00
|
|
|
search.update_button_visibility();
|
2020-07-15 01:29:15 +02:00
|
|
|
assert(!search_button.prop("disabled"));
|
2018-06-22 12:19:40 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("initialize", () => {
|
|
|
|
const search_query_box = $("#search_query");
|
|
|
|
const searchbox_form = $("#searchbox_form");
|
|
|
|
const search_button = $(".search_button");
|
|
|
|
const searchbox = $("#searchbox");
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2021-02-22 17:01:29 +01:00
|
|
|
search_query_box[0] = "stub";
|
|
|
|
|
2021-02-23 14:37:26 +01:00
|
|
|
search_pill.get_search_string_for_current_filter = () => "is:starred";
|
2018-07-02 22:30:18 +02:00
|
|
|
|
2019-12-25 16:58:11 +01:00
|
|
|
search_suggestion.max_num_of_search_results = 99;
|
2018-06-22 12:19:40 +02:00
|
|
|
search_query_box.typeahead = (opts) => {
|
|
|
|
assert.equal(opts.fixed, true);
|
2019-12-25 16:58:11 +01:00
|
|
|
assert.equal(opts.items, 99);
|
2018-06-22 12:19:40 +02:00
|
|
|
assert.equal(opts.naturalSearch, true);
|
2018-12-04 22:55:55 +01:00
|
|
|
assert.equal(opts.helpOnEmptyStrings, true);
|
2018-06-22 12:19:40 +02:00
|
|
|
assert.equal(opts.matcher(), true);
|
2020-09-24 07:50:36 +02:00
|
|
|
opts.on_move();
|
2018-06-22 12:19:40 +02:00
|
|
|
|
|
|
|
{
|
|
|
|
const search_suggestions = {
|
2020-02-12 06:58:20 +01:00
|
|
|
lookup_table: new Map([
|
2020-07-15 00:34:28 +02:00
|
|
|
[
|
|
|
|
"stream:Verona",
|
|
|
|
{
|
|
|
|
description: "Stream <strong>Ver</strong>ona",
|
|
|
|
search_string: "stream:Verona",
|
|
|
|
},
|
|
|
|
],
|
|
|
|
[
|
|
|
|
"ver",
|
|
|
|
{
|
|
|
|
description: "Search for ver",
|
|
|
|
search_string: "ver",
|
|
|
|
},
|
|
|
|
],
|
2020-02-12 06:58:20 +01:00
|
|
|
]),
|
2020-07-15 01:29:15 +02:00
|
|
|
strings: ["ver", "stream:Verona"],
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
/* Test source */
|
|
|
|
search_suggestion.get_suggestions = () => search_suggestions;
|
|
|
|
const expected_source_value = search_suggestions.strings;
|
2020-07-15 01:29:15 +02:00
|
|
|
const source = opts.source("ver");
|
2018-06-22 12:19:40 +02:00
|
|
|
assert.equal(source, expected_source_value);
|
|
|
|
|
|
|
|
/* Test highlighter */
|
2020-07-15 01:29:15 +02:00
|
|
|
let expected_value = "Search for ver";
|
2018-06-22 12:19:40 +02:00
|
|
|
assert.equal(opts.highlighter(source[0]), expected_value);
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
expected_value = "Stream <strong>Ver</strong>ona";
|
2018-06-22 12:19:40 +02:00
|
|
|
assert.equal(opts.highlighter(source[1]), expected_value);
|
|
|
|
|
|
|
|
/* Test sorter */
|
|
|
|
assert.equal(opts.sorter(search_suggestions.strings), search_suggestions.strings);
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
let operators;
|
|
|
|
let is_blurred;
|
2018-07-14 16:10:00 +02:00
|
|
|
let is_append_search_string_called;
|
2020-07-21 00:23:06 +02:00
|
|
|
search_query_box.on("blur", () => {
|
2018-06-22 12:19:40 +02:00
|
|
|
is_blurred = true;
|
2020-07-21 00:23:06 +02:00
|
|
|
});
|
2018-07-14 16:10:00 +02:00
|
|
|
search_pill.append_search_string = () => {
|
|
|
|
is_append_search_string_called = true;
|
|
|
|
};
|
2018-06-22 12:19:40 +02:00
|
|
|
/* Test updater */
|
|
|
|
const _setup = (search_box_val) => {
|
|
|
|
is_blurred = false;
|
2018-07-14 16:10:00 +02:00
|
|
|
is_append_search_string_called = false;
|
2018-06-22 12:19:40 +02:00
|
|
|
search_query_box.val(search_box_val);
|
2020-05-31 16:47:55 +02:00
|
|
|
Filter.parse = (search_string) => {
|
|
|
|
assert.equal(search_string, search_box_val);
|
|
|
|
return operators;
|
|
|
|
};
|
2018-06-22 12:19:40 +02:00
|
|
|
narrow.activate = (raw_operators, options) => {
|
|
|
|
assert.deepEqual(raw_operators, operators);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.deepEqual(options, {trigger: "search"});
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
2020-07-02 01:41:40 +02:00
|
|
|
search_pill.get_search_string_for_current_filter = () => search_box_val;
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
operators = [
|
|
|
|
{
|
|
|
|
negated: false,
|
|
|
|
operator: "search",
|
|
|
|
operand: "ver",
|
|
|
|
},
|
|
|
|
];
|
2020-07-15 01:29:15 +02:00
|
|
|
_setup("ver");
|
2020-05-31 16:47:55 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(opts.updater("ver"), "ver");
|
2020-05-10 03:58:57 +02:00
|
|
|
assert(!is_blurred);
|
2018-07-14 16:10:00 +02:00
|
|
|
assert(is_append_search_string_called);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
operators = [
|
|
|
|
{
|
|
|
|
negated: false,
|
|
|
|
operator: "stream",
|
|
|
|
operand: "Verona",
|
|
|
|
},
|
|
|
|
];
|
2020-07-15 01:29:15 +02:00
|
|
|
_setup("stream:Verona");
|
2020-05-31 16:47:55 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(opts.updater("stream:Verona"), "stream:Verona");
|
2020-05-10 03:58:57 +02:00
|
|
|
assert(!is_blurred);
|
2018-07-14 16:10:00 +02:00
|
|
|
assert(is_append_search_string_called);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
|
|
|
search.is_using_input_method = true;
|
2020-07-15 01:29:15 +02:00
|
|
|
_setup("stream:Verona");
|
2020-05-31 16:47:55 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(opts.updater("stream:Verona"), "stream:Verona");
|
2018-06-22 12:19:40 +02:00
|
|
|
assert(!is_blurred);
|
2018-07-14 16:10:00 +02:00
|
|
|
assert(is_append_search_string_called);
|
2020-07-21 00:23:06 +02:00
|
|
|
|
|
|
|
search_query_box.off("blur");
|
2018-06-22 12:19:40 +02:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
search.initialize();
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
const search_pill_stub = $.create(".pill");
|
|
|
|
search_pill_stub.closest = () => ({data: noop});
|
|
|
|
const stub_event = {
|
|
|
|
relatedTarget: search_pill_stub,
|
|
|
|
};
|
|
|
|
search_query_box.val("test string");
|
|
|
|
narrow_state.search_string = () => "ver";
|
2020-12-11 04:26:23 +01:00
|
|
|
search_query_box.trigger(new $.Event("blur", stub_event));
|
2020-07-21 00:23:06 +02:00
|
|
|
assert.equal(search_query_box.val(), "test string");
|
|
|
|
|
|
|
|
searchbox.css({"box-shadow": "inset 0px 0px 0px 2px hsl(204, 20%, 74%)"});
|
|
|
|
searchbox.trigger("focusout");
|
|
|
|
assert.deepEqual(searchbox.css(), {"box-shadow": "unset"});
|
|
|
|
|
|
|
|
search.is_using_input_method = false;
|
|
|
|
searchbox_form.trigger("compositionend");
|
|
|
|
assert(search.is_using_input_method);
|
|
|
|
|
|
|
|
const keydown = searchbox_form.get_on_handler("keydown");
|
2020-09-24 07:50:36 +02:00
|
|
|
let default_prevented = false;
|
2020-07-21 00:23:06 +02:00
|
|
|
let ev = {
|
|
|
|
type: "keydown",
|
|
|
|
which: 15,
|
2020-09-24 07:50:36 +02:00
|
|
|
preventDefault() {
|
|
|
|
default_prevented = true;
|
|
|
|
},
|
2020-07-21 00:23:06 +02:00
|
|
|
};
|
|
|
|
search_query_box.is = return_false;
|
|
|
|
assert.equal(keydown(ev), undefined);
|
2020-09-24 07:50:36 +02:00
|
|
|
assert(!default_prevented);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
ev.which = 13;
|
|
|
|
assert.equal(keydown(ev), undefined);
|
2020-09-24 07:50:36 +02:00
|
|
|
assert(!default_prevented);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
ev.which = 13;
|
|
|
|
search_query_box.is = return_true;
|
2020-09-24 07:50:36 +02:00
|
|
|
assert.equal(keydown(ev), undefined);
|
|
|
|
assert(default_prevented);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
let operators;
|
|
|
|
let is_blurred;
|
|
|
|
narrow_state.active = return_false;
|
|
|
|
search_query_box.off("blur");
|
|
|
|
search_query_box.on("blur", () => {
|
|
|
|
is_blurred = true;
|
|
|
|
});
|
|
|
|
|
|
|
|
const _setup = (search_box_val) => {
|
|
|
|
is_blurred = false;
|
|
|
|
search_button.prop("disabled", false);
|
|
|
|
search_query_box.val(search_box_val);
|
|
|
|
Filter.parse = (search_string) => {
|
|
|
|
assert.equal(search_string, search_box_val);
|
|
|
|
return operators;
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
2020-07-21 00:23:06 +02:00
|
|
|
narrow.activate = (raw_operators, options) => {
|
|
|
|
assert.deepEqual(raw_operators, operators);
|
|
|
|
assert.deepEqual(options, {trigger: "search"});
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
2020-07-21 00:23:06 +02:00
|
|
|
search_pill.get_search_string_for_current_filter = () => search_box_val;
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
operators = [
|
|
|
|
{
|
|
|
|
negated: false,
|
|
|
|
operator: "search",
|
|
|
|
operand: "",
|
|
|
|
},
|
|
|
|
];
|
|
|
|
_setup("");
|
|
|
|
|
|
|
|
ev = {
|
|
|
|
type: "keyup",
|
|
|
|
which: 15,
|
2018-06-22 12:19:40 +02:00
|
|
|
};
|
2020-07-21 00:23:06 +02:00
|
|
|
search_query_box.is = return_false;
|
|
|
|
searchbox_form.trigger(ev);
|
2018-06-22 12:19:40 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
assert(!is_blurred);
|
|
|
|
assert(!search_button.prop("disabled"));
|
2020-07-14 21:26:28 +02:00
|
|
|
|
2020-07-21 00:23:06 +02:00
|
|
|
ev.which = 13;
|
|
|
|
search_query_box.is = return_false;
|
|
|
|
searchbox_form.trigger(ev);
|
|
|
|
|
|
|
|
assert(!is_blurred);
|
|
|
|
assert(!search_button.prop("disabled"));
|
|
|
|
|
|
|
|
ev.which = 13;
|
|
|
|
search_query_box.is = return_true;
|
|
|
|
searchbox_form.trigger(ev);
|
|
|
|
assert(is_blurred);
|
|
|
|
|
|
|
|
_setup("ver");
|
|
|
|
search.is_using_input_method = true;
|
|
|
|
searchbox_form.trigger(ev);
|
2020-08-11 02:09:14 +02:00
|
|
|
// No change on Enter keyup event when using input tool
|
2020-07-21 00:23:06 +02:00
|
|
|
assert(!is_blurred);
|
|
|
|
assert(!search_button.prop("disabled"));
|
|
|
|
|
|
|
|
_setup("ver");
|
|
|
|
ev.which = 13;
|
|
|
|
search_query_box.is = return_true;
|
|
|
|
searchbox_form.trigger(ev);
|
|
|
|
assert(is_blurred);
|
|
|
|
assert(!search_button.prop("disabled"));
|
|
|
|
|
|
|
|
search_button.prop("disabled", true);
|
|
|
|
search_query_box.trigger("focus");
|
|
|
|
assert(!search_button.prop("disabled"));
|
2018-06-22 12:19:40 +02:00
|
|
|
});
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("initiate_search", () => {
|
2020-05-31 15:53:39 +02:00
|
|
|
// open typeahead and select text when navbar is open
|
|
|
|
// this implicitly expects the code to used the chained
|
|
|
|
// function calls, which is something to keep in mind if
|
|
|
|
// this test ever fails unexpectedly.
|
|
|
|
let typeahead_forced_open = false;
|
|
|
|
let is_searchbox_text_selected = false;
|
2018-07-23 17:14:53 +02:00
|
|
|
let is_searchbox_focused = false;
|
2020-07-21 00:23:06 +02:00
|
|
|
$("#search_query").off("focus");
|
|
|
|
$("#search_query").on("focus", () => {
|
2018-07-23 17:14:53 +02:00
|
|
|
is_searchbox_focused = true;
|
2020-07-21 00:23:06 +02:00
|
|
|
});
|
2020-07-15 01:29:15 +02:00
|
|
|
$("#search_query").typeahead = (lookup) => {
|
2020-05-31 15:53:39 +02:00
|
|
|
if (lookup === "lookup") {
|
|
|
|
typeahead_forced_open = true;
|
|
|
|
}
|
2020-07-22 04:50:11 +02:00
|
|
|
return $("#search_query");
|
2020-05-31 15:53:39 +02:00
|
|
|
};
|
2020-07-22 04:50:11 +02:00
|
|
|
$("#search_query").on("select", () => {
|
|
|
|
is_searchbox_text_selected = true;
|
|
|
|
});
|
2020-05-31 15:53:39 +02:00
|
|
|
|
2021-02-23 12:15:40 +01:00
|
|
|
$("#search_query")[0] = "stub";
|
|
|
|
|
2018-06-22 12:19:40 +02:00
|
|
|
search.initiate_search();
|
2020-05-31 15:53:39 +02:00
|
|
|
assert(typeahead_forced_open);
|
|
|
|
assert(is_searchbox_text_selected);
|
2018-07-23 17:14:53 +02:00
|
|
|
assert(is_searchbox_focused);
|
2018-06-22 12:19:40 +02:00
|
|
|
});
|