Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/tests
History
Greg Price 0213aa0b16 push notif: Don't forget to clear "active" flag on sending to bouncer. 
Since da8f4bc0e back in August, this control flow has caused
`flags.active_mobile_push_notification` to be cleared if we don't send
these `remove` messages at all, and if we send them directly to GCM...
but not if we send them via the Zulip notification bouncer.

As a result, on a server configured to send `remove` notification-messages
via the bouncer, we accumulate "active" messages and never clear them.

If the user then does `mark_all_as_read`, we end up sending a `remove`
for each of those messages again, and all in one giant burst.  We've
seen puzzling bursts of hundreds of removals pass through the bouncer
since turning on removals on chat.zulip.org; it's likely many of them
are caused by this bug.

This issue was made more acute with f4478aad5, which unconditionally
enabled removals.

Test added by tabbott.
 		2019-02-14 14:52:53 -08:00
..
fixtures markdown: Disable definition/reference links in marked. 2019-02-04 11:16:37 -08:00
images emoji: Only resize custom emoji that need it. 2019-01-29 10:33:50 -08:00
__init__.py
…
test_alert_words.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_archive.py archives: Change the topic/<topic_name> code path to use topics prefix. 2018-07-14 10:39:35 +05:30
test_attachments.py lint: Prevent `self: Any` annotations. 2017-12-08 19:00:18 -08:00
test_audit_log.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_auth_backends.py auth2: Don't use session for passing multiuse invite key. 2019-02-12 15:51:11 -08:00
test_bots.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_bugdown.py tests: Use subTest in test_bugdown_fixtures. 2019-02-13 10:49:13 -08:00
test_cache.py tests: Add 100% test coverage to zerver/apps.py. 2018-05-14 10:36:10 -07:00
test_camo.py camo: Add endpoint to handle camo requests. 2019-01-04 10:27:04 -08:00
test_compatibility.py compatibility: Respond with HTTP 400 when no User-Agent header. 2018-12-10 15:04:34 -08:00
test_create_video_call.py zoom: Fix coverage of new zoom error handling code path. 2019-01-16 15:58:26 -08:00
test_custom_profile_data.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_decorators.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_digest.py digest_email: Add endpoint for rendering digest to the web. 2018-12-11 13:38:30 -08:00
test_docs.py zerver/views: Rename integrations.py to documentation.py. 2019-02-11 21:25:14 -08:00
test_email_change.py emails: Remove newlines from translated strings in email templates. 2019-02-10 12:28:17 -08:00
test_email_log.py emails: Don't log emails while running test suite. 2018-10-11 15:12:08 -07:00
test_email_mirror.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_embedded_bot_system.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_event_queue.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_events.py search: Add stop words to page_params. 2019-02-05 10:23:28 -08:00
test_external.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_feedback.py Add basic test for FeedbackBot. 2018-03-04 13:31:33 -08:00
test_gitter_importer.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_hipchat_importer.py hipchat: Limit messages in slim mode. 2018-11-26 16:37:30 -08:00
test_home.py search: Add stop words to page_params. 2019-02-05 10:23:28 -08:00
test_hotspots.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_i18n.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_import_export.py import: Fix tests related to plan_type. 2019-02-12 18:11:31 -08:00
test_json_encoder_for_html.py zerver: Remove simplejson dependency. 2017-11-21 21:51:48 -08:00
test_legacy_subject.py Add alias support to REQ helpers for subject/topic. 2018-11-12 15:47:11 -08:00
test_link_embed.py tests: Fix test broken by recent url preview change. 2019-02-05 13:45:00 -08:00
test_logging_handlers.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_management_commands.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_message_edit_notifications.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_messages.py streams: Refactor multi-option helpers into separate functions. 2019-02-12 11:10:26 -08:00
test_middleware.py open graph: Remove extraneous spaces from descriptions. 2019-02-11 12:05:19 -08:00
test_migrations.py migration_tests: Document the migration test framework. 2018-05-21 09:59:55 -07:00
test_muting.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_narrow.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_new_users.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_notifications.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_onboarding.py create_realm_internal_bots: Refactor to extract main op as a function. 2018-05-23 11:53:22 +05:30
test_openapi.py api docs: Load the OpenAPI file only when needed. 2018-08-08 09:00:28 -07:00
test_outgoing_webhook_interfaces.py test_outgoing_webhook_interfaces: Don’t mock an unused import. 2019-02-02 17:28:11 -08:00
test_outgoing_webhook_system.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_presence.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_push_notifications.py push notif: Don't forget to clear "active" flag on sending to bouncer. 2019-02-14 14:52:53 -08:00
test_queue.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_queue_worker.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_reactions.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_realm.py tests: Use subTest in test_update_realm_properties. 2019-02-13 10:49:13 -08:00
test_realm_domains.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_realm_emoji.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_realm_filters.py docs: Advertise arbitrary org GitHub patterns for linkifiers. 2018-12-17 12:58:52 -08:00
test_report.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_retention.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_service_bot_system.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_sessions.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_settings.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_signup.py auth2: Don't use session for passing multiuse invite key. 2019-02-12 15:51:11 -08:00
test_slack_importer.py tests: Fix import test failure. 2019-02-12 17:46:55 -08:00
test_slack_message_conversion.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_soft_deactivation.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_subdomains.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_submessage.py events: Pass a realm object into send_event. 2018-11-02 16:47:39 -07:00
test_subs.py internal_prep_stream_message: Support accepting a Stream object. 2019-02-08 08:53:16 -08:00
test_templates.py help: Add tab styling to untabbed instructions as well. 2019-02-11 12:05:19 -08:00
test_thumbnail.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_timestamp.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_tornado.py tornado: Remove unused imports. 2019-02-02 17:33:13 -08:00
test_transfer.py management: Add tooling for transfering local uploads to s3. 2019-02-14 14:31:46 -08:00
test_tutorial.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_type_debug.py mypy: Remove some now-unnecessary type: ignores. 2018-03-28 10:39:05 -07:00
test_typing.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_unread.py push notif: Unconditionally remove notifications on message read. 2019-02-13 13:13:45 -08:00
test_upload.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_urls.py docs: Fix 500s with super long fake /help/ article URLs. 2018-12-03 14:43:45 -08:00
test_user_groups.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_user_status.py user status: Add "status_text" support in the backend. 2019-01-24 09:46:35 -08:00
test_users.py tests: Use subTest in test_admin_user_can_change_profile_data. 2019-02-13 10:50:39 -08:00
test_webhooks_common.py tools: Upgrade Pycodestyle and fix new linter errors. 2019-01-31 12:21:41 -08:00
test_widgets.py widgets: Remove ALLOW_SUB_MESSAGES flag and enable widgets by default. 2019-01-29 09:34:14 -08:00
test_zcommand.py zcommand: Raise error when command doesn't begin with a slash. 2018-07-01 20:32:36 -04:00
test_zephyr.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
tests.py
…