Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/lib
History
Greg Price 0213aa0b16 push notif: Don't forget to clear "active" flag on sending to bouncer. 
Since da8f4bc0e back in August, this control flow has caused
`flags.active_mobile_push_notification` to be cleared if we don't send
these `remove` messages at all, and if we send them directly to GCM...
but not if we send them via the Zulip notification bouncer.

As a result, on a server configured to send `remove` notification-messages
via the bouncer, we accumulate "active" messages and never clear them.

If the user then does `mark_all_as_read`, we end up sending a `remove`
for each of those messages again, and all in one giant burst.  We've
seen puzzling bursts of hundreds of removals pass through the bouncer
since turning on removals on chat.zulip.org; it's likely many of them
are caused by this bug.

This issue was made more acute with f4478aad5, which unconditionally
enabled removals.

Test added by tabbott.
 		2019-02-14 14:52:53 -08:00
..
bugdown help: Add tab styling to untabbed instructions as well. 2019-02-11 12:05:19 -08:00
url_preview url preview: Remove useless logging.error in open graph code path. 2019-02-05 13:25:47 -08:00
webhooks zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
__init__.py
…
actions.py streams: Refactor multi-option helpers into separate functions. 2019-02-12 11:10:26 -08:00
addressee.py internal_prep_stream_message: Support accepting a Stream object. 2019-02-08 08:53:16 -08:00
alert_words.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
api_test_helpers.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
attachments.py
…
avatar.py python: Clean up various if False blocks. 2018-12-17 11:14:47 -08:00
avatar_hash.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
bot_config.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
bot_lib.py streams: Refactor multi-option helpers into separate functions. 2019-02-12 11:10:26 -08:00
bot_storage.py python: Stop importing Length from the wrong file. 2019-02-02 17:09:10 -08:00
bulk_create.py email: Set email based on realm email_address_visibility. 2019-02-04 18:45:10 -08:00
cache.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
cache_helpers.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
camo.py camo: Add endpoint to handle camo requests. 2019-01-04 10:27:04 -08:00
ccache.py str_utils: Move force_bytes into ccache.py. 2018-05-15 19:07:32 -07:00
context_managers.py
…
create_user.py email: Set email based on realm email_address_visibility. 2019-02-04 18:45:10 -08:00
db.py python: Remove unnecessary NonBinaryStr TypeVar. 2018-11-27 11:44:09 -08:00
debug.py mypy: Set local_partial_types = True. 2018-05-21 22:41:00 -07:00
dev_ldap_directory.py dev_ldap: Add custom profile data. 2019-01-29 16:01:30 -08:00
digest.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
domains.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
email_mirror.py email mirror: Fix missing variable for logging. 2019-02-13 13:16:55 -08:00
emoji.py emoji: Move `EMOTICON_CONVERSIONS` mapping to build_emoji infra. 2018-07-23 12:35:08 -07:00
error_notify.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
events.py search: Add stop words to page_params. 2019-02-05 10:23:28 -08:00
exceptions.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
export.py export: Correctly treat emoji author field as optional. 2019-02-13 16:12:06 -08:00
feedback.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
fix_unreads.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
generate_test_data.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
hotspots.py hotspots: Add hotspot for gear menu. 2019-02-05 12:19:21 -08:00
html_diff.py
…
i18n.py i18n: Pass translation data in page_params. 2018-05-30 08:57:26 -07:00
import_realm.py import: Set plan_type to SELF_HOSTED on import. 2019-02-12 16:01:02 -08:00
initial_password.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
integrations.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
json_encoder_for_html.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
logging_util.py
…
management.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
mdiff.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
mention.py markdown: Add _@**Name** syntax for silent mentions. 2019-01-16 16:01:06 -08:00
message.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
migrate.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
mobile_auth_otp.py mobile: Make otp_encrypt_api_key accept API keys. 2018-08-08 16:45:40 -07:00
name_restrictions.py signup: Add opayq.com to disposable domain whitelist. 2018-08-13 10:56:47 -07:00
narrow.py search: Add stop words to page_params. 2019-02-05 10:23:28 -08:00
notifications.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
onboarding.py streams: Refactor multi-option helpers into separate functions. 2019-02-12 11:10:26 -08:00
openapi.py Minimize race conditions for reading zulip.yaml. 2018-09-12 11:07:20 -07:00
outgoing_webhook.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
parallel.py
…
profile.py
…
push_notifications.py push notif: Don't forget to clear "active" flag on sending to bouncer. 2019-02-14 14:52:53 -08:00
queue.py requirements: Upgrade pika from 0.12.0 to 0.13.0. 2019-01-31 10:04:07 -08:00
rate_limiter.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
realm_icon.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
realm_logo.py settings: Add support for customizing the top-left logo. 2018-12-18 12:44:52 -08:00
redis_utils.py
…
remote_server.py notifications: Don't send error emails on bouncer 500s. 2019-02-11 21:19:28 -08:00
request.py requirements: Upgrade pyflakes. 2019-02-01 07:26:13 -08:00
request.pyi extract_recipients: Support user IDs. 2019-01-08 19:08:49 -03:30
response.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
rest.py report: Allow error-reporting views from unauthed users. 2018-12-16 15:44:48 -08:00
retention.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
send_email.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
sessions.py sessions: Suppress coverage error until we can debug. 2018-12-01 10:08:57 -08:00
soft_deactivation.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
sqlalchemy_utils.py mypy: Set local_partial_types = True. 2018-05-21 22:41:00 -07:00
statistics.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
storage.py python: Remove now-unnecessary str_utils library. 2018-11-27 11:57:54 -08:00
stream_recipient.py
…
stream_subscription.py
…
stream_topic.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
streams.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
subdomains.py Enable pycodestyle W605 (invalid escape sequence). 2018-07-03 16:54:46 +02:00
test_classes.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
test_data.source.txt
…
test_fixtures.py test_fixtures: Fix bug with run_db_migrations for test platform. 2018-07-09 14:17:53 +05:30
test_helpers.py tests: Fix broken avatar_disk_path for original size input. 2019-02-14 14:18:03 -08:00
test_runner.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
tex.py Enable pycodestyle W605 (invalid escape sequence). 2018-07-03 16:54:46 +02:00
thumbnail.py camo: Add endpoint to handle camo requests. 2019-01-04 10:27:04 -08:00
timeout.py mypy: Add assertion in timeout.py. 2018-04-25 08:58:55 -07:00
timestamp.py
…
timezone.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
topic.py topics: Fix messages_for_topic to use iexact matching. 2019-01-24 17:55:15 -08:00
topic_mutes.py Extract topic_match_sa() helper. 2018-11-07 10:03:53 -08:00
transfer.py management: Add tooling for transfering local uploads to s3. 2019-02-14 14:31:46 -08:00
type_debug.py zerver/lib: Change use of typing.Text to str. 2018-05-10 14:19:49 -07:00
types.py extract_recipients: Support user IDs. 2019-01-08 19:08:49 -03:30
unminify.py unminify: Clean up unnecessary repetition of webpack:/// URLs. 2018-08-03 15:56:40 -07:00
upload.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
url_encoding.py topic -> subject: Extract get_topic_from_message_info(). 2018-11-14 23:24:06 -08:00
user_agent.py user_agent: Use re.X to make the regex a little more readable. 2018-12-05 14:58:13 -08:00
user_groups.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
user_status.py user status: Add "status_text" support in the backend. 2019-01-24 09:46:35 -08:00
users.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
utils.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
validator.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
video_calls.py zoom: Fix handling of 201 status codes from zoom API. 2019-01-16 15:37:06 -08:00
widget.py zerver core: Remove unused imports. 2019-02-02 17:41:24 -08:00
zcommand.py zcommand: Fix broken switch mode message. 2018-08-08 11:29:49 -07:00
zephyr.py python: Remove now-unnecessary str_utils library. 2018-11-27 11:57:54 -08:00