Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/tests
History
Rohitt Vashishtha 3892a8afd8 messages: Set has_attachment correctly using Bugdown. 
Previously, we would naively set has_attachment just by searching
the whole messages for strings like `/user_uploads/...`. We now
prevent running do_claim_attachments for messages that obviously
do not have an attachment in them that we previously ran.

For example: attachments in codeblocks or
             attachments that otherwise do not match our link syntax.

The new implementation runs that check on only the urls that
bugdown determines should be rendered. We also refactor some
Attachment tests in test_messages to test this change.

The new method is:

1. Create a list of potential_attachment_urls in Bugdown while rendering.
2. Loop over this list in do_claim_attachments for the actual claiming.
   For saving:
3. If we claimed an attachment, set message.has_attachment to True.
   For updating:
3. If claimed_attachment != message.has_attachment: update has_attachment.

We do not modify the logic for 'unclaiming' attachments when editing.
 		2019-12-11 11:03:44 -08:00
..
fixtures bugdown: Reenable -,+ to begin a markdown list. 2019-12-09 16:13:02 -08:00
images emoji: Only resize custom emoji that need it. 2019-01-29 10:33:50 -08:00
__init__.py
…
test_alert_words.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_archive.py archives: Change the topic/<topic_name> code path to use topics prefix. 2018-07-14 10:39:35 +05:30
test_attachments.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_audit_log.py billing: Sync realm activation events for on-prem billing. 2019-10-08 17:18:30 -07:00
test_auth_backends.py auth: Eliminate if/else block for PreregUser handling with/without SSO. 2019-12-10 20:16:21 +01:00
test_bots.py users: Refactor get_members_backend endpoint to use get_raw_user_data. 2019-10-23 14:50:26 -07:00
test_bugdown.py markdown: Remove redundant checks from /me. 2019-12-03 17:17:10 -08:00
test_cache.py generic_bulk_cached_fetch: Only call query_function if necessary. 2019-08-15 17:14:02 -07:00
test_camo.py camo: Add endpoint to handle camo requests. 2019-01-04 10:27:04 -08:00
test_compatibility.py cleanup: Delete leading newlines. 2019-08-06 23:29:11 -07:00
test_create_video_call.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_custom_profile_data.py events: Only send bot_type for bots and thus remove the for_api param. 2019-10-29 15:41:35 -07:00
test_decorators.py validators: Add check_int_in validator. 2019-11-18 15:14:56 -08:00
test_digest.py models: Migration of Message.pub_date to date_sent, part 2. 2019-10-05 19:01:34 -07:00
test_docs.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_email_change.py urls: Tighten many unintentionally broad URL patterns. 2019-08-26 20:51:49 -07:00
test_email_log.py emails: Don't log emails while running test suite. 2018-10-11 15:12:08 -07:00
test_email_mirror.py email_mirror: Ignore missed message email if the user isn't active. 2019-09-20 17:58:10 -07:00
test_email_notifications.py email_notifs: Take full advantage of django_to_ldap_username. 2019-11-05 15:32:00 -08:00
test_embedded_bot_system.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_event_queue.py wildcard_mentions_notify: Add per-stream override of global setting. 2019-12-09 16:09:38 -08:00
test_events.py tests: Rename prereg_users to prereg_user in test_events. 2019-12-10 17:21:04 -08:00
test_external.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_feedback.py
…
test_gitter_importer.py tests: Move get_set to ZulipTestCase. 2019-05-21 14:10:29 -07:00
test_hipchat_importer.py hipchat: Limit messages in slim mode. 2018-11-26 16:37:30 -08:00
test_home.py streams: Eliminate some unnecessary get_stream_recipient calls. 2019-12-09 15:24:35 -08:00
test_hotspots.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_i18n.py tests: tearDown overrides should call super().tearDown(). 2019-10-18 13:36:59 -07:00
test_import_export.py models: Add recipient foreign key in UserProfile and Stream. 2019-12-09 15:14:41 -08:00
test_integrations_dev_panel.py request: Tighten type checking on REQ. 2019-11-13 12:35:55 -08:00
test_legacy_subject.py Add alias support to REQ helpers for subject/topic. 2018-11-12 15:47:11 -08:00
test_link_embed.py url preview: Replace YouTube URLs with their titles. 2019-07-12 19:14:19 -07:00
test_logging_handlers.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_management_commands.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_mattermost_importer.py test_mattermost_importer: Fix leftover references to message.pub_date. 2019-10-11 04:07:12 +02:00
test_message_edit_notifications.py settings: Add notification settings checkboxes for wildcard mentions. 2019-11-20 16:58:46 -08:00
test_messages.py messages: Set has_attachment correctly using Bugdown. 2019-12-11 11:03:44 -08:00
test_middleware.py open graph: Uploaded realm icon URL is absolute for some backends. 2019-05-20 13:14:28 -07:00
test_migrations.py test_migrations: Disable migrations test. 2019-05-12 22:06:17 -07:00
test_muting.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_narrow.py api: Remove legacy emoji reactions endpoint. 2019-11-12 13:07:06 -08:00
test_new_users.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_onboarding.py
…
test_openapi.py openapi: Specify securityScheme for the API in root level. 2019-12-06 11:19:08 -08:00
test_outgoing_webhook_interfaces.py tests: Improve outgoing webhook testing strategy. 2019-11-05 11:49:00 -08:00
test_outgoing_webhook_system.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_populate_db.py models: Migration of Message.pub_date to date_sent, part 2. 2019-10-05 19:01:34 -07:00
test_presence.py test_presence: Prepare for moving system bots to zulipinternal. 2019-07-20 14:55:21 -07:00
test_push_notifications.py push_notifs: Improve handling of errors when talking to the bouncer. 2019-12-04 09:58:22 -08:00
test_queue.py Upgrade pika to 1.1.*. 2019-10-29 17:01:12 -07:00
test_queue_worker.py tests: Rename invitor to inviter in test_signup and test_queue_worker. 2019-12-10 17:22:32 -08:00
test_reactions.py api: Remove legacy emoji reactions endpoint. 2019-11-12 13:07:06 -08:00
test_realm.py test_realm: Automate tests for invalid integer values in Realm. 2019-11-18 15:21:11 -08:00
test_realm_domains.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_realm_emoji.py get_realm: raise DoesNotExist instead of returning None. 2019-05-06 21:58:16 -07:00
test_realm_export.py billing: Change RealmAuditLog.event_type from str to int. 2019-10-06 15:55:56 -07:00
test_realm_filters.py linkifiers: Allow semicolons in target URLs. 2019-05-14 11:17:55 -07:00
test_report.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_retention.py messages: Set has_attachment correctly using Bugdown. 2019-12-11 11:03:44 -08:00
test_service_bot_system.py mypy: Upgrade from 0.720 to 0.730. 2019-11-13 12:38:45 -08:00
test_sessions.py zerver/tests: Remove unused imports. 2019-02-02 17:43:03 -08:00
test_settings.py auth: Use zxcvbn to ensure password strength on server side. 2019-11-21 10:23:37 -08:00
test_signup.py tests: Rename invitor to inviter in test_signup and test_queue_worker. 2019-12-10 17:22:32 -08:00
test_slack_importer.py slack import: Map Slack guest users to Zulip guests. 2019-11-12 12:12:59 -08:00
test_slack_message_conversion.py test_slack_message_conversion: Use subTest for fixtures test. 2019-09-13 11:54:14 -07:00
test_soft_deactivation.py soft-deactivation: Run catch-up when "auto" deactivate is run. 2019-03-14 11:53:15 -07:00
test_subdomains.py cleanup: Delete leading newlines. 2019-08-06 23:29:11 -07:00
test_submessage.py events: Pass a realm object into send_event. 2018-11-02 16:47:39 -07:00
test_subs.py wildcard_mentions_notify: Add per-stream override of global setting. 2019-12-09 16:09:38 -08:00
test_templates.py support: Pass various realm functions as template context. 2019-10-21 16:52:46 -07:00
test_thumbnail.py lint: Fix code that evaded our lint checks for string % non-tuple. 2019-04-23 15:21:37 -07:00
test_timestamp.py cleanup: Delete leading newlines. 2019-08-06 23:29:11 -07:00
test_tornado.py tornado: Remove stale user_profile_email field. 2019-11-15 17:07:52 -08:00
test_transfer.py management: Add tooling for transfering local uploads to s3. 2019-02-14 14:31:46 -08:00
test_tutorial.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_type_debug.py cleanup: Delete leading newlines. 2019-08-06 23:29:11 -07:00
test_typing.py test_typing: Prepare for moving system bots to zulipinternal. 2019-07-20 14:55:21 -07:00
test_unread.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_upload.py tests: setUp overrides should call super().setUp(). 2019-10-19 17:27:01 -07:00
test_urls.py urls: Tighten many unintentionally broad URL patterns. 2019-08-26 20:51:49 -07:00
test_user_groups.py settings: Add setting for who can edit user groups. 2019-11-03 16:45:13 -08:00
test_user_status.py user status: Add "status_text" support in the backend. 2019-01-24 09:46:35 -08:00
test_users.py models: Add recipient foreign key in UserProfile and Stream. 2019-12-09 15:14:41 -08:00
test_webhooks_common.py webhooks: Eliminate the usage of a headers.py file. 2019-06-26 10:35:14 -07:00
test_widgets.py widgets: Remove ALLOW_SUB_MESSAGES flag and enable widgets by default. 2019-01-29 09:34:14 -08:00
test_zcommand.py
…
test_zephyr.py cleanup: Delete leading newlines. 2019-08-06 23:29:11 -07:00