Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web
History
Sahil Batra fc5b63e5cd settings: Fix save-discard widget fo. 
The save-discard widget was not showing and hiding correctly
for the "Automated messages and emails" section in organization
settings panel. This was because the "proposed_val" was always
being returned as "undefined" for language setting as
"data-language-code", which is used to check the proposed value
of setting, was not set after changes in 36475daba7.
This commit fixes it by passing language_code value to
language_selection_widget and thus setting "data-language-code"
attribute correctly.

The changes in 36475daba7 removed language_code parameter from
language_selection_widget as it was not passed in the template
from "Display settings" section. So, this commit also passes
the language_code parameter to language_selection_widget from
"Display settings" section.
This change sets the "data-language-code" attribute even when
it is not being used there, to make sure there is no reference
to undefined fields in language_selection_widget.

Note that the above bug was reproducible only if you have not
changed the language even once and are trying to change the
other settings, as the data-language-code attribute was set
after selecting a language from the modal, but it was not
set initially after rendering the page.
 		2023-08-06 17:53:57 -07:00
..
e2e-tests settings_org: Migrate dropdowns to new DropdownWidget. 2023-07-27 14:10:08 -07:00
generated
…
html
…
images styles: Remove Firefox override for dropdown appearance. 2023-07-24 13:10:03 -07:00
shared poll_data: Revert to using "canned" instead of -1. 2023-07-20 09:55:09 -07:00
src settings: Fix save-discard widget fo. 2023-08-06 17:53:57 -07:00
styles print: Try to keep message headers with messages. 2023-08-06 13:27:40 -07:00
templates settings: Fix save-discard widget fo. 2023-08-06 17:53:57 -07:00
tests settings: Add a saving-saved indicator to the 'SETTINGS/TOPICS' UI. 2023-08-06 13:55:21 -07:00
third bootstrap: Remove bootstrap CSS for blockquote elements. 2023-07-23 15:44:58 -07:00
.browserslistrc webpack: Move webpack configuration to web. 2023-02-24 06:35:58 -08:00
.gitignore
…
babel.config.js dependencies: Upgrade JavaScript dependencies. 2023-07-21 15:58:42 -07:00
debug-require-webpack-plugin.ts
…
debug-require.js
…
postcss.config.js postcss: Enable postcss-preset-env. 2023-03-20 11:26:30 -07:00
webpack.assets.json ts: Convert `web/src/billing` module to TypeScript. 2023-06-23 11:42:29 -07:00
webpack.config.ts dependencies: Upgrade JavaScript dependencies. 2023-06-05 21:51:26 -07:00
webpack.dev-assets.json webpack: Move webpack configuration to web. 2023-02-24 06:35:58 -08:00